mirror of
https://github.com/moodle/moodle.git
synced 2025-03-14 20:50:21 +01:00
dfed4fd040
This commit implements the qbank api so that any plugin can implement its own question bank. This api currently works parallely with the moodle core classes and the added qbank in the core, means the moment a plugin is installed, that object is replaced with the object from the plugin instead of core, which means the api has flexibility till the plugins are integrated and the plugins can be integrated in any order. All the old classes are still there and not deprecated as there is a different tracker for the changes to the quiz and another tracker for class deprecation and class renaming. Core question units tests are pointing to the new api structure but the classes are pointing to the location related to the plugin availability. Co-Authored-By: Luca Bösch <luca.boesch@bfh.ch> Co-Authored-By: Guillermo Gomez Arias <guillermogomez@catalyst-au.net> one more array fix
123 lines
4.4 KiB
PHP
123 lines
4.4 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* Unit tests for the question bank view class.
|
|
*
|
|
* @package core_question
|
|
* @category test
|
|
* @copyright 2018 the Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
global $CFG;
|
|
require_once($CFG->dirroot . '/question/editlib.php');
|
|
|
|
|
|
/**
|
|
* Unit tests for the question bank view class.
|
|
*
|
|
* @copyright 2018 the Open University
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class core_question_bank_view_testcase extends advanced_testcase {
|
|
|
|
public function test_viewing_question_bank_should_not_load_individual_questions() {
|
|
$this->resetAfterTest();
|
|
$this->setAdminUser();
|
|
$generator = $this->getDataGenerator();
|
|
/** @var core_question_generator $questiongenerator */
|
|
$questiongenerator = $generator->get_plugin_generator('core_question');
|
|
|
|
// Create a course.
|
|
$course = $generator->create_course();
|
|
$context = context_course::instance($course->id);
|
|
|
|
// Create a question in the default category.
|
|
$contexts = new question_edit_contexts($context);
|
|
$cat = question_make_default_categories($contexts->all());
|
|
$questiondata = $questiongenerator->create_question('numerical', null,
|
|
['name' => 'Example question', 'category' => $cat->id]);
|
|
|
|
// Ensure the question is not in the cache.
|
|
$cache = cache::make('core', 'questiondata');
|
|
$cache->delete($questiondata->id);
|
|
|
|
// Generate the view.
|
|
$view = new core_question\local\bank\view($contexts, new moodle_url('/'), $course);
|
|
ob_start();
|
|
$pagevars = [
|
|
'qpage' => 0,
|
|
'qperpage' => 20,
|
|
'cat' => $cat->id . ',' . $context->id,
|
|
'recurse' => false,
|
|
'showhidden' => false,
|
|
'qbshowtext' => false
|
|
|
|
];
|
|
$view->display($pagevars, 'editq');
|
|
$html = ob_get_clean();
|
|
|
|
// Verify the output includes the expected question.
|
|
$this->assertStringContainsString('Example question', $html);
|
|
|
|
// Verify the question has not been loaded into the cache.
|
|
$this->assertFalse($cache->has($questiondata->id));
|
|
}
|
|
|
|
public function test_unknown_qtype_does_not_break_view() {
|
|
global $DB;
|
|
$this->resetAfterTest();
|
|
$this->setAdminUser();
|
|
$generator = $this->getDataGenerator();
|
|
/** @var core_question_generator $questiongenerator */
|
|
$questiongenerator = $generator->get_plugin_generator('core_question');
|
|
|
|
// Create a course.
|
|
$course = $generator->create_course();
|
|
$context = context_course::instance($course->id);
|
|
|
|
// Create a question in the default category.
|
|
$contexts = new question_edit_contexts($context);
|
|
$cat = question_make_default_categories($contexts->all());
|
|
$questiondata = $questiongenerator->create_question('numerical', null,
|
|
['name' => 'Example question', 'category' => $cat->id]);
|
|
$DB->set_field('question', 'qtype', 'unknownqtype', ['id' => $questiondata->id]);
|
|
|
|
// Generate the view.
|
|
$view = new core_question\local\bank\view($contexts, new moodle_url('/'), $course);
|
|
ob_start();
|
|
$pagevars = [
|
|
'qpage' => 0,
|
|
'qperpage' => 20,
|
|
'cat' => $cat->id . ',' . $context->id,
|
|
'recurse' => false,
|
|
'showhidden' => false,
|
|
'qbshowtext' => false
|
|
|
|
];
|
|
$view->display($pagevars, 'editq');
|
|
$html = ob_get_clean();
|
|
|
|
// Mainly we are verifying that there was no fatal error.
|
|
|
|
// Verify the output includes the expected question.
|
|
$this->assertStringContainsString('Example question', $html);
|
|
}
|
|
}
|