mirror of
https://github.com/moodle/moodle.git
synced 2025-06-05 07:35:09 +02:00
30e891e08f
Repository instances are stored in the 'repository' table. Repositories in the table are either 'Enabled and visible' or 'Enabled but hidden'. Hidden repositories still serve their files, but are not visible in the filepicker UI. Disabling a repository instance removes its record from the table. In the original implementation of the plugin manager (see b9934a17), the method plugintype_repository::get_enabled_repositories() correctly returned all records from the repository table. Then as a part of the bigger refactoring in MDL-41437, the commit bde002b8 replaced the original method with the new get_enabled_plugins() one which started to return visible repositories only. As a consequence, the admin tree stopped populating setting page nodes for hidden repository instances. So attempting to visit their setting page threw a section error. Credit goes to Ike Quigley for debugging and tracing this down. This patch fixes the way how the list of enabled repositories is populated by the plugin manager so that both visible and hidden repositories are returned again. This does not affect the filepicker itself as it is using its own methods for obtaining the list.
101 lines
3.4 KiB
PHP
101 lines
3.4 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* Defines classes used for plugin info.
|
|
*
|
|
* @package core
|
|
* @copyright 2011 David Mudrak <david@moodle.com>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
namespace core\plugininfo;
|
|
|
|
use moodle_url, part_of_admin_tree, admin_externalpage;
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
/**
|
|
* Class for repositories
|
|
*/
|
|
class repository extends base {
|
|
/**
|
|
* Finds all enabled plugins, the result may include missing plugins.
|
|
* @return array|null of enabled plugins $pluginname=>$pluginname, null means unknown
|
|
*/
|
|
public static function get_enabled_plugins() {
|
|
global $DB;
|
|
return $DB->get_records_menu('repository', null, 'type ASC', 'type, type AS val');
|
|
}
|
|
|
|
public function get_settings_section_name() {
|
|
return 'repositorysettings'.$this->name;
|
|
}
|
|
|
|
public function load_settings(part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig) {
|
|
if (!$this->is_installed_and_upgraded()) {
|
|
return;
|
|
}
|
|
|
|
if ($hassiteconfig && $this->is_enabled()) {
|
|
// Completely no access to repository setting when it is not enabled.
|
|
$sectionname = $this->get_settings_section_name();
|
|
$settingsurl = new moodle_url('/admin/repository.php',
|
|
array('sesskey' => sesskey(), 'action' => 'edit', 'repos' => $this->name));
|
|
$settings = new admin_externalpage($sectionname, $this->displayname,
|
|
$settingsurl, 'moodle/site:config', false);
|
|
$adminroot->add($parentnodename, $settings);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Return URL used for management of plugins of this type.
|
|
* @return moodle_url
|
|
*/
|
|
public static function get_manage_url() {
|
|
return new moodle_url('/admin/repository.php');
|
|
}
|
|
|
|
/**
|
|
* Defines if there should be a way to uninstall the plugin via the administration UI.
|
|
* @return boolean
|
|
*/
|
|
public function is_uninstall_allowed() {
|
|
if ($this->name === 'upload' || $this->name === 'coursefiles' || $this->name === 'user' || $this->name === 'recent') {
|
|
return false;
|
|
} else {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Pre-uninstall hook.
|
|
* This is intended for disabling of plugin, some DB table purging, etc.
|
|
* Converts all linked files to standard files when repository is removed
|
|
* and cleans up all records in the DB for that repository.
|
|
*/
|
|
public function uninstall_cleanup() {
|
|
global $CFG;
|
|
require_once($CFG->dirroot.'/repository/lib.php');
|
|
|
|
$repo = \repository::get_type_by_typename($this->name);
|
|
if ($repo) {
|
|
$repo->delete(true);
|
|
}
|
|
|
|
parent::uninstall_cleanup();
|
|
}
|
|
}
|