mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-15 21:38:24 +01:00
Code Issues Projects Releases Wiki Activity

skip var type in anonymous class for PropertyTypeDeclarationRector

Browse Source
This commit is contained in:
Tomas Votruba 2019-10-05 13:51:02 +02:00
parent 01b4c78e47
commit 058dd5aeb5
7 changed files with 42 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/TypeDeclaration/src/TypeInferer/PropertyTypeInferer/AllAssignNodePropertyTypeInferer.php
View File

@ -4,6 +4,7 @@ namespace Rector\TypeDeclaration\TypeInferer\PropertyTypeInferer;
use PhpParser\Node\Stmt\ClassLike;
use PhpParser\Node\Stmt\Property;
use PHPStan\Type\MixedType;
use PHPStan\Type\Type;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\TypeDeclaration\Contract\TypeInferer\PropertyTypeInfererInterface;
@ -24,8 +25,12 @@ final class AllAssignNodePropertyTypeInferer extends AbstractTypeInferer impleme
public function inferProperty(Property $property): Type
{
/** @var ClassLike $class */
/** @var ClassLike|null $class */
$class = $property->getAttribute(AttributeKey::CLASS_NODE);
if ($class === null) {
// anonymous class
return new MixedType();
}
$propertyName = $this->nameResolver->getName($property);

6
packages/TypeDeclaration/src/TypeInferer/PropertyTypeInferer/ConstructorPropertyTypeInferer.php
View File

@ -28,8 +28,12 @@ final class ConstructorPropertyTypeInferer extends AbstractTypeInferer implement
{
public function inferProperty(Property $property): Type
{
/** @var Class_ $class */
/** @var Class_|null $class */
$class = $property->getAttribute(AttributeKey::CLASS_NODE);
if ($class === null) {
// anonymous class
return new MixedType();
}
$classMethod = $class->getMethod('__construct');
if ($classMethod === null) {

6
packages/TypeDeclaration/src/TypeInferer/PropertyTypeInferer/GetterPropertyTypeInferer.php
View File

@ -45,8 +45,12 @@ final class GetterPropertyTypeInferer extends AbstractTypeInferer implements Pro
public function inferProperty(Property $property): Type
{
/** @var Class_ $class */
/** @var Class_|null $class */
$class = $property->getAttribute(AttributeKey::CLASS_NODE);
if ($class === null) {
// anonymous class
return new MixedType();
}
/** @var string $propertyName */
$propertyName = $this->nameResolver->getName($property);

6
packages/TypeDeclaration/src/TypeInferer/PropertyTypeInferer/GetterTypeDeclarationPropertyTypeInferer.php
View File

@ -29,8 +29,12 @@ final class GetterTypeDeclarationPropertyTypeInferer extends AbstractTypeInferer
public function inferProperty(Property $property): Type
{
/** @var Class_ $class */
/** @var Class_|null $class */
$class = $property->getAttribute(AttributeKey::CLASS_NODE);
if ($class === null) {
// anonymous class
return new MixedType();
}
/** @var string $propertyName */
$propertyName = $this->nameResolver->getName($property);

6
packages/TypeDeclaration/src/TypeInferer/PropertyTypeInferer/SingleMethodAssignedNodePropertyTypeInferer.php
View File

@ -19,8 +19,12 @@ final class SingleMethodAssignedNodePropertyTypeInferer extends AbstractTypeInfe
{
public function inferProperty(Property $property): Type
{
/** @var Class_ $class */
/** @var Class_|null $class */
$class = $property->getAttribute(AttributeKey::CLASS_NODE);
if ($class === null) {
// anonymous class
return new MixedType();
}
$classMethod = $class->getMethod('__construct');
if ($classMethod === null) {

15
packages/TypeDeclaration/tests/Rector/Property/PropertyTypeDeclarationRector/Fixture/skip_anonymous_class.php.inc Normal file
View File

@ -0,0 +1,15 @@
<?php
namespace Rector\TypeDeclaration\Tests\Rector\FunctionLike\PropertyTypeDeclarationRector\Fixture;
class SkipAnonymousClass
{
public function makeClass(int $bar = 1)
{
$class = new class() {
public $bar;
};
$class->bar = $bar;
}
}

1
packages/TypeDeclaration/tests/Rector/Property/PropertyTypeDeclarationRector/PropertyTypeDeclarationRectorTest.php
View File

@ -35,6 +35,7 @@ final class PropertyTypeDeclarationRectorTest extends AbstractRectorTestCase
yield [__DIR__ . '/Fixture/doctrine_relation_target_entity_same_namespace.php.inc'];
yield [__DIR__ . '/Fixture/setter_type.php.inc'];
yield [__DIR__ . '/Fixture/skip_multi_vars.php.inc'];
yield [__DIR__ . '/Fixture/skip_anonymous_class.php.inc'];
}
protected function getRectorClass(): string