mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-03-14 12:29:43 +01:00
Code Issues Projects Releases Wiki Activity

Extend AddDoesNotPerformAssertionToNonAssertingTestRector by ca… (#2645)

Browse Source 
Extend AddDoesNotPerformAssertionToNonAssertingTestRector by catching more test messages
This commit is contained in:
Tomas Votruba 2020-01-12 00:00:07 +01:00 committed by GitHub
commit 0ea5e8df5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/PHPUnit/src/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector.php
View File

@ -167,7 +167,7 @@ PHP
}
// A. try "->assert" shallow search first for performance
$hasDirectAssertCall = (bool) $this->hasDirectAssertCall($classMethod);
$hasDirectAssertCall = $this->hasDirectAssertCall($classMethod);
if ($hasDirectAssertCall) {
$this->containsAssertCallByClassMethod[$cacheHash] = $hasDirectAssertCall;
return $hasDirectAssertCall;
@ -187,7 +187,18 @@ PHP
return false;
}
return $this->isNames($node->name, ['assert*', 'expectException*', 'setExpectedException*']);
return $this->isNames($node->name, [
// prophecy
'should*',
'should',
'expect*',
'expect',
// phpunit
'*assert',
'assert*',
'expectException*',
'setExpectedException*',
]);
});
}