mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-04-21 16:02:23 +02:00
Code Issues Projects Releases Wiki Activity

various fixes

Browse Source
This commit is contained in:
TomasVotruba 2020-02-29 01:29:42 +01:00
parent 8f3e90ba7f
commit 128910963a
3 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rules/dead-code/src/Rector/MethodCall/RemoveDefaultArgumentValueRector.php
View File

@ -11,6 +11,8 @@ use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\FunctionLike;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\RectorDefinition\CodeSample;
use Rector\Core\RectorDefinition\RectorDefinition;
@ -111,6 +113,10 @@ PHP
return false;
}
if (! $node->name instanceof Identifier && ! $node->name instanceof Name) {
return true;
}
$functionName = $this->getName($node->name);
if ($functionName === null) {
return false;

5
rules/phpunit/src/Rector/Class_/AddSeeTestAnnotationRector.php
View File

@ -107,8 +107,11 @@ PHP
return true;
}
/** @var PhpDocInfo $phpDocInfo */
/** @var PhpDocInfo|null $phpDocInfo */
$phpDocInfo = $class->getAttribute(AttributeKey::PHP_DOC_INFO);
if ($phpDocInfo === null) {
return true;
}
$seeTags = $phpDocInfo->getTagsByName('see');

6
rules/phpunit/src/Rector/SpecificMethod/AssertTrueFalseInternalTypeToSpecificMethodRector.php
View File

@ -92,9 +92,13 @@ final class AssertTrueFalseInternalTypeToSpecificMethodRector extends AbstractPH
return null;
}
/** @var FuncCall $firstArgumentValue */
/** @var FuncCall|Node $firstArgumentValue */
$firstArgumentValue = $node->args[0]->value;
if (! $firstArgumentValue instanceof FuncCall) {
return null;
}
$functionName = $this->getName($firstArgumentValue);
if (! isset(self::OLD_FUNCTIONS_TO_TYPES[$functionName])) {
return null;