diff --git a/config/set/code-quality.php b/config/set/code-quality.php index f822a28514a..65eb3be9430 100644 --- a/config/set/code-quality.php +++ b/config/set/code-quality.php @@ -17,7 +17,6 @@ use Rector\CodeQuality\Rector\ClassMethod\NarrowUnionTypeDocRector; use Rector\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector; use Rector\CodeQuality\Rector\ClassMethod\ReturnTypeFromStrictScalarReturnExprRector; use Rector\CodeQuality\Rector\Concat\JoinStringConcatRector; -use Rector\CodeQuality\Rector\Do_\DoWhileBreakFalseToIfElseRector; use Rector\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector; use Rector\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector; use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector; @@ -114,5 +113,5 @@ return static function (RectorConfig $rectorConfig) : void { 'mbstrrpos' => 'mb_strrpos', 'mbsubstr' => 'mb_substr', ]); - $rectorConfig->rules([CombinedAssignRector::class, SimplifyEmptyArrayCheckRector::class, ReplaceMultipleBooleanNotRector::class, ForeachToInArrayRector::class, SimplifyForeachToCoalescingRector::class, SimplifyFuncGetArgsCountRector::class, SimplifyInArrayValuesRector::class, SimplifyStrposLowerRector::class, GetClassToInstanceOfRector::class, SimplifyArraySearchRector::class, SimplifyConditionsRector::class, SimplifyIfNotNullReturnRector::class, SimplifyIfReturnBoolRector::class, SimplifyUselessVariableRector::class, UnnecessaryTernaryExpressionRector::class, RemoveExtraParametersRector::class, SimplifyDeMorganBinaryRector::class, SimplifyTautologyTernaryRector::class, SimplifyForeachToArrayFilterRector::class, SingleInArrayToCompareRector::class, SimplifyIfElseToTernaryRector::class, JoinStringConcatRector::class, ConsecutiveNullCompareReturnsToNullCoalesceQueueRector::class, ExplicitBoolCompareRector::class, CombineIfRector::class, UseIdenticalOverEqualWithSameTypeRector::class, SimplifyBoolIdenticalTrueRector::class, SimplifyRegexPatternRector::class, BooleanNotIdenticalToNotIdenticalRector::class, StrvalToTypeCastRector::class, FloatvalToTypeCastRector::class, CallableThisArrayToAnonymousFunctionRector::class, AndAssignsToSeparateLinesRector::class, ForToForeachRector::class, CompactToVariablesRector::class, CompleteDynamicPropertiesRector::class, IsAWithStringWithThirdArgumentRector::class, StrlenZeroToIdenticalEmptyStringRector::class, RemoveAlwaysTrueConditionSetInConstructorRector::class, ThrowWithPreviousExceptionRector::class, RemoveSoleValueSprintfRector::class, ShortenElseIfRector::class, AddPregQuoteDelimiterRector::class, ArrayMergeOfNonArraysToSimpleArrayRector::class, IntvalToTypeCastRector::class, BoolvalToTypeCastRector::class, ArrayKeyExistsTernaryThenValueToCoalescingRector::class, AbsolutizeRequireAndIncludePathRector::class, ChangeArrayPushToArrayAssignRector::class, ForRepeatedCountToOwnVariableRector::class, ForeachItemsAssignToEmptyArrayToAssignRector::class, InlineIfToExplicitIfRector::class, ArrayKeysAndInArrayToArrayKeyExistsRector::class, SplitListAssignToSeparateLineRector::class, UnusedForeachValueToArrayKeysRector::class, CommonNotEqualRector::class, SetTypeToCastRector::class, LogicalToBooleanRector::class, VarToPublicPropertyRector::class, IssetOnPropertyObjectToPropertyExistsRector::class, NewStaticToNewSelfRector::class, UnwrapSprintfOneArgumentRector::class, SwitchNegatedTernaryRector::class, SingularSwitchToIfRector::class, SimplifyIfNullableReturnRector::class, NarrowUnionTypeDocRector::class, FuncGetArgsToVariadicParamRector::class, CallUserFuncToMethodCallRector::class, CallUserFuncWithArrowFunctionToInlineRector::class, CountArrayToEmptyArrayComparisonRector::class, FlipTypeControlToUseExclusiveTypeRector::class, ExplicitMethodCallOverMagicGetSetRector::class, DoWhileBreakFalseToIfElseRector::class, InlineArrayReturnAssignRector::class, InlineIsAInstanceOfRector::class, TernaryFalseExpressionToIfRector::class, InlineConstructorDefaultToPropertyRector::class, SimplifyIfExactValueReturnValueRector::class, SimplifyUselessLastVariableAssignRector::class, ReturnTypeFromStrictScalarReturnExprRector::class, TernaryEmptyArrayArrayDimFetchToCoalesceRector::class, OptionalParametersAfterRequiredRector::class, SimplifyEmptyCheckOnEmptyArrayRector::class]); + $rectorConfig->rules([CombinedAssignRector::class, SimplifyEmptyArrayCheckRector::class, ReplaceMultipleBooleanNotRector::class, ForeachToInArrayRector::class, SimplifyForeachToCoalescingRector::class, SimplifyFuncGetArgsCountRector::class, SimplifyInArrayValuesRector::class, SimplifyStrposLowerRector::class, GetClassToInstanceOfRector::class, SimplifyArraySearchRector::class, SimplifyConditionsRector::class, SimplifyIfNotNullReturnRector::class, SimplifyIfReturnBoolRector::class, SimplifyUselessVariableRector::class, UnnecessaryTernaryExpressionRector::class, RemoveExtraParametersRector::class, SimplifyDeMorganBinaryRector::class, SimplifyTautologyTernaryRector::class, SimplifyForeachToArrayFilterRector::class, SingleInArrayToCompareRector::class, SimplifyIfElseToTernaryRector::class, JoinStringConcatRector::class, ConsecutiveNullCompareReturnsToNullCoalesceQueueRector::class, ExplicitBoolCompareRector::class, CombineIfRector::class, UseIdenticalOverEqualWithSameTypeRector::class, SimplifyBoolIdenticalTrueRector::class, SimplifyRegexPatternRector::class, BooleanNotIdenticalToNotIdenticalRector::class, StrvalToTypeCastRector::class, FloatvalToTypeCastRector::class, CallableThisArrayToAnonymousFunctionRector::class, AndAssignsToSeparateLinesRector::class, ForToForeachRector::class, CompactToVariablesRector::class, CompleteDynamicPropertiesRector::class, IsAWithStringWithThirdArgumentRector::class, StrlenZeroToIdenticalEmptyStringRector::class, RemoveAlwaysTrueConditionSetInConstructorRector::class, ThrowWithPreviousExceptionRector::class, RemoveSoleValueSprintfRector::class, ShortenElseIfRector::class, AddPregQuoteDelimiterRector::class, ArrayMergeOfNonArraysToSimpleArrayRector::class, IntvalToTypeCastRector::class, BoolvalToTypeCastRector::class, ArrayKeyExistsTernaryThenValueToCoalescingRector::class, AbsolutizeRequireAndIncludePathRector::class, ChangeArrayPushToArrayAssignRector::class, ForRepeatedCountToOwnVariableRector::class, ForeachItemsAssignToEmptyArrayToAssignRector::class, InlineIfToExplicitIfRector::class, ArrayKeysAndInArrayToArrayKeyExistsRector::class, SplitListAssignToSeparateLineRector::class, UnusedForeachValueToArrayKeysRector::class, CommonNotEqualRector::class, SetTypeToCastRector::class, LogicalToBooleanRector::class, VarToPublicPropertyRector::class, IssetOnPropertyObjectToPropertyExistsRector::class, NewStaticToNewSelfRector::class, UnwrapSprintfOneArgumentRector::class, SwitchNegatedTernaryRector::class, SingularSwitchToIfRector::class, SimplifyIfNullableReturnRector::class, NarrowUnionTypeDocRector::class, FuncGetArgsToVariadicParamRector::class, CallUserFuncToMethodCallRector::class, CallUserFuncWithArrowFunctionToInlineRector::class, CountArrayToEmptyArrayComparisonRector::class, FlipTypeControlToUseExclusiveTypeRector::class, ExplicitMethodCallOverMagicGetSetRector::class, InlineArrayReturnAssignRector::class, InlineIsAInstanceOfRector::class, TernaryFalseExpressionToIfRector::class, InlineConstructorDefaultToPropertyRector::class, SimplifyIfExactValueReturnValueRector::class, SimplifyUselessLastVariableAssignRector::class, ReturnTypeFromStrictScalarReturnExprRector::class, TernaryEmptyArrayArrayDimFetchToCoalesceRector::class, OptionalParametersAfterRequiredRector::class, SimplifyEmptyCheckOnEmptyArrayRector::class]); }; diff --git a/docs/rector_rules_overview.md b/docs/rector_rules_overview.md index e47f8dc3f98..0a19624fa84 100644 --- a/docs/rector_rules_overview.md +++ b/docs/rector_rules_overview.md @@ -1,4 +1,4 @@ -# 414 Rules Overview +# 413 Rules Overview <br> @@ -6,7 +6,7 @@ - [Arguments](#arguments) (5) -- [CodeQuality](#codequality) (79) +- [CodeQuality](#codequality) (78) - [CodingStyle](#codingstyle) (39) @@ -651,29 +651,6 @@ return static function (RectorConfig $rectorConfig): void { <br> -### DoWhileBreakFalseToIfElseRector - -Replace do (...} while (false); with more readable if/else conditions - -- class: [`Rector\CodeQuality\Rector\Do_\DoWhileBreakFalseToIfElseRector`](../rules/CodeQuality/Rector/Do_/DoWhileBreakFalseToIfElseRector.php) - -```diff --do { -- if (mt_rand(0, 1)) { -- $value = 5; -- break; -- } -- -+if (mt_rand(0, 1)) { -+ $value = 5; -+} else { - $value = 10; --} while (false); -+} -``` - -<br> - ### ExplicitBoolCompareRector Make if conditions more explicit diff --git a/rules/CodeQuality/Rector/Do_/DoWhileBreakFalseToIfElseRector.php b/rules/CodeQuality/Rector/Do_/DoWhileBreakFalseToIfElseRector.php deleted file mode 100644 index dc03e9c9847..00000000000 --- a/rules/CodeQuality/Rector/Do_/DoWhileBreakFalseToIfElseRector.php +++ /dev/null @@ -1,95 +0,0 @@ -<?php - -declare (strict_types=1); -namespace Rector\CodeQuality\Rector\Do_; - -use PhpParser\Node; -use PhpParser\Node\Stmt; -use PhpParser\Node\Stmt\Break_; -use PhpParser\Node\Stmt\Do_; -use PhpParser\Node\Stmt\Else_; -use PhpParser\Node\Stmt\If_; -use Rector\Core\Rector\AbstractRector; -use Rector\NodeTypeResolver\Node\AttributeKey; -use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample; -use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; -/** - * @see \Rector\Tests\CodeQuality\Rector\Do_\DoWhileBreakFalseToIfElseRector\DoWhileBreakFalseToIfElseRectorTest - */ -final class DoWhileBreakFalseToIfElseRector extends AbstractRector -{ - public function getRuleDefinition() : RuleDefinition - { - return new RuleDefinition('Replace do (...} while (false); with more readable if/else conditions', [new CodeSample(<<<'CODE_SAMPLE' -do { - if (mt_rand(0, 1)) { - $value = 5; - break; - } - - $value = 10; -} while (false); -CODE_SAMPLE -, <<<'CODE_SAMPLE' -if (mt_rand(0, 1)) { - $value = 5; -} else { - $value = 10; -} -CODE_SAMPLE -)]); - } - /** - * @return array<class-string<Node>> - */ - public function getNodeTypes() : array - { - return [Do_::class]; - } - /** - * @param Do_ $node - * @return Stmt[]|null - */ - public function refactor(Node $node) : ?array - { - if (!$this->valueResolver->isFalse($node->cond)) { - return null; - } - $currentStmts = $node->stmts; - return $this->resolveNewStmts($currentStmts); - } - /** - * @param Stmt[] $currentStmts - * @return Stmt[] - */ - private function resolveNewStmts(array $currentStmts) : array - { - $foundBreak = $this->betterNodeFinder->findFirstInstanceOf($currentStmts, Break_::class); - if (!$foundBreak instanceof Break_) { - return $currentStmts; - } - $newStmts = []; - foreach ($currentStmts as $key => $currentStmt) { - $foundBreak = $this->betterNodeFinder->findFirstInstanceOf($currentStmt, Break_::class); - if (!$foundBreak instanceof Break_) { - continue; - } - $this->removeNode($foundBreak); - // collect rest of nodes - $restOfStmts = \array_slice($currentStmts, $key + 1, \count($currentStmts)); - $currentIf = $currentStmt instanceof If_ ? $currentStmt : $this->betterNodeFinder->findInstanceOf($currentStmt, If_::class); - if (!$currentIf instanceof If_) { - continue; - } - // reprint new tokens - $currentIf->setAttribute(AttributeKey::ORIGINAL_NODE, null); - if ($restOfStmts !== []) { - $restOfStmts = $this->resolveNewStmts($restOfStmts); - $currentIf->else = new Else_($restOfStmts); - } - $newStmts[] = $currentStmt; - break; - } - return $newStmts; - } -} diff --git a/src/Application/VersionResolver.php b/src/Application/VersionResolver.php index 63dd1bf0be9..e2180158a6d 100644 --- a/src/Application/VersionResolver.php +++ b/src/Application/VersionResolver.php @@ -19,12 +19,12 @@ final class VersionResolver * @api * @var string */ - public const PACKAGE_VERSION = '9807d95c6b83a852c60d103e148cca123fd7ca01'; + public const PACKAGE_VERSION = '208d52e2a160e8563ef94e2afc53239f8ecf55cf'; /** * @api * @var string */ - public const RELEASE_DATE = '2023-02-08 17:07:17'; + public const RELEASE_DATE = '2023-02-08 17:40:09'; /** * @var int */ diff --git a/vendor/autoload.php b/vendor/autoload.php index d8dd45f530e..5d4f1b5be68 100644 --- a/vendor/autoload.php +++ b/vendor/autoload.php @@ -22,4 +22,4 @@ if (PHP_VERSION_ID < 50600) { require_once __DIR__ . '/composer/autoload_real.php'; -return ComposerAutoloaderInit4d48978043fb9a6d4fd0cbc7afecf708::getLoader(); +return ComposerAutoloaderInit54031ec18a21c57f66e220927be670bb::getLoader(); diff --git a/vendor/composer/autoload_classmap.php b/vendor/composer/autoload_classmap.php index f003068b158..5bffb5251ea 100644 --- a/vendor/composer/autoload_classmap.php +++ b/vendor/composer/autoload_classmap.php @@ -1211,7 +1211,6 @@ return array( 'Rector\\CodeQuality\\Rector\\Class_\\CompleteDynamicPropertiesRector' => $baseDir . '/rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php', 'Rector\\CodeQuality\\Rector\\Class_\\InlineConstructorDefaultToPropertyRector' => $baseDir . '/rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php', 'Rector\\CodeQuality\\Rector\\Concat\\JoinStringConcatRector' => $baseDir . '/rules/CodeQuality/Rector/Concat/JoinStringConcatRector.php', - 'Rector\\CodeQuality\\Rector\\Do_\\DoWhileBreakFalseToIfElseRector' => $baseDir . '/rules/CodeQuality/Rector/Do_/DoWhileBreakFalseToIfElseRector.php', 'Rector\\CodeQuality\\Rector\\Empty_\\SimplifyEmptyCheckOnEmptyArrayRector' => $baseDir . '/rules/CodeQuality/Rector/Empty_/SimplifyEmptyCheckOnEmptyArrayRector.php', 'Rector\\CodeQuality\\Rector\\Equal\\UseIdenticalOverEqualWithSameTypeRector' => $baseDir . '/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php', 'Rector\\CodeQuality\\Rector\\Expression\\InlineIfToExplicitIfRector' => $baseDir . '/rules/CodeQuality/Rector/Expression/InlineIfToExplicitIfRector.php', diff --git a/vendor/composer/autoload_real.php b/vendor/composer/autoload_real.php index 9765447cf00..286ebe270cb 100644 --- a/vendor/composer/autoload_real.php +++ b/vendor/composer/autoload_real.php @@ -2,7 +2,7 @@ // autoload_real.php @generated by Composer -class ComposerAutoloaderInit4d48978043fb9a6d4fd0cbc7afecf708 +class ComposerAutoloaderInit54031ec18a21c57f66e220927be670bb { private static $loader; @@ -22,17 +22,17 @@ class ComposerAutoloaderInit4d48978043fb9a6d4fd0cbc7afecf708 return self::$loader; } - spl_autoload_register(array('ComposerAutoloaderInit4d48978043fb9a6d4fd0cbc7afecf708', 'loadClassLoader'), true, true); + spl_autoload_register(array('ComposerAutoloaderInit54031ec18a21c57f66e220927be670bb', 'loadClassLoader'), true, true); self::$loader = $loader = new \Composer\Autoload\ClassLoader(\dirname(__DIR__)); - spl_autoload_unregister(array('ComposerAutoloaderInit4d48978043fb9a6d4fd0cbc7afecf708', 'loadClassLoader')); + spl_autoload_unregister(array('ComposerAutoloaderInit54031ec18a21c57f66e220927be670bb', 'loadClassLoader')); require __DIR__ . '/autoload_static.php'; - call_user_func(\Composer\Autoload\ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708::getInitializer($loader)); + call_user_func(\Composer\Autoload\ComposerStaticInit54031ec18a21c57f66e220927be670bb::getInitializer($loader)); $loader->setClassMapAuthoritative(true); $loader->register(true); - $filesToLoad = \Composer\Autoload\ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708::$files; + $filesToLoad = \Composer\Autoload\ComposerStaticInit54031ec18a21c57f66e220927be670bb::$files; $requireFile = \Closure::bind(static function ($fileIdentifier, $file) { if (empty($GLOBALS['__composer_autoload_files'][$fileIdentifier])) { $GLOBALS['__composer_autoload_files'][$fileIdentifier] = true; diff --git a/vendor/composer/autoload_static.php b/vendor/composer/autoload_static.php index f6c4a924dcf..3c70804d10c 100644 --- a/vendor/composer/autoload_static.php +++ b/vendor/composer/autoload_static.php @@ -4,7 +4,7 @@ namespace Composer\Autoload; -class ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708 +class ComposerStaticInit54031ec18a21c57f66e220927be670bb { public static $files = array ( 'ad155f8f1cf0d418fe49e248db8c661b' => __DIR__ . '/..' . '/react/promise/src/functions_include.php', @@ -1458,7 +1458,6 @@ class ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708 'Rector\\CodeQuality\\Rector\\Class_\\CompleteDynamicPropertiesRector' => __DIR__ . '/../..' . '/rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php', 'Rector\\CodeQuality\\Rector\\Class_\\InlineConstructorDefaultToPropertyRector' => __DIR__ . '/../..' . '/rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php', 'Rector\\CodeQuality\\Rector\\Concat\\JoinStringConcatRector' => __DIR__ . '/../..' . '/rules/CodeQuality/Rector/Concat/JoinStringConcatRector.php', - 'Rector\\CodeQuality\\Rector\\Do_\\DoWhileBreakFalseToIfElseRector' => __DIR__ . '/../..' . '/rules/CodeQuality/Rector/Do_/DoWhileBreakFalseToIfElseRector.php', 'Rector\\CodeQuality\\Rector\\Empty_\\SimplifyEmptyCheckOnEmptyArrayRector' => __DIR__ . '/../..' . '/rules/CodeQuality/Rector/Empty_/SimplifyEmptyCheckOnEmptyArrayRector.php', 'Rector\\CodeQuality\\Rector\\Equal\\UseIdenticalOverEqualWithSameTypeRector' => __DIR__ . '/../..' . '/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php', 'Rector\\CodeQuality\\Rector\\Expression\\InlineIfToExplicitIfRector' => __DIR__ . '/../..' . '/rules/CodeQuality/Rector/Expression/InlineIfToExplicitIfRector.php', @@ -3098,9 +3097,9 @@ class ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708 public static function getInitializer(ClassLoader $loader) { return \Closure::bind(function () use ($loader) { - $loader->prefixLengthsPsr4 = ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708::$prefixLengthsPsr4; - $loader->prefixDirsPsr4 = ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708::$prefixDirsPsr4; - $loader->classMap = ComposerStaticInit4d48978043fb9a6d4fd0cbc7afecf708::$classMap; + $loader->prefixLengthsPsr4 = ComposerStaticInit54031ec18a21c57f66e220927be670bb::$prefixLengthsPsr4; + $loader->prefixDirsPsr4 = ComposerStaticInit54031ec18a21c57f66e220927be670bb::$prefixDirsPsr4; + $loader->classMap = ComposerStaticInit54031ec18a21c57f66e220927be670bb::$classMap; }, null, ClassLoader::class); }