From 2b29db08399cb5456da677af87bb3181e3297aec Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Fri, 14 Dec 2018 20:34:40 +0100 Subject: [PATCH] rename ValueObjectRemover*Rector to more propper ObjectToScalar*Rector --- .../AbstractObjectToScalarRector.php} | 9 ++-- .../ObjectToScalarDocBlockRector.php} | 23 +++------ .../ObjectToScalarRector.php} | 47 +++++++------------ .../Fixture/fixture.php.inc | 8 ++-- .../Fixture/fixture2.php.inc | 8 ++-- .../Fixture/fixture3.php.inc | 35 ++++++++++++++ .../ObjectToScalarDocBlockRectorTest.php | 32 +++++++++++++ .../Source/SomeChildOfValueObject.php | 2 +- .../Source/SomeValueObject.php | 8 ++++ .../Fixture/fixture.php.inc | 8 ++-- .../Fixture/fixture2.php.inc | 2 +- .../Fixture/fixture3.php.inc | 4 +- .../Fixture/fixture4.php.inc | 4 +- .../ObjectToScalarRectorTest.php | 33 +++++++++++++ .../Source/SomeChildOfValueObject.php | 2 +- .../Source/SomeValueObject.php | 8 ++++ .../Fixture/fixture3.php.inc | 35 -------------- .../Source/SomeValueObject.php | 8 ---- .../ValueObjectRemoverDocBlockRectorTest.php | 34 -------------- .../Source/SomeValueObject.php | 8 ---- .../ValueObjectRemoverRectorTest.php | 35 -------------- .../PropertyTypeResolverTest.php | 4 +- .../PropertyTypeResolver/Source/fixture.php | 4 +- 23 files changed, 165 insertions(+), 196 deletions(-) rename packages/DomainDrivenDesign/src/Rector/{ValueObjectRemover/AbstractValueObjectRemoverRector.php => ObjectToScalar/AbstractObjectToScalarRector.php} (83%) rename packages/DomainDrivenDesign/src/Rector/{ValueObjectRemover/ValueObjectRemoverDocBlockRector.php => ObjectToScalar/ObjectToScalarDocBlockRector.php} (88%) rename packages/DomainDrivenDesign/src/Rector/{ValueObjectRemover/ValueObjectRemoverRector.php => ObjectToScalar/ObjectToScalarRector.php} (68%) rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverDocBlockRector => ObjectToScalarDocBlockRector}/Fixture/fixture.php.inc (61%) rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverDocBlockRector => ObjectToScalarDocBlockRector}/Fixture/fixture2.php.inc (55%) create mode 100644 packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Fixture/fixture3.php.inc create mode 100644 packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/ObjectToScalarDocBlockRectorTest.php rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverDocBlockRector => ObjectToScalarDocBlockRector}/Source/SomeChildOfValueObject.php (50%) create mode 100644 packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Source/SomeValueObject.php rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverRector => ObjectToScalarRector}/Fixture/fixture.php.inc (63%) rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverRector => ObjectToScalarRector}/Fixture/fixture2.php.inc (79%) rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverRector => ObjectToScalarRector}/Fixture/fixture3.php.inc (68%) rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverRector => ObjectToScalarRector}/Fixture/fixture4.php.inc (73%) create mode 100644 packages/DomainDrivenDesign/tests/Rector/ObjectToScalarRector/ObjectToScalarRectorTest.php rename packages/DomainDrivenDesign/tests/Rector/{ValueObjectRemoverRector => ObjectToScalarRector}/Source/SomeChildOfValueObject.php (52%) create mode 100644 packages/DomainDrivenDesign/tests/Rector/ObjectToScalarRector/Source/SomeValueObject.php delete mode 100644 packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Fixture/fixture3.php.inc delete mode 100644 packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Source/SomeValueObject.php delete mode 100644 packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/ValueObjectRemoverDocBlockRectorTest.php delete mode 100644 packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/Source/SomeValueObject.php delete mode 100644 packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/ValueObjectRemoverRectorTest.php diff --git a/packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/AbstractValueObjectRemoverRector.php b/packages/DomainDrivenDesign/src/Rector/ObjectToScalar/AbstractObjectToScalarRector.php similarity index 83% rename from packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/AbstractValueObjectRemoverRector.php rename to packages/DomainDrivenDesign/src/Rector/ObjectToScalar/AbstractObjectToScalarRector.php index bb566620682..5a0ed675dea 100644 --- a/packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/AbstractValueObjectRemoverRector.php +++ b/packages/DomainDrivenDesign/src/Rector/ObjectToScalar/AbstractObjectToScalarRector.php @@ -1,15 +1,14 @@ valueObjectsToSimpleTypes = $valueObjectsToSimpleTypes; $this->docBlockAnalyzer = $docBlockAnalyzer; $this->betterNodeFinder = $betterNodeFinder; - $this->namespaceAnalyzer = $rectorNamespaceAnalyzer; + $this->namespaceAnalyzer = $namespaceAnalyzer; } protected function matchNewType(Node $node): ?string diff --git a/packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/ValueObjectRemoverDocBlockRector.php b/packages/DomainDrivenDesign/src/Rector/ObjectToScalar/ObjectToScalarDocBlockRector.php similarity index 88% rename from packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/ValueObjectRemoverDocBlockRector.php rename to packages/DomainDrivenDesign/src/Rector/ObjectToScalar/ObjectToScalarDocBlockRector.php index 3f236f5b325..779f1c48f0c 100644 --- a/packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/ValueObjectRemoverDocBlockRector.php +++ b/packages/DomainDrivenDesign/src/Rector/ObjectToScalar/ObjectToScalarDocBlockRector.php @@ -1,6 +1,6 @@ [ - 'ValueObject' => 'string', - ], - ] - ), - new ConfiguredCodeSample( - <<<'CODE_SAMPLE' -/** @var ValueObject|null */ -$name; -CODE_SAMPLE - , - <<<'CODE_SAMPLE' + /** @var string|null */ $name; CODE_SAMPLE diff --git a/packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/ValueObjectRemoverRector.php b/packages/DomainDrivenDesign/src/Rector/ObjectToScalar/ObjectToScalarRector.php similarity index 68% rename from packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/ValueObjectRemoverRector.php rename to packages/DomainDrivenDesign/src/Rector/ObjectToScalar/ObjectToScalarRector.php index a80d555d579..0f2142aa786 100644 --- a/packages/DomainDrivenDesign/src/Rector/ValueObjectRemover/ValueObjectRemoverRector.php +++ b/packages/DomainDrivenDesign/src/Rector/ObjectToScalar/ObjectToScalarRector.php @@ -1,6 +1,6 @@ [ - 'ValueObject' => 'string', - ], - ] - ), - new ConfiguredCodeSample( - 'function someFunction(ValueObject $name) { }', - 'function someFunction(string $name) { }', - [ - '$valueObjectsToSimpleTypes' => [ - 'ValueObject' => 'string', - ], - ] - ), - new ConfiguredCodeSample( - 'function someFunction(): ValueObject { }', - 'function someFunction(): string { }', - [ - '$valueObjectsToSimpleTypes' => [ - 'ValueObject' => 'string', - ], - ] - ), - new ConfiguredCodeSample( - 'function someFunction(): ?ValueObject { }', - 'function someFunction(): ?string { }', +<<<'CODE_SAMPLE' +$name = new ValueObject("name"); + +function someFunction(ValueObject $name): ?ValueObject { +} +CODE_SAMPLE + , +<<<'CODE_SAMPLE' +$name = "name"; + +function someFunction(string $name): ?string { +} +CODE_SAMPLE + , [ '$valueObjectsToSimpleTypes' => [ 'ValueObject' => 'string', diff --git a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Fixture/fixture.php.inc b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Fixture/fixture.php.inc similarity index 61% rename from packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Fixture/fixture.php.inc rename to packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Fixture/fixture.php.inc index 8a3aa491824..2ed06d78684 100644 --- a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Fixture/fixture.php.inc +++ b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Fixture/fixture.php.inc @@ -1,8 +1,8 @@ +----- + diff --git a/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/ObjectToScalarDocBlockRectorTest.php b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/ObjectToScalarDocBlockRectorTest.php new file mode 100644 index 00000000000..e9cd929f689 --- /dev/null +++ b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/ObjectToScalarDocBlockRectorTest.php @@ -0,0 +1,32 @@ +doTestFiles([ + __DIR__ . '/Fixture/fixture.php.inc', + __DIR__ . '/Fixture/fixture2.php.inc', + __DIR__ . '/Fixture/fixture3.php.inc', + ]); + } + + protected function getRectorClass(): string + { + return ObjectToScalarDocBlockRector::class; + } + + /** + * @return mixed[] + */ + protected function getRectorConfiguration(): array + { + return [SomeValueObject::class => 'string']; + } +} diff --git a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Source/SomeChildOfValueObject.php b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Source/SomeChildOfValueObject.php similarity index 50% rename from packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Source/SomeChildOfValueObject.php rename to packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Source/SomeChildOfValueObject.php index 554690e618a..3e1489638da 100644 --- a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Source/SomeChildOfValueObject.php +++ b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarDocBlockRector/Source/SomeChildOfValueObject.php @@ -1,6 +1,6 @@ doTestFiles([ + __DIR__ . '/Fixture/fixture.php.inc', + __DIR__ . '/Fixture/fixture2.php.inc', + __DIR__ . '/Fixture/fixture3.php.inc', + __DIR__ . '/Fixture/fixture4.php.inc', + ]); + } + + protected function getRectorClass(): string + { + return ObjectToScalarRector::class; + } + + /** + * @return mixed[] + */ + protected function getRectorConfiguration(): array + { + return [SomeValueObject::class => 'string']; + } +} diff --git a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/Source/SomeChildOfValueObject.php b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarRector/Source/SomeChildOfValueObject.php similarity index 52% rename from packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/Source/SomeChildOfValueObject.php rename to packages/DomainDrivenDesign/tests/Rector/ObjectToScalarRector/Source/SomeChildOfValueObject.php index 98fbb5181de..620e5cd5a82 100644 --- a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/Source/SomeChildOfValueObject.php +++ b/packages/DomainDrivenDesign/tests/Rector/ObjectToScalarRector/Source/SomeChildOfValueObject.php @@ -1,6 +1,6 @@ ------ - diff --git a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Source/SomeValueObject.php b/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Source/SomeValueObject.php deleted file mode 100644 index 8bae2097a53..00000000000 --- a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverDocBlockRector/Source/SomeValueObject.php +++ /dev/null @@ -1,8 +0,0 @@ -doTestFiles( - [ - __DIR__ . '/Fixture/fixture.php.inc', - __DIR__ . '/Fixture/fixture2.php.inc', - __DIR__ . '/Fixture/fixture3.php.inc', - ] - ); - } - - protected function getRectorClass(): string - { - return ValueObjectRemoverDocBlockRector::class; - } - - /** - * @return mixed[] - */ - protected function getRectorConfiguration(): array - { - return [SomeValueObject::class => 'string']; - } -} diff --git a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/Source/SomeValueObject.php b/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/Source/SomeValueObject.php deleted file mode 100644 index 5af135dd7ad..00000000000 --- a/packages/DomainDrivenDesign/tests/Rector/ValueObjectRemoverRector/Source/SomeValueObject.php +++ /dev/null @@ -1,8 +0,0 @@ -doTestFiles( - [ - __DIR__ . '/Fixture/fixture.php.inc', - __DIR__ . '/Fixture/fixture2.php.inc', - __DIR__ . '/Fixture/fixture3.php.inc', - __DIR__ . '/Fixture/fixture4.php.inc', - ] - ); - } - - protected function getRectorClass(): string - { - return ValueObjectRemoverRector::class; - } - - /** - * @return mixed[] - */ - protected function getRectorConfiguration(): array - { - return [SomeValueObject::class => 'string']; - } -} diff --git a/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/PropertyTypeResolverTest.php b/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/PropertyTypeResolverTest.php index 52f6768cc01..6fff3b8b5f0 100644 --- a/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/PropertyTypeResolverTest.php +++ b/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/PropertyTypeResolverTest.php @@ -4,8 +4,8 @@ namespace Rector\NodeTypeResolver\Tests\PerNodeTypeResolver\PropertyTypeResolver use Iterator; use PhpParser\Node\Stmt\Property; -use Rector\DomainDrivenDesign\Tests\Rector\ValueObjectRemoverDocBlockRector\Source\SomeChildOfValueObject; -use Rector\DomainDrivenDesign\Tests\Rector\ValueObjectRemoverDocBlockRector\Source\SomeValueObject; +use Rector\DomainDrivenDesign\Tests\Rector\ObjectToScalarDocBlockRector\Source\SomeChildOfValueObject; +use Rector\DomainDrivenDesign\Tests\Rector\ObjectToScalarDocBlockRector\Source\SomeValueObject; use Rector\NodeTypeResolver\Tests\PerNodeTypeResolver\AbstractNodeTypeResolverTest; use Rector\NodeTypeResolver\Tests\PerNodeTypeResolver\PropertyTypeResolver\Source\ClassThatExtendsHtml; use Rector\NodeTypeResolver\Tests\PerNodeTypeResolver\PropertyTypeResolver\Source\Html; diff --git a/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/Source/fixture.php b/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/Source/fixture.php index 0de88a86861..c88f485606e 100644 --- a/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/Source/fixture.php +++ b/packages/NodeTypeResolver/tests/PerNodeTypeResolver/PropertyTypeResolver/Source/fixture.php @@ -1,8 +1,8 @@