Fix UnusedForeachValueToArrayKeysRector on objects (#4750)

rules/code-quality/src/Rector/Foreach_/UnusedForeachValueToArrayKeysRector.php

@@ -8,6 +8,7 @@ use PhpParser\Node;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt\Foreach_;
+use PHPStan\Type\ObjectType;
 use Rector\Core\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -84,6 +85,10 @@ CODE_SAMPLE
             return null;
         }
 
+        if (is_a($this->getStaticType($node->expr), ObjectType::class)) {
+            return null;
+        }
+
         $this->removeForeachValueAndUseArrayKeys($node);
 
         return $node;

rules/code-quality/tests/Rector/Foreach_/UnusedForeachValueToArrayKeysRector/Fixture/skip_values_is_object.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\CodeQuality\Tests\Rector\Foreach_\UnusedForeachValueToArrayKeysRector\Fixture;
+
+use Rector\CodeQuality\Tests\Rector\Foreach_\UnusedForeachValueToArrayKeysRector\Source\Collection;
+
+class SkipValuesIsObject
+{
+    public function run()
+    {
+        $collection = new Collection();
+        foreach ($collection as $key => $value) {
+            $collection[$key] = null;
+        }
+    }
+}
+
+?>

rules/code-quality/tests/Rector/Foreach_/UnusedForeachValueToArrayKeysRector/Source/Collection.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\CodeQuality\Tests\Rector\Foreach_\UnusedForeachValueToArrayKeysRector\Source;
+
+class Collection implements \IteratorAggregate
+{
+    public function getIterator()
+    {
+    }
+}