From 3212b81d9a9a122d9bbe81f143d5bba259389f74 Mon Sep 17 00:00:00 2001
From: TomasVotruba <tomas.vot@gmail.com>
Date: Thu, 23 Jan 2020 12:33:18 +0100
Subject: [PATCH] decopule FindAll methdo call manipulator

---
 .../FindRepositoryMethodFactoryInterface.php  |  9 ------
 ...toryFindMethodCallManipulatorInterface.php | 14 +++++++++
 ...ctrineRepositoryClassMethodManipulator.php | 30 ++++++++++++-------
 ...actRepositoryFindMethodCallManipulator.php | 19 ++++++++++++
 ...AllRepositoryFindMethodCallManipulator.php | 25 ++++++++++++++++
 5 files changed, 77 insertions(+), 20 deletions(-)
 delete mode 100644 packages/CakePHPToSymfony/src/Contract/FindRepositoryMethodFactoryInterface.php
 create mode 100644 packages/CakePHPToSymfony/src/Contract/NodeManipulator/RepositoryFindMethodCallManipulatorInterface.php
 create mode 100644 packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/AbstractRepositoryFindMethodCallManipulator.php
 create mode 100644 packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/FindAllRepositoryFindMethodCallManipulator.php

diff --git a/packages/CakePHPToSymfony/src/Contract/FindRepositoryMethodFactoryInterface.php b/packages/CakePHPToSymfony/src/Contract/FindRepositoryMethodFactoryInterface.php
deleted file mode 100644
index 7034a975ff4..00000000000
--- a/packages/CakePHPToSymfony/src/Contract/FindRepositoryMethodFactoryInterface.php
+++ /dev/null
@@ -1,9 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Rector\CakePHPToSymfony\Contract;
-
-interface FindRepositoryMethodFactoryInterface
-{
-}
diff --git a/packages/CakePHPToSymfony/src/Contract/NodeManipulator/RepositoryFindMethodCallManipulatorInterface.php b/packages/CakePHPToSymfony/src/Contract/NodeManipulator/RepositoryFindMethodCallManipulatorInterface.php
new file mode 100644
index 00000000000..d0cdd27b6c9
--- /dev/null
+++ b/packages/CakePHPToSymfony/src/Contract/NodeManipulator/RepositoryFindMethodCallManipulatorInterface.php
@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\CakePHPToSymfony\Contract\NodeManipulator;
+
+use PhpParser\Node\Expr\MethodCall;
+
+interface RepositoryFindMethodCallManipulatorInterface
+{
+    public function getKeyName(): string;
+
+    public function processMethodCall(MethodCall $methodCall): MethodCall;
+}
diff --git a/packages/CakePHPToSymfony/src/NodeManipulator/DoctrineRepositoryClassMethodManipulator.php b/packages/CakePHPToSymfony/src/NodeManipulator/DoctrineRepositoryClassMethodManipulator.php
index ab6aac96b17..827085f7bd9 100644
--- a/packages/CakePHPToSymfony/src/NodeManipulator/DoctrineRepositoryClassMethodManipulator.php
+++ b/packages/CakePHPToSymfony/src/NodeManipulator/DoctrineRepositoryClassMethodManipulator.php
@@ -19,6 +19,7 @@ use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\ClassMethod;
+use Rector\CakePHPToSymfony\Contract\NodeManipulator\RepositoryFindMethodCallManipulatorInterface;
 use Rector\Exception\NotImplementedException;
 use Rector\Exception\ShouldNotHappenException;
 use Rector\PhpParser\Node\Resolver\NameResolver;
@@ -42,14 +43,24 @@ final class DoctrineRepositoryClassMethodManipulator
      */
     private $valueResolver;
 
+    /**
+     * @var RepositoryFindMethodCallManipulatorInterface[]
+     */
+    private $repositoryFindMethodCallManipulators = [];
+
+    /**
+     * @param RepositoryFindMethodCallManipulatorInterface[] $repositoryFindMethodCallManipulators
+     */
     public function __construct(
         CallableNodeTraverser $callableNodeTraverser,
         NameResolver $nameResolver,
-        ValueResolver $valueResolver
+        ValueResolver $valueResolver,
+        array $repositoryFindMethodCallManipulators
     ) {
         $this->callableNodeTraverser = $callableNodeTraverser;
         $this->nameResolver = $nameResolver;
         $this->valueResolver = $valueResolver;
+        $this->repositoryFindMethodCallManipulators = $repositoryFindMethodCallManipulators;
     }
 
     public function createFromCakePHPClassMethod(ClassMethod $classMethod, string $entityClass): ClassMethod
@@ -75,9 +86,13 @@ final class DoctrineRepositoryClassMethodManipulator
     private function refactorClassMethodByKind(MethodCall $methodCall, string $entityClass): Node
     {
         $findKind = $this->valueResolver->getValue($methodCall->args[0]->value);
-        if ($findKind === 'all') {
-            $this->refactorFindAll($methodCall);
-            return $methodCall;
+
+        foreach ($this->repositoryFindMethodCallManipulators as $repositoryFindMethodCallManipulator) {
+            if ($findKind !== $repositoryFindMethodCallManipulator->getKeyName()) {
+                continue;
+            }
+
+            return $repositoryFindMethodCallManipulator->processMethodCall($methodCall);
         }
 
         if ($findKind === 'first') {
@@ -176,13 +191,6 @@ final class DoctrineRepositoryClassMethodManipulator
         $methodCall->args = $this->createFindOneByArgs($entityClass, $methodCall);
     }
 
-    private function refactorFindAll(MethodCall $methodCall): void
-    {
-        $this->refactorToRepositoryMethod($methodCall, 'findAll');
-
-        $methodCall->args = [];
-    }
-
     private function refactorToRepositoryMethod(MethodCall $methodCall, string $methodName): void
     {
         $methodCall->var = new PropertyFetch(new Variable('this'), 'repository');
diff --git a/packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/AbstractRepositoryFindMethodCallManipulator.php b/packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/AbstractRepositoryFindMethodCallManipulator.php
new file mode 100644
index 00000000000..cf60ea22b4a
--- /dev/null
+++ b/packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/AbstractRepositoryFindMethodCallManipulator.php
@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\CakePHPToSymfony\NodeManipulator\RepositoryFindClassMethodManipulator;
+
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\PropertyFetch;
+use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\Identifier;
+
+abstract class AbstractRepositoryFindMethodCallManipulator
+{
+    protected function refactorToRepositoryMethod(MethodCall $methodCall, string $methodName): void
+    {
+        $methodCall->var = new PropertyFetch(new Variable('this'), 'repository');
+        $methodCall->name = new Identifier($methodName);
+    }
+}
diff --git a/packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/FindAllRepositoryFindMethodCallManipulator.php b/packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/FindAllRepositoryFindMethodCallManipulator.php
new file mode 100644
index 00000000000..cdfaa409ed6
--- /dev/null
+++ b/packages/CakePHPToSymfony/src/NodeManipulator/RepositoryFindClassMethodManipulator/FindAllRepositoryFindMethodCallManipulator.php
@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\CakePHPToSymfony\NodeManipulator\RepositoryFindClassMethodManipulator;
+
+use PhpParser\Node\Expr\MethodCall;
+use Rector\CakePHPToSymfony\Contract\NodeManipulator\RepositoryFindMethodCallManipulatorInterface;
+
+final class FindAllRepositoryFindMethodCallManipulator extends AbstractRepositoryFindMethodCallManipulator implements RepositoryFindMethodCallManipulatorInterface
+{
+    public function getKeyName(): string
+    {
+        return 'all';
+    }
+
+    public function processMethodCall(MethodCall $methodCall): MethodCall
+    {
+        $this->refactorToRepositoryMethod($methodCall, 'findAll');
+
+        $methodCall->args = [];
+
+        return $methodCall;
+    }
+}