mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-15 13:25:30 +01:00
Code Issues Projects Releases Wiki Activity

Exclude error string from class names (#6279)

Browse Source
This commit is contained in:
Tomas Votruba 2021-05-01 15:24:15 +02:00 committed by GitHub
parent 139c73c5b5
commit 37e07762c5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
rules-tests/TypeDeclaration/Rector/ClassMethod/AddArrayReturnDocTypeRector/Fixture/add_error_string.php.inc Normal file
View File

@ -0,0 +1,26 @@
<?php
final class AddErrorString
{
public function get()
{
return ['error' => 100];
}
}
?>
-----
<?php
final class AddErrorString
{
/**
* @return array<string, int>
*/
public function get()
{
return ['error' => 100];
}
}
?>

5
rules/TypeDeclaration/TypeAnalyzer/GenericClassStringTypeNormalizer.php
View File

@ -30,6 +30,11 @@ final class GenericClassStringTypeNormalizer
return $callback($type); return $callback($type);
} }
// skip string that look like classe
if ($type->getValue() === 'error') {
return $callback($type);
}
if (! $this->reflectionProvider->hasClass($type->getValue())) { if (! $this->reflectionProvider->hasClass($type->getValue())) {
return $callback($type); return $callback($type);
} }