mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-01-17 13:28:18 +01:00
Code Issues Projects Releases Wiki Activity

drop symfony\process for single call (#4735)

Browse Source
This commit is contained in:
Tomas Votruba 2020-11-29 18:47:29 +01:00 committed by GitHub
parent 79f3611dc9
commit 3d721e8ca8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
composer.json
View File

@ -29,7 +29,6 @@
"symfony/dependency-injection": "^4.4.8|^5.1",
"symfony/finder": "^4.4.8|^5.1",
"symfony/http-kernel": "^4.4.8|^5.1",
"symfony/process": "^4.4.8|^5.1",
"symplify/autowire-array-parameter": "dev-master",
"symplify/skipper": "dev-master",
"symplify/composer-json-manipulator": "dev-master",

5
packages/rector-generator/src/Composer/ComposerPackageAutoloadUpdater.php
View File

@ -8,7 +8,6 @@ use Rector\RectorGenerator\FileSystem\JsonFileSystem;
use Rector\RectorGenerator\ValueObject\Package;
use Rector\RectorGenerator\ValueObject\RectorRecipe;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\Process\Process;
final class ComposerPackageAutoloadUpdater
{
@ -110,7 +109,7 @@ final class ComposerPackageAutoloadUpdater
private function rebuildAutoload(): void
{
$composerDumpProcess = new Process(['composer', 'dump']);
$composerDumpProcess->run();
// note: do not use shell_exec, this is only effective solution for better DX
shell_exec('composer dump');
}
}

3
rules/symfony/src/Rector/StaticCall/ProcessBuilderInstanceRector.php
View File

@ -9,7 +9,6 @@ use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Name;
use Rector\Core\Rector\AbstractRector;
use Symfony\Component\Process\ProcessBuilder;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@ -48,7 +47,7 @@ final class ProcessBuilderInstanceRector extends AbstractRector
return null;
}
if (! $this->isName($node->class, ProcessBuilder::class)) {
if (! $this->isName($node->class, 'Symfony\Component\Process\ProcessBuilder')) {
return null;
}