Merge pull request #975 from rectorphp/remove-interface-rector

Added new rector - RemoveInterfacesRector

src/Rector/Interface_/MergeInterfacesRector.php

@@ -71,11 +71,12 @@ CODE_SAMPLE
         }
 
         foreach ($node->implements as $key => $implement) {
-            $interface = (string) $implement->getAttribute(Attribute::RESOLVED_NAME);
-
-            if (array_key_exists($interface, $this->oldToNewInterfaces)) {
-                $node->implements[$key] = new Name($this->oldToNewInterfaces[$interface]);
+            if (! $this->isNames($implement, array_keys($this->oldToNewInterfaces))) {
+                continue;
             }
+
+            $interface = $this->getName($implement);
+            $node->implements[$key] = new Name($this->oldToNewInterfaces[$interface]);
         }
 
         $this->makeImplementsUnique($node);

src/Rector/Interface_/RemoveInterfacesRector.php

@@ -0,0 +1,74 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Rector\Interface_;
+
+use PhpParser\Node;
+use PhpParser\Node\Stmt\Class_;
+use Rector\Rector\AbstractRector;
+use Rector\RectorDefinition\ConfiguredCodeSample;
+use Rector\RectorDefinition\RectorDefinition;
+
+final class RemoveInterfacesRector extends AbstractRector
+{
+    /**
+     * @var string[]
+     */
+    private $interfacesToRemove = [];
+
+    /**
+     * @param string[] $interfacesToRemove
+     */
+    public function __construct(array $interfacesToRemove)
+    {
+        $this->interfacesToRemove = $interfacesToRemove;
+    }
+
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition('Removes interfaces usage from class.', [
+            new ConfiguredCodeSample(
+                <<<'CODE_SAMPLE'
+class SomeClass implements SomeInterface
+{
+}
+CODE_SAMPLE
+                ,
+                <<<'CODE_SAMPLE'
+class SomeClass
+{
+}
+CODE_SAMPLE
+                ,
+                ['SomeInterface']
+            ),
+        ]);
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getNodeTypes(): array
+    {
+        return [Class_::class];
+    }
+
+    /**
+     * @param Class_ $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $node->implements) {
+            return null;
+        }
+
+        foreach ($node->implements as $key => $implement) {
+            if ($this->isNames($implement, $this->interfacesToRemove)) {
+                unset($node->implements[$key]);
+            }
+        }
+
+        $node->implements = array_values($node->implements);
+
+        return $node;
+    }
+}

tests/Rector/Interface_/RemoveInterfacesRector/Fixture/fixture.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Fixture;
+
+use Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source\SomeInterface;
+use Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source\AnotherInterface;
+
+class SomeClass implements SomeInterface, AnotherInterface
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Fixture;
+
+use Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source\SomeInterface;
+use Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source\AnotherInterface;
+
+class SomeClass implements AnotherInterface
+{
+}
+
+?>

tests/Rector/Interface_/RemoveInterfacesRector/Fixture/fixture2.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Fixture;
+
+use Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source\SomeInterface;
+
+class SomeClass2 implements SomeInterface
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Fixture;
+
+use Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source\SomeInterface;
+
+class SomeClass2
+{
+}
+
+?>

tests/Rector/Interface_/RemoveInterfacesRector/RemoveInterfacesRectorTest.php

@@ -0,0 +1,28 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Tests\Rector\Interface_\RemoveInterfacesRector;
+
+use Rector\Rector\Interface_\RemoveInterfacesRector;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source\SomeInterface;
+
+final class RemoveInterfacesRectorTest extends AbstractRectorTestCase
+{
+    public function test(): void
+    {
+        $this->doTestFiles([__DIR__ . '/Fixture/fixture.php.inc', __DIR__ . '/Fixture/fixture2.php.inc']);
+    }
+
+    protected function getRectorClass(): string
+    {
+        return RemoveInterfacesRector::class;
+    }
+
+    /**
+     * @return mixed[]
+     */
+    protected function getRectorConfiguration(): array
+    {
+        return [SomeInterface::class];
+    }
+}

tests/Rector/Interface_/RemoveInterfacesRector/Source/AnotherInterface.php

@@ -0,0 +1,7 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source;
+
+interface AnotherInterface
+{
+}

tests/Rector/Interface_/RemoveInterfacesRector/Source/SomeInterface.php

@@ -0,0 +1,7 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Tests\Rector\Interface_\RemoveInterfacesRector\Source;
+
+interface SomeInterface
+{
+}