From 90d483ad34b2799a8dec14678d959b4788b3e438 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Thu, 29 Aug 2019 22:35:22 +0200
Subject: [PATCH] [DeadCode] Add RemoveAlwaysTrueIfConditionRector

---
 .../If_/RemoveAlwaysTrueIfConditionRector.php | 85 +++++++++++++++++++
 .../Fixture/fixture.php.inc                   | 33 +++++++
 .../RemoveAlwaysTrueIfConditionRectorTest.php | 19 +++++
 3 files changed, 137 insertions(+)
 create mode 100644 packages/DeadCode/src/Rector/If_/RemoveAlwaysTrueIfConditionRector.php
 create mode 100644 packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/Fixture/fixture.php.inc
 create mode 100644 packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/RemoveAlwaysTrueIfConditionRectorTest.php

diff --git a/packages/DeadCode/src/Rector/If_/RemoveAlwaysTrueIfConditionRector.php b/packages/DeadCode/src/Rector/If_/RemoveAlwaysTrueIfConditionRector.php
new file mode 100644
index 00000000000..f0834d5a51f
--- /dev/null
+++ b/packages/DeadCode/src/Rector/If_/RemoveAlwaysTrueIfConditionRector.php
@@ -0,0 +1,85 @@
+<?php declare(strict_types=1);
+
+namespace Rector\DeadCode\Rector\If_;
+
+use PhpParser\Node;
+use PhpParser\Node\Stmt\If_;
+use PHPStan\Type\Constant\ConstantBooleanType;
+use Rector\Rector\AbstractRector;
+use Rector\RectorDefinition\CodeSample;
+use Rector\RectorDefinition\RectorDefinition;
+
+final class RemoveAlwaysTrueIfConditionRector extends AbstractRector
+{
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition('Remove if condition that is always true', [
+            new CodeSample(
+                <<<'CODE_SAMPLE'
+final class SomeClass
+{
+    public function go()
+    {
+        if (1 === 1) {
+            return 'yes';
+        }
+        
+        return 'no';
+    }
+}
+CODE_SAMPLE
+                ,
+                <<<'CODE_SAMPLE'
+final class SomeClass
+{
+    public function go()
+    {
+        return 'yes';
+        
+        return 'no';
+    }
+}
+CODE_SAMPLE
+            ),
+        ]);
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getNodeTypes(): array
+    {
+        return [If_::class];
+    }
+
+    /**
+     * @param If_ $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if ($node->else !== null) {
+            return null;
+        }
+
+        // just one if
+        if (count($node->elseifs) !== 0) {
+            return null;
+        }
+
+        $conditionStaticType = $this->getStaticType($node->cond);
+        if (! $conditionStaticType instanceof ConstantBooleanType) {
+            return null;
+        }
+
+        if ($conditionStaticType->getValue() !== true) {
+            return null;
+        }
+
+        if (count($node->stmts) !== 1) {
+            // unable to handle now
+            return null;
+        }
+
+        return $node->stmts[0];
+    }
+}
diff --git a/packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/Fixture/fixture.php.inc b/packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/Fixture/fixture.php.inc
new file mode 100644
index 00000000000..1964dad05b4
--- /dev/null
+++ b/packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/Fixture/fixture.php.inc
@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\DeadCode\Tests\Rector\If_\RemoveAlwaysTrueIfConditionRector\Fixture;
+
+class RemoveIf
+{
+    public function run()
+    {
+        if (true === true) {
+            return 'hi';
+        }
+
+        return 'hello';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\DeadCode\Tests\Rector\If_\RemoveAlwaysTrueIfConditionRector\Fixture;
+
+class RemoveIf
+{
+    public function run()
+    {
+        return 'hi';
+
+        return 'hello';
+    }
+}
+
+?>
diff --git a/packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/RemoveAlwaysTrueIfConditionRectorTest.php b/packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/RemoveAlwaysTrueIfConditionRectorTest.php
new file mode 100644
index 00000000000..12ba85650c9
--- /dev/null
+++ b/packages/DeadCode/tests/Rector/If_/RemoveAlwaysTrueIfConditionRector/RemoveAlwaysTrueIfConditionRectorTest.php
@@ -0,0 +1,19 @@
+<?php declare(strict_types=1);
+
+namespace Rector\DeadCode\Tests\Rector\If_\RemoveAlwaysTrueIfConditionRector;
+
+use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveAlwaysTrueIfConditionRectorTest extends AbstractRectorTestCase
+{
+    public function test(): void
+    {
+        $this->doTestFiles([__DIR__ . '/Fixture/fixture.php.inc']);
+    }
+
+    protected function getRectorClass(): string
+    {
+        return RemoveAlwaysTrueIfConditionRector::class;
+    }
+}