mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-01-20 06:38:46 +01:00
Code Issues Projects Releases Wiki Activity

[TryCatch] Try/Catch with filled Finally can not be dead (#4053)

Browse Source
This commit is contained in:
Dmytro Naumenko 2020-08-29 00:08:45 +03:00 committed by GitHub
parent 12691991bb
commit 41d5f5567f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rules/dead-code/src/Rector/TryCatch/RemoveDeadTryCatchRector.php
View File

@ -72,6 +72,10 @@ PHP
return null;
}
if ($node->finally !== null && count($node->finally->stmts) > 0) {
return null;
}
$onlyCatchStmt = $onlyCatch->stmts[0];
if (! $onlyCatchStmt instanceof Throw_) {
return null;

33
rules/dead-code/tests/Rector/TryCatch/RemoveDeadTryCatchRector/Fixture/drop_with_empty_finally.php.inc Normal file
View File

@ -0,0 +1,33 @@
<?php
namespace Rector\DeadCode\Tests\Rector\TryCatch\RemoveDeadTryCatchRector\Fixture;
class DropWithEmptyFinally
{
public function run()
{
try {
// some code
} catch (\Throwable $throwable) {
throw $throwable;
} finally {
}
}
}
?>
-----
<?php
namespace Rector\DeadCode\Tests\Rector\TryCatch\RemoveDeadTryCatchRector\Fixture;
class DropWithEmptyFinally
{
public function run()
{
// some code
}
}
?>

22
rules/dead-code/tests/Rector/TryCatch/RemoveDeadTryCatchRector/Fixture/skip_with_finally.php.inc Normal file
View File

@ -0,0 +1,22 @@
<?php
namespace Rector\DeadCode\Tests\Rector\TryCatch\RemoveDeadTryCatchRector\Fixture;
class SkipWithFinally
{
public function run()
{
try {
// some code
} catch (\Throwable $throwable) {
throw $throwable;
} finally {
$this->resetState();
}
}
private function resetState()
{
}
}