mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 11:44:14 +01:00
Code Issues Projects Releases Wiki Activity

[DeprecationExtractor] decouple RectorGuessFilter

Browse Source
This commit is contained in:
TomasVotruba 2017-10-14 17:06:47 +02:00
parent 105243f85c
commit 4f8a6f26c4
2 changed files with 66 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
packages/DeprecationExtractor/src/Console/Command/ExtractDeprecationsCommand.php
View File

@ -6,6 +6,7 @@ use Rector\DeprecationExtractor\Deprecation\DeprecationCollector;
use Rector\DeprecationExtractor\DeprecationExtractor;
use Rector\DeprecationExtractor\Rector\RectorGuesser;
use Rector\DeprecationExtractor\RectorGuess\RectorGuess;
use Rector\DeprecationExtractor\RectorGuess\RectorGuessFilter;
use Rector\Naming\CommandNaming;
use Rector\Node\Attribute;
use Symfony\Component\Console\Command\Command;
@ -46,16 +47,23 @@ final class ExtractDeprecationsCommand extends Command
*/
private $rectorGuesser;
/**
* @var RectorGuessFilter
*/
private $rectorGuessFilter;
public function __construct(
DeprecationExtractor $deprecationExtractor,
DeprecationCollector $deprecationCollector,
RectorGuesser $rectorGuesser,
SymfonyStyle $symfonyStyle
SymfonyStyle $symfonyStyle,
RectorGuessFilter $rectorGuessFilter
) {
$this->deprecationExtractor = $deprecationExtractor;
$this->deprecationCollector = $deprecationCollector;
$this->rectorGuesser = $rectorGuesser;
$this->symfonyStyle = $symfonyStyle;
$this->rectorGuessFilter = $rectorGuessFilter;
parent::__construct();
}
@ -78,8 +86,7 @@ final class ExtractDeprecationsCommand extends Command
);
$guessedRectors = $this->rectorGuesser->guessForDeprecations($this->deprecationCollector->getDeprecations());
$guessedRectors = $this->filterOutUsefulGuessedRectors($guessedRectors);
$guessedRectors = $this->filterOutDuplicatedGuessedRectors($guessedRectors);
$guessedRectors = $this->rectorGuessFilter->filterRectorGuessesToShow($guessedRectors);
$this->symfonyStyle->title(sprintf(
'Found %d useful deprecations',
@ -87,52 +94,12 @@ final class ExtractDeprecationsCommand extends Command
));
foreach ($guessedRectors as $guessedRector) {
// filter out duplicated deprecations, trigger_error + @deprecated annotation
// $this->renderGuessedRector($guessedRector);
$this->renderGuessedRector($guessedRector);
}
return 0;
}
/**
* @param RectorGuess[] $guessedRectors
* @return RectorGuess[]
*/
private function filterOutUsefulGuessedRectors(array $guessedRectors): array
{
return array_filter($guessedRectors, function (RectorGuess $rectorGuess) {
return $rectorGuess->isUseful();
});
}
/**
* @param RectorGuess[] $guessedRectors
* @return RectorGuess[]
*/
private function filterOutDuplicatedGuessedRectors(array $guessedRectors): array
{
$allMessages = [];
foreach ($guessedRectors as $rectorGuess) {
$allMessages[] = $rectorGuess->getMessage();
}
$filteredGuessedRectors = [];
foreach ($guessedRectors as $rectorGuess) {
foreach ($allMessages as $message) {
// experimental; maybe count from message length?
$levenshtein = levenshtein($rectorGuess->getMessage(), $message);
if ($levenshtein !== 0 && $levenshtein < 10) {
continue 2;
}
}
$filteredGuessedRectors[] = $rectorGuess;
}
return $filteredGuessedRectors;
}
private function renderGuessedRector(RectorGuess $guessedRector): void
{
$this->symfonyStyle->success($guessedRector->getGuessedRectorClass());

55
packages/DeprecationExtractor/src/RectorGuess/RectorGuessFilter.php Normal file
View File

@ -0,0 +1,55 @@
<?php declare(strict_types=1);
namespace Rector\DeprecationExtractor\RectorGuess;
final class RectorGuessFilter
{
/**
* @param RectorGuess[] $rectorGuesses
* @return RectorGuess[]
*/
public function filterRectorGuessesToShow(array $rectorGuesses): array
{
$rectorGuesses = $this->filterOutUsefulGuessedRectors($rectorGuesses);
return $this->filterOutDuplicatedGuessedRectors($rectorGuesses);
}
/**
* @param RectorGuess[] $rectorGuesses
* @return RectorGuess[]
*/
private function filterOutUsefulGuessedRectors(array $rectorGuesses): array
{
return array_filter($rectorGuesses, function (RectorGuess $rectorGuess) {
return $rectorGuess->isUseful();
});
}
/**
* @param RectorGuess[] $rectorGuesses
* @return RectorGuess[]
*/
private function filterOutDuplicatedGuessedRectors(array $rectorGuesses): array
{
$allMessages = [];
foreach ($rectorGuesses as $rectorGuess) {
$allMessages[] = $rectorGuess->getMessage();
}
$filteredGuessedRectors = [];
foreach ($rectorGuesses as $rectorGuess) {
foreach ($allMessages as $message) {
// experimental; maybe count from message length?
$levenshtein = levenshtein($rectorGuess->getMessage(), $message);
if ($levenshtein !== 0 && $levenshtein < 10) {
continue 2;
}
}
$filteredGuessedRectors[] = $rectorGuess;
}
return $filteredGuessedRectors;
}
}