mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 19:53:14 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2885 from rectorphp/fix-const

Browse Source 
Fix already constant
This commit is contained in:
Tomas Votruba 2020-02-19 14:41:54 +01:00 committed by GitHub
commit 5a3b0adff2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
composer.json
View File

@ -259,7 +259,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "0.6-dev"
"dev-master": "0.8-dev"
}
}
}

7
rules/solid/src/Rector/ClassMethod/ChangeReadOnlyVariableWithDefaultValueToConstantRector.php
View File

@ -216,8 +216,13 @@ PHP
foreach ($readOnlyVariableAssigns as $readOnlyVariableAssign) {
$this->removeNode($readOnlyVariableAssign);
/** @var Variable $variable */
/** @var Variable|ClassConstFetch $variable */
$variable = $readOnlyVariableAssign->var;
// already overriden
if (! $variable instanceof Variable) {
continue;
}
$classConst = $this->createClassConst($variable, $readOnlyVariableAssign->expr);
// replace $variable usage in the code with constant