mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 11:44:14 +01:00
Code Issues Projects Releases Wiki Activity

Skip variadic arguments from property promotion (#5046)

Browse Source
This commit is contained in:
Grzegorz Korba 2020-12-30 20:31:55 +01:00 committed by GitHub
parent bf9e31b515
commit 7a82928e08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rules/php80/src/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php
View File

@ -96,12 +96,16 @@ CODE_SAMPLE
foreach ($promotionCandidates as $promotionCandidate) { foreach ($promotionCandidates as $promotionCandidate) {
// does property have some useful annotations? // does property have some useful annotations?
$property = $promotionCandidate->getProperty(); $property = $promotionCandidate->getProperty();
$param = $promotionCandidate->getParam();
if ($param->variadic) {
continue;
}
$this->removeNode($property); $this->removeNode($property);
$this->removeNode($promotionCandidate->getAssign()); $this->removeNode($promotionCandidate->getAssign());
$property = $promotionCandidate->getProperty(); $property = $promotionCandidate->getProperty();
$param = $promotionCandidate->getParam();
$this->decorateParamWithPropertyPhpDocInfo($property, $param); $this->decorateParamWithPropertyPhpDocInfo($property, $param);

14
rules/php80/tests/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector/Fixture/skip_variadic_arguments.php.inc Normal file
View File

@ -0,0 +1,14 @@
<?php
namespace Rector\Php80\Tests\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector\Fixture;
class SkipVariadicArguments
{
/** @var string[] */
private array $bars;
public function __construct(string ...$bars)
{
$this->bars = $bars;
}
}