Merge pull request #2099 from gnutix/ImportFullyQualifiedNamesRector/code-sample

Add documentation for ImportFullyQualifiedNamesRector new argument
This commit is contained in:
Tomáš Votruba 2019-10-04 17:16:17 +02:00 committed by GitHub
commit 7b55a5343a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 126 additions and 5 deletions

View File

@ -1,4 +1,4 @@
# All 367 Rectors Overview # All 369 Rectors Overview
- [Projects](#projects) - [Projects](#projects)
- [General](#general) - [General](#general)
@ -1235,6 +1235,7 @@ Import fully qualified names to use statements
```diff ```diff
+use SomeAnother\AnotherClass; +use SomeAnother\AnotherClass;
+use DateTime;
+ +
class SomeClass class SomeClass
{ {
@ -1243,6 +1244,38 @@ Import fully qualified names to use statements
- return SomeAnother\AnotherClass; - return SomeAnother\AnotherClass;
+ return AnotherClass; + return AnotherClass;
} }
public function createDate()
{
- return new \DateTime();
+ return new DateTime();
}
}
```
```yaml
services:
Rector\CodingStyle\Rector\Namespace_\ImportFullyQualifiedNamesRector:
$shouldImportRootNamespaceClasses: false
```
```diff
+use SomeAnother\AnotherClass;
+
class SomeClass
{
public function create()
{
- return SomeAnother\AnotherClass;
+ return AnotherClass;
}
public function createDate()
{
return new \DateTime(); // this remains untouched
}
} }
``` ```
@ -1369,7 +1402,7 @@ services:
- class: `Rector\CodingStyle\Rector\Use_\RemoveUnusedAliasRector` - class: `Rector\CodingStyle\Rector\Use_\RemoveUnusedAliasRector`
Removes unused use aliases Removes unused use aliases. Keep annotation aliases like "Doctrine\ORM\Mapping as ORM" to keep convention format
```diff ```diff
-use Symfony\Kernel as BaseKernel; -use Symfony\Kernel as BaseKernel;
@ -1532,6 +1565,25 @@ Prefer quote that not inside the string
<br> <br>
### `UseIncrementAssignRector`
- class: `Rector\CodingStyle\Rector\Assign\UseIncrementAssignRector`
Use ++ increment instead of $var += 1.
```diff
class SomeClass
{
public function run()
{
- $style += 1;
+ ++$style
}
}
```
<br>
### `VarConstantCommentRector` ### `VarConstantCommentRector`
- class: `Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector` - class: `Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector`
@ -1983,6 +2035,26 @@ Removes method that set values that are never used
<br> <br>
### `RemoveUnreachableStatementRector`
- class: `Rector\DeadCode\Rector\Stmt\RemoveUnreachableStatementRector`
Remove unreachable statements
```diff
class SomeClass
{
public function run()
{
return 5;
-
- $removeMe = 10;
}
}
```
<br>
### `RemoveUnusedDoctrineEntityMethodAndPropertyRector` ### `RemoveUnusedDoctrineEntityMethodAndPropertyRector`
- class: `Rector\DeadCode\Rector\Class_\RemoveUnusedDoctrineEntityMethodAndPropertyRector` - class: `Rector\DeadCode\Rector\Class_\RemoveUnusedDoctrineEntityMethodAndPropertyRector`
@ -3869,7 +3941,7 @@ Remove 0 from break and continue
- class: `Rector\Php55\Rector\FuncCall\PregReplaceEModifierRector` - class: `Rector\Php55\Rector\FuncCall\PregReplaceEModifierRector`
The /e modifier is no longer supported, use preg_replace_callback instead The /e modifier is no longer supported, use preg_replace_callback instead
```diff ```diff
class SomeClass class SomeClass

View File

@ -917,7 +917,7 @@ if (true) {
```php ```php
?> ?>
<strong>feel</strong><?php <strong>feel</strong><?php
``` ```
<br> <br>

View File

@ -7,6 +7,7 @@ use PhpParser\Node\Name;
use Rector\CodingStyle\Node\NameImporter; use Rector\CodingStyle\Node\NameImporter;
use Rector\Rector\AbstractRector; use Rector\Rector\AbstractRector;
use Rector\RectorDefinition\CodeSample; use Rector\RectorDefinition\CodeSample;
use Rector\RectorDefinition\ConfiguredCodeSample;
use Rector\RectorDefinition\RectorDefinition; use Rector\RectorDefinition\RectorDefinition;
/** /**
@ -50,6 +51,45 @@ class SomeClass
{ {
return SomeAnother\AnotherClass; return SomeAnother\AnotherClass;
} }
public function createDate()
{
return new \DateTime();
}
}
PHP
,
<<<'PHP'
use SomeAnother\AnotherClass;
use DateTime;
class SomeClass
{
public function create()
{
return AnotherClass;
}
public function createDate()
{
return new DateTime();
}
}
PHP
),
new ConfiguredCodeSample(
<<<'PHP'
class SomeClass
{
public function create()
{
return SomeAnother\AnotherClass;
}
public function createDate()
{
return new \DateTime(); // this remains untouched
}
} }
PHP PHP
, ,
@ -60,10 +100,19 @@ class SomeClass
{ {
public function create() public function create()
{ {
return AnotherClass; return AnotherClass;
}
public function createDate()
{
return new \DateTime(); // this remains untouched
} }
} }
PHP PHP
,
[
'$shouldImportRootNamespaceClasses' => false,
]
), ),
]); ]);
} }