diff --git a/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_param_doc.php.inc b/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_param_doc.php.inc index ec37b4b8f92..711bdeb20a6 100644 --- a/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_param_doc.php.inc +++ b/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_param_doc.php.inc @@ -5,10 +5,10 @@ namespace Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRe class ImportParamDoc { /** - * @param \Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\AlreadyClassName $alreadyClassName - * @return \Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\AlreadyClassName + * @param \Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\NormalParamClass $alreadyClassName + * @return \Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\NormalParamClass */ - public function create(\Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\AlreadyClassName $alreadyClassName) + public function create(\Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\NormalParamClass $alreadyClassName) { } } @@ -19,14 +19,14 @@ class ImportParamDoc namespace Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Fixture; -use Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\AlreadyClassName; +use Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\NormalParamClass; class ImportParamDoc { /** - * @param AlreadyClassName $alreadyClassName - * @return AlreadyClassName + * @param NormalParamClass $alreadyClassName + * @return NormalParamClass */ - public function create(AlreadyClassName $alreadyClassName) + public function create(NormalParamClass $alreadyClassName) { } } diff --git a/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_return_doc.php.inc b/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_return_doc.php.inc index eeb43be0e48..138b8b98385 100644 --- a/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_return_doc.php.inc +++ b/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/import_return_doc.php.inc @@ -7,7 +7,7 @@ use Rector\CodingStyle\Tests\Rector\Namespace_; class ImportReturnDoc { /** - * @return Namespace_\ImportFullyQualifiedNamesRector\Source\AlreadyClassName + * @return Namespace_\ImportFullyQualifiedNamesRector\Source\NormalReturnClass */ public function create() { @@ -20,13 +20,13 @@ class ImportReturnDoc namespace Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Fixture; -use Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\AlreadyClassName; +use Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\Source\NormalReturnClass; use Rector\CodingStyle\Tests\Rector\Namespace_; class ImportReturnDoc { /** - * @return AlreadyClassName + * @return NormalReturnClass */ public function create() { diff --git a/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Source/NormalParamClass.php b/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Source/NormalParamClass.php new file mode 100644 index 00000000000..2a444d75e8b --- /dev/null +++ b/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Source/NormalParamClass.php @@ -0,0 +1,8 @@ +getAttribute(AttributeKey::NAMESPACE_NAME); + + // the class in the same namespace as differnt file can se used in this code, the short names would colide → skip + if (class_exists($namespaceName . '\\' . $shortName)) { + return $attributeAwareNode; + } + if ($this->useAddingCommander->isShortImported($node, $fullyQualifiedName)) { if ($this->useAddingCommander->isImportShortable($node, $fullyQualifiedName)) { $attributeAwareNode->name = $shortName;