mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-22 10:43:35 +01:00
Code Issues Projects Releases Wiki Activity

make SimplifyIfElseToTernaryRector limit to 120 chars to prevent complicated code

Browse Source
This commit is contained in:
Tomas Votruba 2019-04-01 13:04:50 +02:00
parent 3fafc49ea0
commit 8574f286b6
3 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/CodeQuality/src/Rector/If_/SimplifyIfElseToTernaryRector.php
View File

@ -2,6 +2,7 @@
namespace Rector\CodeQuality\Rector\If_;
use Nette\Utils\Strings;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
@ -15,6 +16,11 @@ use Rector\RectorDefinition\RectorDefinition;
final class SimplifyIfElseToTernaryRector extends AbstractRector
{
/**
* @var int
*/
private const LINE_LENGHT_LIMIT = 120;
public function getDefinition(): RectorDefinition
{
return new RectorDefinition('Changes if/else for same value as assign to ternary', [
@ -84,9 +90,15 @@ CODE_SAMPLE
return null;
}
$ternaryNode = new Ternary($node->cond, $ternaryIf, $ternaryElse);
$ternary = new Ternary($node->cond, $ternaryIf, $ternaryElse);
$assign = new Assign($ifAssignVar, $ternary);
return new Assign($ifAssignVar, $ternaryNode);
// do not create super long lines
if (Strings::length($this->print($assign)) > self::LINE_LENGHT_LIMIT) {
return null;
}
return $assign;
}
/**

18
packages/CodeQuality/tests/Rector/If_/SimplifyIfElseToTernaryRector/Fixture/too_long.php.inc Normal file
View File

@ -0,0 +1,18 @@
<?php
namespace Rector\CodeQuality\Tests\Rector\If_\SimplifyIfElseToTernaryRector\Fixture;
class TooLong
{
public function run()
{
if ($this->nodeTypeResolver->isStringyType($staticCall->args[1]->value)) {
$name = $this->nameResolver->isName(
$staticCall,
'contains'
) ? 'assertStringContainsString' : 'assertStringNotContainsString';
} else {
$name = $this->nameResolver->isName($staticCall, 'contains') ? 'assertContains' : 'assertNotContains';
}
}
}

6
packages/CodeQuality/tests/Rector/If_/SimplifyIfElseToTernaryRector/SimplifyIfElseToTernaryRectorTest.php
View File

@ -9,7 +9,11 @@ final class SimplifyIfElseToTernaryRectorTest extends AbstractRectorTestCase
{
public function test(): void
{
$this->doTestFiles([__DIR__ . '/Fixture/fixture.php.inc', __DIR__ . '/Fixture/keep.php.inc']);
$this->doTestFiles([
__DIR__ . '/Fixture/fixture.php.inc',
__DIR__ . '/Fixture/keep.php.inc',
__DIR__ . '/Fixture/too_long.php.inc',
]);
}
protected function getRectorClass(): string