mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-03-24 09:19:47 +01:00
Code Issues Projects Releases Wiki Activity

skip abstract parent methods in RemoveUnusedDoctrineEntityMetho… (#1821)

Browse Source 
skip abstract parent methods in RemoveUnusedDoctrineEntityMethodAndPr…
This commit is contained in:
Tomáš Votruba 2019-08-06 18:14:47 +02:00 committed by GitHub
commit 87facf1764
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 67 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
packages/DeadCode/src/UnusedNodeResolver/ClassUnusedPrivateClassMethodResolver.php
View File

@ -7,6 +7,7 @@ use PhpParser\Node\Stmt\Class_;
use Rector\NodeContainer\ParsedNodesByType;
use Rector\PhpParser\Node\Manipulator\ClassManipulator;
use Rector\PhpParser\Node\Resolver\NameResolver;
use ReflectionMethod;
final class ClassUnusedPrivateClassMethodResolver
{
@ -61,7 +62,9 @@ final class ClassUnusedPrivateClassMethodResolver
$unusedMethods = $this->filterOutSystemMethods($unusedMethods);
return $this->filterOutInterfaceRequiredMethods($class, $unusedMethods);
$unusedMethods = $this->filterOutInterfaceRequiredMethods($class, $unusedMethods);
return $this->filterOutParentAbstractMethods($class, $unusedMethods);
}
/**
@ -103,4 +106,43 @@ final class ClassUnusedPrivateClassMethodResolver
return array_diff($unusedMethods, $interfaceMethods);
}
/**
* @param string[] $unusedMethods
* @return string[]
*/
private function filterOutParentAbstractMethods(Class_ $class, array $unusedMethods): array
{
if ($class->extends === null) {
return $unusedMethods;
}
$parentClasses = class_parents($class);
$parentAbstractMethods = [];
foreach ($parentClasses as $parentClass) {
foreach ($unusedMethods as $unusedMethod) {
if (in_array($unusedMethod, $parentAbstractMethods, true)) {
continue;
}
if ($this->isMethodAbstract($parentClass, $unusedMethod)) {
$parentAbstractMethods[] = $unusedMethod;
}
}
}
return array_diff($unusedMethods, $parentAbstractMethods);
}
private function isMethodAbstract(string $class, string $method): bool
{
if (! method_exists($class, $method)) {
return false;
}
$methodReflection = new ReflectionMethod($class, $method);
return $methodReflection->isAbstract();
}
}

23
packages/DeadCode/tests/Rector/Class_/RemoveUnusedDoctrineEntityMethodAndPropertyRector/Fixture/skip_abstract_parent.php.inc Normal file
View File

@ -0,0 +1,23 @@
<?php
namespace Rector\DeadCode\Tests\Rector\Class_\RemoveUnusedDoctrineEntityMethodAndPropertyRector\Fixture;
use Doctrine\ORM\Mapping as ORM;
/**
* @ORM\Entity()
*/
class Product extends Service
{
public const TYPE = 'product';
public function getType(): string
{
return self::TYPE;
}
}
abstract class Service
{
public abstract function getType();
}

1
packages/DeadCode/tests/Rector/Class_/RemoveUnusedDoctrineEntityMethodAndPropertyRector/RemoveUnusedDoctrineEntityMethodAndPropertyRectorTest.php
View File

@ -19,6 +19,7 @@ final class RemoveUnusedDoctrineEntityMethodAndPropertyRectorTest extends Abstra
__DIR__ . '/Fixture/skip_trait_called_method.php.inc',
__DIR__ . '/Fixture/skip_trait_doc_typed.php.inc',
__DIR__ . '/Fixture/skip_trait_complex.php.inc',
__DIR__ . '/Fixture/skip_abstract_parent.php.inc',
]);
}