mirror of
https://github.com/rectorphp/rector.git
synced 2025-02-21 09:42:45 +01:00
[DeadCode] Skip RemoveEmptyClassMethodRector on final method in non-final class (#4943)
This commit is contained in:
parent
a3db386854
commit
8a39d6edbd
@ -88,6 +88,10 @@ CODE_SAMPLE
|
||||
return null;
|
||||
}
|
||||
|
||||
if ($node->isFinal() && ! $classLike->isFinal()) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if ($this->shouldSkipNonFinalNonPrivateClassMethod($classLike, $node)) {
|
||||
return null;
|
||||
}
|
||||
|
@ -0,0 +1,22 @@
|
||||
<?php
|
||||
|
||||
namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveEmptyClassMethodRector\Fixture;
|
||||
|
||||
final class FinalInFinalClass
|
||||
{
|
||||
final public function __construct()
|
||||
{
|
||||
}
|
||||
}
|
||||
|
||||
?>
|
||||
-----
|
||||
<?php
|
||||
|
||||
namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveEmptyClassMethodRector\Fixture;
|
||||
|
||||
final class FinalInFinalClass
|
||||
{
|
||||
}
|
||||
|
||||
?>
|
@ -0,0 +1,10 @@
|
||||
<?php
|
||||
|
||||
namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveEmptyClassMethodRector\Fixture;
|
||||
|
||||
abstract class KeepFinalInNonFinalClass
|
||||
{
|
||||
final public function __construct()
|
||||
{
|
||||
}
|
||||
}
|
Loading…
x
Reference in New Issue
Block a user