mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-03-18 06:19:50 +01:00
Code Issues Projects Releases Wiki Activity

[MagicDisclosure] Skip getters (#3856)

Browse Source
This commit is contained in:
Tomas Votruba 2020-08-01 02:01:52 +02:00 committed by GitHub
parent 20e28ea763
commit 8b42e67744
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
rules/magic-disclosure/src/Rector/MethodCall/DefluentMethodCallRector.php
View File

@ -94,7 +94,12 @@ PHP
return null;
}
if ($this->isGetterMethodCall($methodCall)) {
return null;
}
$chainMethodCalls = $this->chainMethodCallNodeAnalyzer->collectAllMethodCallsInChain($methodCall);
$assignAndRootExpr = $this->chainMethodCallRootExtractor->extractFromMethodCalls($chainMethodCalls);
if ($assignAndRootExpr === null) {
return null;
@ -222,4 +227,16 @@ PHP
return $nodesToAdd;
}
private function isGetterMethodCall(MethodCall $methodCall): bool
{
if ($methodCall->var instanceof MethodCall) {
return false;
}
$methodCallStaticType = $this->getStaticType($methodCall);
$methodCallVarStaticType = $this->getStaticType($methodCall->var);
// getter short call type
return ! $methodCallStaticType->equals($methodCallVarStaticType);
}
}

13
rules/magic-disclosure/tests/Rector/MethodCall/DefluentMethodCallRector/Fixture/skip_getter_on_new.php.inc Normal file
View File

@ -0,0 +1,13 @@
<?php
namespace Rector\MagicDisclosure\Tests\Rector\MethodCall\DefluentMethodCallRector\Fixture;
use Rector\MagicDisclosure\Tests\Rector\MethodCall\DefluentMethodCallRector\Source\DifferentReturnValues;
class SkipGetterOnNew
{
public function run()
{
$differentReturnValues = (new DifferentReturnValues())->otherFunction();
}
}