mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-01-17 21:38:22 +01:00
Code Issues Projects Releases Wiki Activity

Fixes #3930 : TypedPropertyRector should not remove DocBlock comment when it specifies the values contained in an array (#4102)

Browse Source
This commit is contained in:
Abdul Malik Ikhsan 2020-09-02 19:01:45 +07:00 committed by GitHub
parent 108c6fd52f
commit 9465173276
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@ -21,3 +21,4 @@ rector-recipe.php
# testing
abz
/rector-temp-phpstan*.neon

10
rules/php74/src/Rector/Property/TypedPropertyRector.php
View File

@ -16,6 +16,8 @@ use PHPStan\Type\MixedType;
use PHPStan\Type\NullType;
use PHPStan\Type\Type;
use PHPStan\Type\UnionType;
use Rector\AttributeAwarePhpDoc\Ast\Type\AttributeAwareArrayTypeNode;
use Rector\AttributeAwarePhpDoc\Ast\Type\AttributeAwareUnionTypeNode;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\RectorDefinition\CodeSample;
@ -250,6 +252,14 @@ PHP
private function isNonBasicArrayType(Property $property, VarTagValueNode $varTagValueNode): bool
{
if ($varTagValueNode->type instanceof AttributeAwareUnionTypeNode) {
foreach ($varTagValueNode->type->types as $type) {
if ($type instanceof AttributeAwareArrayTypeNode && class_exists((string) $type->type)) {
return true;
}
}
}
if (! $this->isArrayTypeNode($varTagValueNode)) {
return false;
}

27
rules/php74/tests/Rector/Property/TypedPropertyRector/Fixture/do_not_remove_class_docblock_array.php.inc Normal file
View File

@ -0,0 +1,27 @@
<?php
namespace Rector\Php74\Tests\Rector\Property\TypedPropertyRector\Fixture;
final class DonotRemoveClassDocblockArray
{
/**
* @var \DateTime[]|null
*/
private $times2;
}
?>
-----
<?php
namespace Rector\Php74\Tests\Rector\Property\TypedPropertyRector\Fixture;
final class DonotRemoveClassDocblockArray
{
/**
* @var \DateTime[]|null
*/
private ?array $times2 = null;
}
?>