mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-01-17 21:38:22 +01:00
Code Issues Projects Releases Wiki Activity

[AddDoesNotPerformAssertionToNonAssertingTestRector] fix skippi… (#2636)

Browse Source 
[AddDoesNotPerformAssertionToNonAssertingTestRector] fix skipping if annotation already exists (fixes infinite loop too)
This commit is contained in:
Tomas Votruba 2020-01-11 10:32:28 +01:00 committed by GitHub
commit 9cac83e364
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/PHPUnit/src/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector.php
View File

@ -131,7 +131,7 @@ PHP
if ($classMethod->getDocComment() !== null) {
$text = $classMethod->getDocComment();
if (Strings::match($text->getText(), '#@expectedException\b#')) {
if (Strings::match($text->getText(), '#@(doesNotPerformAssertion|expectedException\b)#')) {
return true;
}
}

13
packages/PHPUnit/tests/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_existing_annotation.php.inc Normal file
View File

@ -0,0 +1,13 @@
<?php
namespace Rector\PHPUnit\Tests\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
class SkipExistingAnnotation extends \PHPUnit\Framework\TestCase
{
/**
* @doesNotPerformAssertion
*/
public function testSomething(): void
{
}
}