mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-04-04 23:52:28 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1725 from ravanscafi/empty-compact

Browse Source 
Empty compacts are forbidden, keep signature by replacing with empty array
This commit is contained in:
Tomáš Votruba 2019-07-10 16:00:37 +02:00 committed by GitHub
commit a2e7fbe557
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/Php/src/Rector/FuncCall/RemoveMissingCompactVariableRector.php
View File

@ -3,6 +3,7 @@
namespace Rector\Php\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\FuncCall;
use PHPStan\Analyser\Scope;
use Rector\NodeTypeResolver\Node\AttributeKey;
@ -78,6 +79,10 @@ CODE_SAMPLE
unset($node->args[$key]);
}
if (!$node->args) {
return new Array_();
}
return $node;
}
}

27
packages/Php/tests/Rector/FuncCall/RemoveMissingCompactVariableRector/Fixture/empty_compact.php.inc Normal file
View File

@ -0,0 +1,27 @@
<?php
namespace Rector\Php\Tests\Rector\FuncCall\RemoveMissingCompactVariableRector\Fixture;
class EmptyCompact
{
public function run()
{
return compact('non_existing');
}
}
?>
-----
<?php
namespace Rector\Php\Tests\Rector\FuncCall\RemoveMissingCompactVariableRector\Fixture;
class EmptyCompact
{
public function run()
{
return [];
}
}
?>

6
packages/Php/tests/Rector/FuncCall/RemoveMissingCompactVariableRector/RemoveMissingCompactVariableRectorTest.php
View File

@ -9,7 +9,11 @@ final class RemoveMissingCompactVariableRectorTest extends AbstractRectorTestCas
{
public function test(): void
{
$this->doTestFiles([__DIR__ . '/Fixture/fixture.php.inc', __DIR__ . '/Fixture/skip_maybe_defined.inc']);
$this->doTestFiles([
__DIR__ . '/Fixture/fixture.php.inc',
__DIR__ . '/Fixture/empty_compact.php.inc',
__DIR__ . '/Fixture/skip_maybe_defined.inc',
]);
}
protected function getRectorClass(): string