mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 11:44:14 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2963 from rectorphp/fix-null-trait

Browse Source 
fix get class on trait
This commit is contained in:
Tomas Votruba 2020-02-29 03:21:59 +01:00 committed by GitHub
commit a5fb185c04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
rules/php-72/src/Rector/FuncCall/GetClassOnNullRector.php
View File

@ -12,6 +12,7 @@ use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Ternary;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt\Trait_;
use PHPStan\Analyser\Scope;
use PHPStan\Type\NullType;
use Rector\Core\Rector\AbstractRector;
@ -107,6 +108,11 @@ PHP
private function shouldSkip(FuncCall $funcCall): bool
{
$class = $funcCall->getAttribute(AttributeKey::CLASS_NODE);
if ($class instanceof Trait_) {
return true;
}
$parentNode = $funcCall->getAttribute(AttributeKey::PARENT_NODE);
if (! $parentNode instanceof Ternary) {
return false;
@ -115,7 +121,12 @@ PHP
if ($this->isIdenticalToNotNull($funcCall, $parentNode)) {
return true;
}
return $this->isNotIdenticalToNull($funcCall, $parentNode);
if ($this->isNotIdenticalToNull($funcCall, $parentNode)) {
return true;
}
return false;
}
/**