mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 03:35:01 +01:00
Code Issues Projects Releases Wiki Activity

Make easier to add new assertions to SpecificMethodCountRector

Browse Source
This commit is contained in:
Gabriel Caruso 2017-12-19 20:18:10 -02:00
parent aa50903b38
commit afb27b1900
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/Rector/Contrib/PHPUnit/SpecificMethodCountRector.php
View File

@ -33,16 +33,21 @@ use Rector\Rector\AbstractRector;
*/
final class SpecificMethodCountRector extends AbstractRector
{
/**
* @var string[]
*/
private $renameMethodsMap = [
'assertSame' => 'assertCount',
'assertNotSame' => 'assertNotCount',
'assertEquals' => 'assertCount',
'assertNotEquals' => 'assertNotCount',
];
/**
* @var MethodCallAnalyzer
*/
private $methodCallAnalyzer;
/**
* @var string|null
*/
private $activeFuncCallName;
public function __construct(MethodCallAnalyzer $methodCallAnalyzer)
{
$this->methodCallAnalyzer = $methodCallAnalyzer;
@ -50,8 +55,6 @@ final class SpecificMethodCountRector extends AbstractRector
public function isCandidate(Node $node): bool
{
$this->activeFuncCallName = null;
if (! $this->methodCallAnalyzer->isTypesAndMethods(
$node,
['PHPUnit\Framework\TestCase', 'PHPUnit_Framework_TestCase'],
@ -76,7 +79,9 @@ final class SpecificMethodCountRector extends AbstractRector
$coutableMethod = $secondArgumentValue->name->toString();
return $coutableMethod === 'count' || $coutableMethod === 'sizeof';
return in_array($coutableMethod, [
'count', 'sizeof',
]);
}
/**
@ -86,13 +91,7 @@ final class SpecificMethodCountRector extends AbstractRector
{
$oldMethodName = $methodCallNode->name->toString();
if ($oldMethodName === 'assertEquals' || $oldMethodName === 'assertSame') {
/** @var string $trueMethodName */
$methodCallNode->name = new Identifier('assertCount');
} elseif ($oldMethodName === 'assertNotEquals' || $oldMethodName === 'assertNotSame') {
/** @var string $falseMethodName */
$methodCallNode->name = new Identifier('assertNotCount');
}
$methodCallNode->name = new Identifier($this->renameMethodsMap[$oldMethodName]);
/** @var FuncCall $secondArgument */
$secondArgument = $methodCallNode->args[1]->value;