mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-01-20 23:18:20 +01:00
Code Issues Projects Releases Wiki Activity

keep comments removed with related-stmt

Browse Source
This commit is contained in:
TomasVotruba 2020-05-06 12:58:48 +02:00
parent 65a25fc57e
commit b11ca167b0
3 changed files with 3 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/vendor-locker/src/NodeVendorLocker/ClassMethodReturnVendorLockResolver.php
View File

@ -55,12 +55,8 @@ final class ClassMethodReturnVendorLockResolver extends AbstractNodeVendorLockRe
// if not, look for it's parent parent
}
if (method_exists($parentClassName, $methodName)) {
// validate type is conflicting
// parent class method in external scope → it's not ok
return true;
}
return false;
// validate type is conflicting
// parent class method in external scope → it's not ok
return method_exists($parentClassName, $methodName);
}
}

23
rules/dead-code/tests/Rector/Stmt/RemoveDeadStmtRector/FixtureRemovedComments/keep_comments.php.inc
View File

@ -1,23 +0,0 @@
<?php
// keep this for Harry Potter
$keep;
/** keep this for Harry Potter */
$keep;
/* keep this for Harry Potter */
$keep;
?>
-----
<?php
// keep this for Harry Potter
/** keep this for Harry Potter */
/* keep this for Harry Potter */
?>

1
rules/dead-code/tests/Rector/Stmt/RemoveDeadStmtRector/RemoveDeadStmtRectorTest.php
View File

@ -28,7 +28,6 @@ final class RemoveDeadStmtRectorTest extends AbstractRectorTestCase
*/
public function testKeepComments(string $file): void
{
$this->markTestSkipped('Temporary skip removed docs');
$this->doTestFile($file);
}