mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-03-14 04:19:44 +01:00
Code Issues Projects Releases Wiki Activity

[PHP 7.3] Fix regex slash escaping

Browse Source
This commit is contained in:
TomasVotruba 2020-04-18 20:57:50 +02:00
parent bbd968b207
commit b30eccb246
2 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
rules/php73/tests/Rector/FuncCall/RegexDashEscapeRector/Fixture/slashes.php.inc Normal file
View File

@ -0,0 +1,27 @@
<?php
namespace Rector\Php73\Tests\Rector\FuncCall\RegexDashEscapeRector\Fixture;
class Slashes
{
public function run()
{
preg_match('#[\-\d]$#', 'test');
}
}
?>
-----
<?php
namespace Rector\Php73\Tests\Rector\FuncCall\RegexDashEscapeRector\Fixture;
class Slashes
{
public function run()
{
preg_match('#[\\-\d]$#', 'test');
}
}
?>

12
src/PhpParser/Printer/BetterStandardPrinter.php
View File

@ -266,9 +266,15 @@ final class BetterStandardPrinter extends Standard
*/
protected function pScalar_String(String_ $node): string
{
$kind = $node->getAttribute(AttributeKey::KIND, String_::KIND_SINGLE_QUOTED);
if ($kind === String_::KIND_DOUBLE_QUOTED && $node->getAttribute('is_regular_pattern')) {
return '"' . $node->value . '"';
if ($node->getAttribute('is_regular_pattern')) {
$kind = $node->getAttribute(AttributeKey::KIND, String_::KIND_SINGLE_QUOTED);
if ($kind === String_::KIND_DOUBLE_QUOTED) {
return '"' . $node->value . '"';
}
if ($kind === String_::KIND_SINGLE_QUOTED) {
return "'" . $node->value . "'";
}
}
return parent::pScalar_String($node);