mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-20 08:05:29 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2520 from rectorphp/fix-identical-boolean-false

Browse Source 
[CodingStyle] Fix IdenticalFalseToBooleanNotRector for null|bool
This commit is contained in:
Tomas Votruba 2019-12-29 14:12:20 +01:00 committed by GitHub
commit c2f76f54da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/CodingStyle/src/Rector/Identical/IdenticalFalseToBooleanNotRector.php
View File

@ -9,9 +9,9 @@ use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BooleanNot;
use PHPStan\Type\Constant\ConstantBooleanType;
use PHPStan\Type\IntegerType;
use PHPStan\Type\MixedType;
use PHPStan\Type\NullType;
use PHPStan\Type\Type;
use PHPStan\Type\UnionType;
use Rector\PhpParser\Node\Manipulator\BinaryOpManipulator;
@ -101,8 +101,16 @@ final class IdenticalFalseToBooleanNotRector extends AbstractRector
return false;
}
return $staticType->isSuperTypeOf(new IntegerType())->yes() && $staticType->isSuperTypeOf(
new ConstantBooleanType(false)
)->yes();
foreach ($staticType->getTypes() as $unionedType) {
if ($unionedType instanceof NullType) {
return true;
}
if ($unionedType instanceof IntegerType) {
return true;
}
}
return false;
}
}

18
packages/CodingStyle/tests/Rector/Identical/IdenticalFalseToBooleanNotRector/Fixture/skip_null_false_again.php.inc Normal file
View File

@ -0,0 +1,18 @@
<?php
namespace Rector\CodingStyle\Tests\Rector\Identical\IdenticalFalseToBooleanNotRector\Fixture;
use DateTime;
class SkipNullFalseAgain
{
public function someFunction(string $startStr, string $endStr)
{
$start = !empty($startStr) ? 1 : null;
$end = !empty($endStr) ? 2 : null;
if (false === $end) {
} elseif (false === $start) {
}
}
}