mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 11:44:14 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #3199 from rectorphp/exception-annotation

Browse Source 
[PHPUnit] Fix ExceptionAnnotationRector for null phpdoc
This commit is contained in:
Tomas Votruba 2020-04-20 09:47:05 +02:00 committed by GitHub
commit cc40d00c7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rules/phpunit/src/Rector/ExceptionAnnotationRector.php
View File

@ -83,8 +83,11 @@ PHP
return null;
}
/** @var PhpDocInfo $phpDocInfo */
/** @var PhpDocInfo|null $phpDocInfo */
$phpDocInfo = $node->getAttribute(AttributeKey::PHP_DOC_INFO);
if ($phpDocInfo === null) {
return null;
}
foreach (self::ANNOTATION_TO_METHOD as $annotation => $method) {
if (! $phpDocInfo->hasByName($annotation)) {

21
rules/phpunit/tests/Rector/ExceptionAnnotationRector/Fixture/skip_method_with_null_php_doc.php.inc Normal file
View File

@ -0,0 +1,21 @@
<?php
namespace Rector\PHPUnit\Tests\Rector\ExceptionAnnotationRector\Fixture;
use PHPUnit\Framework\TestCase;
class SkipMethodWithNullPhpDoc extends TestCase
{
public function testLiteralMessage(): void
{
$this->expectException('Exception');
throw new \Exception('A literal exception message');
}
// test
public function testPartialMessageBegin(): void
{
throw new \Exception('A partial exception message');
}
}