mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-04-03 15:12:30 +02:00
Code Issues Projects Releases Wiki Activity

Updated Rector to commit d5d3bcd946dc0565312a46e5941c033615373ce0

Browse Source 
d5d3bcd946 [NodeTraverser] Clean up call ->addVisitor() after NodeTraverser creation (#6690)
This commit is contained in:
Tomas Votruba 2025-01-22 15:21:45 +00:00
parent 3f34d02d99
commit cc97278bff
7 changed files with 165 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
vendor/composer/autoload_classmap.php vendored
View File

@ -1784,6 +1784,7 @@ return array(
'Rector\\PHPUnit\\CodeQuality\\Rector\\Class_\\TestWithToDataProviderRector' => $vendorDir . '/rector/rector-phpunit/rules/CodeQuality/Rector/Class_/TestWithToDataProviderRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\Class_\\YieldDataProviderRector' => $vendorDir . '/rector/rector-phpunit/rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\Foreach_\\SimplifyForeachInstanceOfRector' => $vendorDir . '/rector/rector-phpunit/rules/CodeQuality/Rector/Foreach_/SimplifyForeachInstanceOfRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\FuncCall\\AssertFuncCallToPHPUnitAssertRector' => $vendorDir . '/rector/rector-phpunit/rules/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\MethodCall\\AssertCompareOnCountableWithMethodToAssertCountRector' => $vendorDir . '/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\MethodCall\\AssertCompareToSpecificMethodRector' => $vendorDir . '/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\MethodCall\\AssertComparisonToSpecificMethodRector' => $vendorDir . '/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector.php',

1
vendor/composer/autoload_static.php vendored
View File

@ -2003,6 +2003,7 @@ class ComposerStaticInit3327108c61eea19d09115fa0e353e8ec
'Rector\\PHPUnit\\CodeQuality\\Rector\\Class_\\TestWithToDataProviderRector' => __DIR__ . '/..' . '/rector/rector-phpunit/rules/CodeQuality/Rector/Class_/TestWithToDataProviderRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\Class_\\YieldDataProviderRector' => __DIR__ . '/..' . '/rector/rector-phpunit/rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\Foreach_\\SimplifyForeachInstanceOfRector' => __DIR__ . '/..' . '/rector/rector-phpunit/rules/CodeQuality/Rector/Foreach_/SimplifyForeachInstanceOfRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\FuncCall\\AssertFuncCallToPHPUnitAssertRector' => __DIR__ . '/..' . '/rector/rector-phpunit/rules/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\MethodCall\\AssertCompareOnCountableWithMethodToAssertCountRector' => __DIR__ . '/..' . '/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\MethodCall\\AssertCompareToSpecificMethodRector' => __DIR__ . '/..' . '/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php',
'Rector\\PHPUnit\\CodeQuality\\Rector\\MethodCall\\AssertComparisonToSpecificMethodRector' => __DIR__ . '/..' . '/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector.php',

8
vendor/composer/installed.json vendored
View File

@ -1804,12 +1804,12 @@
"source": {
"type": "git",
"url": "https:\/\/github.com\/rectorphp\/rector-phpunit.git",
"reference": "289978fdd47b511c2d97d8abf1ae1990200304c1"
"reference": "57a5555c9fbe8740e1a6d8def5e10fd32e252dd9"
},
"dist": {
"type": "zip",
"url": "https:\/\/api.github.com\/repos\/rectorphp\/rector-phpunit\/zipball\/289978fdd47b511c2d97d8abf1ae1990200304c1",
"reference": "289978fdd47b511c2d97d8abf1ae1990200304c1",
"url": "https:\/\/api.github.com\/repos\/rectorphp\/rector-phpunit\/zipball\/57a5555c9fbe8740e1a6d8def5e10fd32e252dd9",
"reference": "57a5555c9fbe8740e1a6d8def5e10fd32e252dd9",
"shasum": ""
},
"require": {
@ -1830,7 +1830,7 @@
"tomasvotruba\/class-leak": "^1.2",
"tracy\/tracy": "^2.10"
},
"time": "2025-01-21T19:46:08+00:00",
"time": "2025-01-22T12:35:28+00:00",
"default-branch": true,
"type": "rector-extension",
"extra": {

2
vendor/composer/installed.php vendored
View File

File diff suppressed because one or more lines are too long

2
vendor/rector/extension-installer/src/GeneratedConfig.php vendored
View File

@ -9,7 +9,7 @@ namespace Rector\RectorInstaller;
*/
final class GeneratedConfig
{
public const EXTENSIONS = array('rector/rector-doctrine' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-doctrine', 'relative_install_path' => '../../rector-doctrine', 'extra' => NULL, 'version' => 'dev-main ceda7a4'), 'rector/rector-downgrade-php' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-downgrade-php', 'relative_install_path' => '../../rector-downgrade-php', 'extra' => NULL, 'version' => 'dev-main 2e0cde6'), 'rector/rector-phpunit' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-phpunit', 'relative_install_path' => '../../rector-phpunit', 'extra' => NULL, 'version' => 'dev-main 289978f'), 'rector/rector-symfony' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-symfony', 'relative_install_path' => '../../rector-symfony', 'extra' => NULL, 'version' => 'dev-main 4661c01'));
public const EXTENSIONS = array('rector/rector-doctrine' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-doctrine', 'relative_install_path' => '../../rector-doctrine', 'extra' => NULL, 'version' => 'dev-main ceda7a4'), 'rector/rector-downgrade-php' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-downgrade-php', 'relative_install_path' => '../../rector-downgrade-php', 'extra' => NULL, 'version' => 'dev-main 2e0cde6'), 'rector/rector-phpunit' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-phpunit', 'relative_install_path' => '../../rector-phpunit', 'extra' => NULL, 'version' => 'dev-main 57a5555'), 'rector/rector-symfony' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-symfony', 'relative_install_path' => '../../rector-symfony', 'extra' => NULL, 'version' => 'dev-main 4661c01'));
private function __construct()
{
}

149
vendor/rector/rector-phpunit/rules/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector.php vendored Normal file
View File

@ -0,0 +1,149 @@
<?php
declare (strict_types=1);
namespace Rector\PHPUnit\CodeQuality\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp\Equal;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\Cast\Bool_;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Instanceof_;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Name\FullyQualified;
use PHPStan\Reflection\ClassReflection;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\PHPStan\ScopeFetcher;
use Rector\PHPUnit\Enum\AssertMethod;
use Rector\PHPUnit\Enum\PHPUnitClassName;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector\AssertFuncCallToPHPUnitAssertRectorTest
*/
final class AssertFuncCallToPHPUnitAssertRector extends AbstractRector
{
/**
* @readonly
*/
private ValueResolver $valueResolver;
public function __construct(ValueResolver $valueResolver)
{
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Turns assert() calls to their explicit PHPUnit assert alternative', [new CodeSample('assert($value === 100, "message");', '$this->assertSame(100, $value, "message");')]);
}
/**
* @return class-string[]
*/
public function getNodeTypes() : array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
* @return \PhpParser\Node\Expr\StaticCall|\PhpParser\Node\Expr\MethodCall|null
*/
public function refactor(Node $node)
{
if ($node->isFirstClassCallable()) {
return null;
}
if (!$this->isName($node, 'assert')) {
return null;
}
if (!$this->isTestFilePath($node) && !$this->isBehatContext($node)) {
return null;
}
$comparedExpr = $node->getArgs()[0]->value;
if ($comparedExpr instanceof Equal) {
$methodName = AssertMethod::ASSERT_EQUALS;
$exprs = [$comparedExpr->right, $comparedExpr->left];
} elseif ($comparedExpr instanceof Identical) {
$methodName = AssertMethod::ASSERT_SAME;
$exprs = [$comparedExpr->right, $comparedExpr->left];
} elseif ($comparedExpr instanceof NotIdentical) {
if ($this->valueResolver->isNull($comparedExpr->right)) {
$methodName = 'assertNotNull';
$exprs = [$comparedExpr->left];
} else {
return null;
}
} elseif ($comparedExpr instanceof Bool_) {
$methodName = 'assertTrue';
$exprs = [$comparedExpr];
} elseif ($comparedExpr instanceof FuncCall) {
if ($this->isName($comparedExpr, 'method_exists')) {
$methodName = 'assertTrue';
$exprs = [$comparedExpr];
} else {
return null;
}
} elseif ($comparedExpr instanceof Instanceof_) {
// outside TestCase
$methodName = 'assertInstanceOf';
$exprs = [];
if ($comparedExpr->class instanceof FullyQualified) {
$classConstFetch = new ClassConstFetch($comparedExpr->class, 'class');
$exprs[] = $classConstFetch;
} else {
return null;
}
$exprs[] = $comparedExpr->expr;
} else {
return null;
}
// is there a comment message
if (isset($node->getArgs()[1])) {
$exprs[] = $node->getArgs()[1]->value;
}
return $this->createCall($node, $methodName, $exprs);
}
private function isBehatContext(FuncCall $funcCall) : bool
{
$scope = ScopeFetcher::fetch($funcCall);
if (!$scope->getClassReflection() instanceof ClassReflection) {
return \false;
}
$className = $scope->getClassReflection()->getName();
// special case with static call
return \substr_compare($className, 'Context', -\strlen('Context')) === 0;
}
private function isTestFilePath(FuncCall $funcCall) : bool
{
$scope = ScopeFetcher::fetch($funcCall);
if (!$scope->getClassReflection() instanceof ClassReflection) {
return \false;
}
$className = $scope->getClassReflection()->getName();
if (\substr_compare($className, 'Test', -\strlen('Test')) === 0) {
return \true;
}
return \substr_compare($className, 'TestCase', -\strlen('TestCase')) === 0;
}
/**
* @param Expr[] $exprs
* @return \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall
*/
private function createCall(FuncCall $funcCall, string $methodName, array $exprs)
{
$args = [];
foreach ($exprs as $expr) {
$args[] = new Arg($expr);
}
if ($this->isBehatContext($funcCall)) {
$assertFullyQualified = new FullyQualified(PHPUnitClassName::ASSERT);
return new StaticCall($assertFullyQualified, $methodName, $args);
}
return new MethodCall(new Variable('this'), $methodName, $args);
}
}

8
vendor/rector/rector-phpunit/src/Enum/AssertMethod.php vendored
View File

@ -13,4 +13,12 @@ final class AssertMethod
* @var string
*/
public const ASSERT_TRUE = 'assertTrue';
/**
* @var string
*/
public const ASSERT_EQUALS = 'assertEquals';
/**
* @var string
*/
public const ASSERT_SAME = 'assertSame';
}