mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-21 09:42:45 +01:00
Code Issues Projects Releases Wiki Activity

finish ArgumentRemoverRector

Browse Source
This commit is contained in:
TomasVotruba 2017-10-29 22:05:08 +01:00
parent d52655e1f6
commit d141736e36
1 changed files with 75 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

97
src/Rector/Dynamic/ArgumentRemoverRector.php
View File

@ -3,6 +3,9 @@
namespace Rector\Rector\Dynamic;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Param;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassLike;
@ -43,7 +46,7 @@ final class ArgumentRemoverRector extends AbstractRector
public function isCandidate(Node $node): bool
{
if (! $node instanceof ClassMethod) {
if (! $node instanceof ClassMethod && ! $node instanceof MethodCall && ! $node instanceof StaticCall) {
return false;
}
@ -59,28 +62,24 @@ final class ArgumentRemoverRector extends AbstractRector
}
/**
* @param ClassMethod $classMethodNode
* @param ClassMethod|StaticCall|StaticCall $node
*/
public function refactor(Node $classMethodNode): ?Node
public function refactor(Node $node): ?Node
{
/** @var Class_ $classMethodNode */
$classNode = $classMethodNode->getAttribute(Attribute::CLASS_NODE);
/** @var Class_ $node */
$classNode = $node->getAttribute(Attribute::CLASS_NODE);
$classNodeTypes = $classNode->getAttribute(Attribute::TYPES);
$matchingTypes = $this->getMatchingTypesForClassNode($classNodeTypes);
$methodName = $classMethodNode->name->toString();
foreach ($matchingTypes as $matchingType) {
$configuration = $this->argumentsToRemoveByMethodAndClass[$matchingType];
foreach ($configuration as $method => $argumentsToRemove) {
if ($methodName === $method) {
return $this->processClassMethodNodeWithArgumentsToRemove($classMethodNode, $argumentsToRemove);
}
}
if ($node instanceof ClassMethod) {
return $this->processClassMethod($node, $matchingTypes);
}
return $classMethodNode;
if ($node instanceof MethodCall || $node instanceof StaticCall) {
return $this->processMethodAndStaticCall($node, $matchingTypes);
}
return $node;
}
/**
@ -108,18 +107,53 @@ final class ArgumentRemoverRector extends AbstractRector
return array_intersect($types, $this->getClasses());
}
/**
* @param StaticCall|MethodCall $node
* @param string[] $matchingTypes
* @return StaticCall|MethodCall
*/
private function processMethodAndStaticCall(Node $node, array $matchingTypes): Node
{
$methodName = $node->name->toString();
foreach ($matchingTypes as $matchingType) {
$configuration = $this->argumentsToRemoveByMethodAndClass[$matchingType];
foreach ($configuration as $method => $argumentsToRemove) {
if ($methodName === $method) {
return $this->removeParameterFromMethodAndStaticCall($node, $argumentsToRemove);
}
}
}
}
/**
* @param string[] $matchingTypes
*/
private function processClassMethod(ClassMethod $classMethodNode, array $matchingTypes): ClassMethod
{
$methodName = $classMethodNode->name->toString();
foreach ($matchingTypes as $matchingType) {
$configuration = $this->argumentsToRemoveByMethodAndClass[$matchingType];
foreach ($configuration as $method => $argumentsToRemove) {
if ($methodName === $method) {
return $this->removeArgumentsFromClassMethod($classMethodNode, $argumentsToRemove);
}
}
}
}
/**
* @param string[] $argumentsToRemove
*/
private function processClassMethodNodeWithArgumentsToRemove(
ClassMethod $classMethodNode,
array $argumentsToRemove
): ClassMethod {
private function removeArgumentsFromClassMethod(ClassMethod $classMethodNode, array $argumentsToRemove): ClassMethod
{
/** @var Param $param */
foreach ($classMethodNode->params as $key => $param) {
$parameterName = $param->var->name;
if (! in_array($parameterName, $argumentsToRemove)) {
if (! in_array($parameterName, $argumentsToRemove, true)) {
continue;
}
@ -128,4 +162,23 @@ final class ArgumentRemoverRector extends AbstractRector
return $classMethodNode;
}
/**
* @param StaticCall|MethodCall $node
* @param string[] $argumentsToRemove
*/
private function removeParameterFromMethodAndStaticCall(Node $node, array $argumentsToRemove): Node
{
/** @var Arg $arg */
foreach ($node->args as $key => $arg) {
$argumentName = $arg->value->name;
if (! in_array($argumentName, $argumentsToRemove, true)) {
continue;
}
unset($node->args[$key]);
}
return $node;
}
}