From d1b63e2e550019a1580207dc30c9e4d3c1428a30 Mon Sep 17 00:00:00 2001 From: TomasVotruba Date: Sat, 29 Feb 2020 15:06:05 +0100 Subject: [PATCH] fix typoe open-source parameter --- .../ClassMethod/RemoveUnusedParameterRector.php | 14 ++++++++++++-- src/Configuration/Option.php | 5 +++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/rules/dead-code/src/Rector/ClassMethod/RemoveUnusedParameterRector.php b/rules/dead-code/src/Rector/ClassMethod/RemoveUnusedParameterRector.php index e6a4e5d01ad..e8ad6a3dfb3 100644 --- a/rules/dead-code/src/Rector/ClassMethod/RemoveUnusedParameterRector.php +++ b/rules/dead-code/src/Rector/ClassMethod/RemoveUnusedParameterRector.php @@ -232,8 +232,7 @@ PHP private function shouldSkipOpenSourceAbstract(ClassMethod $classMethod, Class_ $class): bool { // skip as possible contract for 3rd party - $projectType = $this->parameterProvider->provideParameter(Option::PROJECT_TYPE); - if ($projectType !== Option::PROJECT_TYPE_OPEN_SOURCE) { + if (! $this->isOpenSourceProjectType()) { return false; } @@ -247,4 +246,15 @@ PHP return $classMethod->isPublic(); } + + private function isOpenSourceProjectType(): bool + { + $projectType = $this->parameterProvider->provideParameter(Option::PROJECT_TYPE); + + return in_array( + $projectType, + [Option::PROJECT_TYPE_OPEN_SOURCE, Option::PROJECT_TYPE_OPEN_SOURCE_UNDESCORED], + true + ); + } } diff --git a/src/Configuration/Option.php b/src/Configuration/Option.php index 9aa6900c903..5e7d5092ab4 100644 --- a/src/Configuration/Option.php +++ b/src/Configuration/Option.php @@ -85,4 +85,9 @@ final class Option * @var string */ public const PROJECT_TYPE_OPEN_SOURCE = 'open-source'; + + /** + * @var string + */ + public const PROJECT_TYPE_OPEN_SOURCE_UNDESCORED = 'open_source'; }