mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 11:44:14 +01:00
Code Issues Projects Releases Wiki Activity

#2824: Improve names of variables.

Browse Source
This commit is contained in:
Aerendir 2020-02-12 01:23:24 +01:00
parent d2460d4cec
commit d4d733c1fa
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packages/coding-style/src/Rector/ClassMethod/AnnotateThrowablesRector.php
View File

@ -99,23 +99,23 @@ PHP
/** @var PhpDocInfo $phpDocInfo */
$phpDocInfo = $stmt->getAttribute(AttributeKey::PHP_DOC_INFO);
$throwTags = $phpDocInfo->getTagsByName('throws');
$FQN = $this->buildFQN($node);
$alreadyAnnotatedThrowTags = $phpDocInfo->getTagsByName('throws');
$checkingThrowableClassName = $this->buildFQN($node);
if (empty($throwTags)) {
if (empty($alreadyAnnotatedThrowTags)) {
return false;
}
/** @var AttributeAwarePhpDocTagNode $throwTag */
foreach ($throwTags as $throwTag) {
$thrownClassName = $throwTag->value->type->name;
if ($thrownClassName === $FQN) {
/** @var AttributeAwarePhpDocTagNode $alreadyAnnotatedThrowTag */
foreach ($alreadyAnnotatedThrowTags as $alreadyAnnotatedThrowTag) {
$alreadyAnnotatedThrowTagClassName = $alreadyAnnotatedThrowTag->value->type->name;
if ($alreadyAnnotatedThrowTagClassName === $checkingThrowableClassName) {
return true;
}
if (
! Strings::contains($thrownClassName, '\\') &&
Strings::contains($FQN, $thrownClassName) &&
! Strings::contains($alreadyAnnotatedThrowTagClassName, '\\') &&
Strings::contains($checkingThrowableClassName, $alreadyAnnotatedThrowTagClassName) &&
$this->isThrowableImported($node)
) {
return true;