mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-01-19 06:18:07 +01:00
Code Issues Projects Releases Wiki Activity

fix variable type (#6314)

Browse Source
This commit is contained in:
Tomas Votruba 2021-05-03 20:03:01 +02:00 committed by GitHub
parent c43b216d64
commit d689800fe7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
rules/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector.php
View File

@ -13,6 +13,7 @@ use PhpParser\Node\Param;
use PhpParser\Node\Stmt\Property;
use PhpParser\Node\UnionType;
use PHPStan\Analyser\Scope;
use PHPStan\Type\MixedType;
use PHPStan\Type\Type;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\ValueObject\PhpVersionFeature;
@ -100,10 +101,9 @@ CODE_SAMPLE
return null;
}
$scope = $param->getAttribute(AttributeKey::SCOPE);
$originalParamType = $this->resolveParamOriginalType($param);
$paramName = $this->getName($param);
$originalParamType = $scope->getVariableType($paramName);
/** @var Assign[] $assigns */
$assigns = $this->betterNodeFinder->findInstanceOf((array) $functionLike->getStmts(), Assign::class);
@ -174,7 +174,27 @@ CODE_SAMPLE
if (! $scope instanceof Scope) {
return false;
}
if (! $scope->hasVariableType($paramName)->yes()) {
return false;
}
$currentParamType = $scope->getVariableType($paramName);
return ! $currentParamType->equals($originalType);
}
private function resolveParamOriginalType(Param $param): Type
{
$scope = $param->getAttribute(AttributeKey::SCOPE);
if (! $scope instanceof Scope) {
return new MixedType();
}
$paramName = $this->getName($param);
if (! $scope->hasVariableType($paramName)->yes()) {
return new MixedType();
}
return $scope->getVariableType($paramName);
}
}