From d86400590429deb741a2c2466bc56a3213763578 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Mike=C5=A1?= Date: Sun, 25 Oct 2020 15:26:01 +0100 Subject: [PATCH] Fix not provided --output-file argument translated into string instead of null (#4480) * Fix not provided --output-file argument translated into string instead of null Fixes #4456 * [rector] Fix not provided --output-file argument translated into string instead of null Fixes #4456 * [cs] Fix not provided --output-file argument translated into string instead of null Fixes #4456 Co-authored-by: rector-bot --- src/Configuration/Configuration.php | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/Configuration/Configuration.php b/src/Configuration/Configuration.php index 8d26e032df3..9f7614a5e0c 100644 --- a/src/Configuration/Configuration.php +++ b/src/Configuration/Configuration.php @@ -125,9 +125,9 @@ final class Configuration $this->showProgressBar = $this->canShowProgressBar($input); $this->isCacheDebug = (bool) $input->getOption(Option::CACHE_DEBUG); - /** @var string $outputFileOption */ + /** @var string|null $outputFileOption */ $outputFileOption = $input->getOption(Option::OPTION_OUTPUT_FILE); - $this->outputFile = $outputFileOption !== '' ? (string) $outputFileOption : null; + $this->outputFile = $this->sanitizeOutputFileValue($outputFileOption); $this->outputFormat = (string) $input->getOption(Option::OPTION_OUTPUT_FORMAT); @@ -308,6 +308,15 @@ final class Configuration return $input->getOption(Option::OPTION_OUTPUT_FORMAT) !== CheckstyleOutputFormatter::NAME; } + private function sanitizeOutputFileValue(?string $outputFileOption): ?string + { + if ($outputFileOption === '') { + return null; + } + + return $outputFileOption; + } + private function setOnlyRector(string $rector): void { $this->onlyRector = $this->onlyRuleResolver->resolve($rector);