[PHP] Add ListSwapArrayOrderRector

config/level/php/php70.yml

@@ -5,3 +5,7 @@ services:
     Rector\Php\Rector\FunctionLike\ExceptionHandlerTypehintRector: ~
     Rector\Php\Rector\FuncCall\MultiDirnameRector: ~
     Rector\Php\Rector\List_\ListSplitStringRector: ~
+    Rector\Php\Rector\List_\EmptyListRector: ~
+
+    # be careful, run this just once, since it can keep swapping order back and forth
+    Rector\Php\Rector\List_\ListSwapArrayOrderRector: ~

packages/Php/src/Rector/List_/ListSwapArrayOrderRector.php

@@ -0,0 +1,79 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Php\Rector\List_;
+
+use PhpParser\Node;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\ArrayDimFetch;
+use PhpParser\Node\Expr\ArrayItem;
+use PhpParser\Node\Expr\Assign;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\List_;
+use PhpParser\Node\Name;
+use Rector\Printer\BetterStandardPrinter;
+use Rector\Rector\AbstractRector;
+use Rector\RectorDefinition\CodeSample;
+use Rector\RectorDefinition\RectorDefinition;
+
+/**
+ * @source http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible.variable-handling.list
+ */
+final class ListSwapArrayOrderRector extends AbstractRector
+{
+    /**
+     * @var BetterStandardPrinter
+     */
+    private $betterStandardPrinter;
+
+    public function __construct(BetterStandardPrinter $betterStandardPrinter)
+    {
+        $this->betterStandardPrinter = $betterStandardPrinter;
+    }
+
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition(
+            'list() assigns variables in reverse order - relevant in array assign',
+            [new CodeSample('list($a[], $a[]) = [1, 2];', 'list($a[], $a[]) = array_reverse([1, 2])];')]
+        );
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getNodeTypes(): array
+    {
+        return [Assign::class];
+    }
+
+    /**
+     * @param Assign $assignNode
+     */
+    public function refactor(Node $assignNode): ?Node
+    {
+        if (! $assignNode->var instanceof List_) {
+            return $assignNode;
+        }
+
+        $printerVars = [];
+
+        /** @var ArrayItem $item */
+        foreach ($assignNode->var->items as $item) {
+            if ($item->value instanceof ArrayDimFetch) {
+                $printerVars[] = $this->betterStandardPrinter->prettyPrint([$item->value->var]);
+            } else {
+                return $assignNode;
+            }
+        }
+
+        // relevant only in 1 variable type
+        if (count(array_unique($printerVars)) !== 1) {
+            return $assignNode;
+        }
+
+        // wrap with array_reverse, to reflect reverse assign order in left
+        $assignNode->expr = new FuncCall(new Name('array_reverse'), [new Arg($assignNode->expr)]);
+
+        return $assignNode;
+    }
+}

packages/Php/tests/Rector/List_/ListSwapArrayOrderRector/Correct/correct.php.inc

@@ -0,0 +1,7 @@
+<?php declare(strict_types=1);
+
+list($a[], $a[]) = array_reverse([1, 2]);
+
+list($a[], $b[]) = [1, 2];
+
+list($a, $b, $c) = [1, 2, 3];

packages/Php/tests/Rector/List_/ListSwapArrayOrderRector/ListSwapArrayOrderRectorTest.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Php\Tests\Rector\List_\ListSwapArrayOrderRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+/**
+ * @covers \Rector\Php\Rector\List_\ListSwapArrayOrderRector
+ */
+final class ListSwapArrayOrderRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideWrongToFixedFiles()
+     */
+    public function test(string $wrong, string $fixed): void
+    {
+        $this->doTestFileMatchesExpectedContent($wrong, $fixed);
+    }
+
+    public function provideWrongToFixedFiles(): Iterator
+    {
+        yield [__DIR__ . '/Wrong/wrong.php.inc', __DIR__ . '/Correct/correct.php.inc'];
+    }
+
+    protected function provideConfig(): string
+    {
+        return __DIR__ . '/config.yml';
+    }
+}

packages/Php/tests/Rector/List_/ListSwapArrayOrderRector/Wrong/wrong.php.inc

@@ -0,0 +1,7 @@
+<?php declare(strict_types=1);
+
+list($a[], $a[]) = [1, 2];
+
+list($a[], $b[]) = [1, 2];
+
+list($a, $b, $c) = [1, 2, 3];

packages/Php/tests/Rector/List_/ListSwapArrayOrderRector/config.yml

@@ -0,0 +1,2 @@
+services:
+    Rector\Php\Rector\List_\ListSwapArrayOrderRector: ~