[PHPUnit] Improve GetMockRector

packages/PHPUnit/src/Rector/GetMockRector.php

@@ -13,6 +13,9 @@ use Rector\RectorDefinition\CodeSample;
 use Rector\RectorDefinition\RectorDefinition;
 
 /**
+ * @see https://github.com/sebastianbergmann/phpunit/blob/5.7.0/src/Framework/TestCase.php#L1623
+ * @see https://github.com/sebastianbergmann/phpunit/blob/6.0.0/src/Framework/TestCase.php#L1452
+ *
  * @see \Rector\PHPUnit\Tests\Rector\GetMockRector\GetMockRectorTest
  */
 final class GetMockRector extends AbstractPHPUnitRector
@@ -45,8 +48,15 @@ final class GetMockRector extends AbstractPHPUnitRector
             return null;
         }
 
-        if (count($node->args) !== 1) {
-            return null;
+        if ($node instanceof MethodCall) {
+            if ($node->var instanceof MethodCall) {
+                return null;
+            }
+        }
+
+        // narrow args to one
+        if (count($node->args) > 1) {
+            $node->args = [$node->args[0]];
         }
 
         $node->name = new Identifier('createMock');

packages/PHPUnit/tests/Rector/GetMockRector/Fixture/fixture.php.inc

@@ -7,9 +7,6 @@ final class MyGetMockTest extends \PHPUnit\Framework\TestCase
     public function test()
     {
         $firstMock = $this->getMock('SomeClass');
-
-        $secondMock = $this->buildMock()
-            ->getMock();
     }
 }
 
@@ -24,9 +21,6 @@ final class MyGetMockTest extends \PHPUnit\Framework\TestCase
     public function test()
     {
         $firstMock = $this->createMock('SomeClass');
-
-        $secondMock = $this->buildMock()
-            ->getMock();
     }
 }
 

packages/PHPUnit/tests/Rector/GetMockRector/Fixture/get_mock_multi.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\GetMockRector\Fixture;
+
+final class GetMockMultiTest extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $firstMock = $this->getMock('LDUser', [], [], '', false);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\GetMockRector\Fixture;
+
+final class GetMockMultiTest extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $firstMock = $this->createMock('LDUser');
+    }
+}
+
+?>

packages/PHPUnit/tests/Rector/GetMockRector/Fixture/skip_build_mock.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\GetMockRector\Fixture;
+
+final class SkipBuildMockTest extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $secondMock = $this->buildMock()
+            ->getMock();
+    }
+}

packages/PHPUnit/tests/Rector/GetMockRector/Fixture/static_call.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\GetMockRector\Fixture;
+
+final class StaticCallTest extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $firstMock = self::getMock('SomeClass');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\GetMockRector\Fixture;
+
+final class StaticCallTest extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $firstMock = self::createMock('SomeClass');
+    }
+}
+
+?>