From e917735190c8df99622ea72223f33e81db83e8c9 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Sun, 12 Aug 2018 13:06:07 +0200
Subject: [PATCH] Add FunctionReplacerRector [closes #571]

---
 .../Function_/FunctionReplaceRector.php       | 82 +++++++++++++++++++
 .../StaticCall/StaticCallToFunctionRector.php |  2 +-
 .../Correct/correct.php.inc                   |  9 ++
 .../FunctionReplacerRectorTest.php            | 30 +++++++
 .../FunctionReplaceRector/Wrong/wrong.php.inc |  9 ++
 .../FunctionReplaceRector/config.yml          |  4 +
 6 files changed, 135 insertions(+), 1 deletion(-)
 create mode 100644 src/Rector/Function_/FunctionReplaceRector.php
 create mode 100644 tests/Rector/Function_/FunctionReplaceRector/Correct/correct.php.inc
 create mode 100644 tests/Rector/Function_/FunctionReplaceRector/FunctionReplacerRectorTest.php
 create mode 100644 tests/Rector/Function_/FunctionReplaceRector/Wrong/wrong.php.inc
 create mode 100644 tests/Rector/Function_/FunctionReplaceRector/config.yml

diff --git a/src/Rector/Function_/FunctionReplaceRector.php b/src/Rector/Function_/FunctionReplaceRector.php
new file mode 100644
index 00000000000..f52d29993a4
--- /dev/null
+++ b/src/Rector/Function_/FunctionReplaceRector.php
@@ -0,0 +1,82 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Rector\Function_;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Name;
+use PhpParser\Node\Name\FullyQualified;
+use Rector\Rector\AbstractRector;
+use Rector\RectorDefinition\ConfiguredCodeSample;
+use Rector\RectorDefinition\RectorDefinition;
+
+final class FunctionReplaceRector extends AbstractRector
+{
+    /**
+     * @var string[]
+     */
+    private $oldFunctionToNewFunction = [];
+
+    /**
+     * @param string[] $oldFunctionToNewFunction
+     */
+    public function __construct(array $oldFunctionToNewFunction)
+    {
+        $this->oldFunctionToNewFunction = $oldFunctionToNewFunction;
+    }
+
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition('Turns defined function call new one.', [
+            new ConfiguredCodeSample(
+                'view("...", []);',
+                'Laravel\Templating\render("...", []);',
+                [
+                    '$functionToStaticCall' => [
+                        'view' => 'Laravel\Templating\render',
+                    ],
+                ]
+            ),
+        ]);
+    }
+
+    /**
+     * future compatibility
+     */
+    public function getNodeType(): string
+    {
+        return FuncCall::class;
+    }
+
+    public function isCandidate(Node $node): bool
+    {
+        return true;
+    }
+
+    /**
+     * @param FuncCall $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $node instanceof FuncCall) {
+            return $node;
+        }
+
+        // anonymous function
+        if (! $node->name instanceof Name) {
+            return $node;
+        }
+
+        $functionName = $node->name->toString();
+        if (! isset($this->oldFunctionToNewFunction[$functionName])) {
+            return $node;
+        }
+
+        $newFunctionName = $this->oldFunctionToNewFunction[$functionName];
+
+        $functCallNode = new FuncCall(new FullyQualified($newFunctionName));
+        $functCallNode->args = $node->args;
+
+        return $functCallNode;
+    }
+}
diff --git a/src/Rector/StaticCall/StaticCallToFunctionRector.php b/src/Rector/StaticCall/StaticCallToFunctionRector.php
index 8f830d34cb3..c79faba4579 100644
--- a/src/Rector/StaticCall/StaticCallToFunctionRector.php
+++ b/src/Rector/StaticCall/StaticCallToFunctionRector.php
@@ -42,7 +42,7 @@ final class StaticCallToFunctionRector extends AbstractRector
         return new RectorDefinition('Turns static call to function call.', [
             new ConfiguredCodeSample(
                 'OldClass::oldMethod("args");',
-                'new_functoin("args");',
+                'new_function("args");',
                 [
                     '$staticCallToFunction' => [
                         'OldClass::oldMethod' => 'new_function',
diff --git a/tests/Rector/Function_/FunctionReplaceRector/Correct/correct.php.inc b/tests/Rector/Function_/FunctionReplaceRector/Correct/correct.php.inc
new file mode 100644
index 00000000000..d32550a4a32
--- /dev/null
+++ b/tests/Rector/Function_/FunctionReplaceRector/Correct/correct.php.inc
@@ -0,0 +1,9 @@
+<?php
+
+class SomeClass
+{
+    public function someMethod()
+    {
+        \Laravel\Templating\render('template', []);
+    }
+}
diff --git a/tests/Rector/Function_/FunctionReplaceRector/FunctionReplacerRectorTest.php b/tests/Rector/Function_/FunctionReplaceRector/FunctionReplacerRectorTest.php
new file mode 100644
index 00000000000..a710bd3e9e8
--- /dev/null
+++ b/tests/Rector/Function_/FunctionReplaceRector/FunctionReplacerRectorTest.php
@@ -0,0 +1,30 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Tests\Rector\Function_\FunctionReplacerRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+/**
+ * @see \Rector\Rector\Function_\FunctionReplaceRector
+ */
+final class FunctionReplacerRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideWrongToFixedFiles()
+     */
+    public function test(string $wrong, string $fixed): void
+    {
+        $this->doTestFileMatchesExpectedContent($wrong, $fixed);
+    }
+
+    public function provideWrongToFixedFiles(): Iterator
+    {
+        yield [__DIR__ . '/Wrong/wrong.php.inc', __DIR__ . '/Correct/correct.php.inc'];
+    }
+
+    protected function provideConfig(): string
+    {
+        return __DIR__ . '/config.yml';
+    }
+}
diff --git a/tests/Rector/Function_/FunctionReplaceRector/Wrong/wrong.php.inc b/tests/Rector/Function_/FunctionReplaceRector/Wrong/wrong.php.inc
new file mode 100644
index 00000000000..a7445af76d6
--- /dev/null
+++ b/tests/Rector/Function_/FunctionReplaceRector/Wrong/wrong.php.inc
@@ -0,0 +1,9 @@
+<?php
+
+class SomeClass
+{
+    public function someMethod()
+    {
+        view('template', []);
+    }
+}
diff --git a/tests/Rector/Function_/FunctionReplaceRector/config.yml b/tests/Rector/Function_/FunctionReplaceRector/config.yml
new file mode 100644
index 00000000000..2736c3a58d6
--- /dev/null
+++ b/tests/Rector/Function_/FunctionReplaceRector/config.yml
@@ -0,0 +1,4 @@
+services:
+    Rector\Rector\Function_\FunctionReplaceRector:
+        $oldFunctionToNewFunction:
+            'view': 'Laravel\Templating\render'