mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-01-17 21:38:22 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2997 from gnutix/static-call-fixes

Browse Source 
Fix various static calls errors in PHPUnit Rectors.
This commit is contained in:
Tomas Votruba 2020-03-04 00:16:58 +01:00 committed by GitHub
commit e9ee423b34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 33 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rules/phpunit/src/Rector/SpecificMethod/AssertFalseStrposToContainsRector.php
View File

@ -71,6 +71,9 @@ final class AssertFalseStrposToContainsRector extends AbstractPHPUnitRector
}
$firstArgumentValue = $node->args[0]->value;
if ($firstArgumentValue instanceof StaticCall) {
return null;
}
if (! $this->isNames($firstArgumentValue, ['strpos', 'stripos'])) {
return null;
}

5
rules/phpunit/src/Rector/SpecificMethod/AssertPropertyExistsRector.php
View File

@ -81,9 +81,10 @@ final class AssertPropertyExistsRector extends AbstractPHPUnitRector
return null;
}
/** @var FuncCall $firstArgumentValue */
$firstArgumentValue = $node->args[0]->value;
if ($firstArgumentValue instanceof StaticCall) {
return null;
}
if (! $this->isName($firstArgumentValue, 'property_exists')) {
return null;
}

7
rules/phpunit/src/Rector/SpecificMethod/AssertTrueFalseToSpecificMethodRector.php
View File

@ -73,9 +73,10 @@ final class AssertTrueFalseToSpecificMethodRector extends AbstractPHPUnitRector
}
$firstArgumentValue = $node->args[0]->value;
if ($firstArgumentValue instanceof StaticCall ||
! $this->isNames($firstArgumentValue, array_keys(self::OLD_TO_NEW_METHODS))
) {
if ($firstArgumentValue instanceof StaticCall) {
return null;
}
if (! $this->isNames($firstArgumentValue, array_keys(self::OLD_TO_NEW_METHODS))) {
return null;
}

11
rules/phpunit/tests/Rector/SpecificMethod/AssertFalseStrposToContainsRector/Fixture/skip_static_call.php.inc Normal file
View File

@ -0,0 +1,11 @@
<?php
namespace Rector\PHPUnit\Tests\Rector\SpecificMethod\AssertFalseStrposToContainsRector\Fixture;
final class SkipStaticCall extends \PHPUnit\Framework\TestCase
{
public function test()
{
self::assertFalse(SomeClass::someMethod());
}
}

11
rules/phpunit/tests/Rector/SpecificMethod/AssertPropertyExistsRector/Fixture/skip_static_call.php.inc Normal file
View File

@ -0,0 +1,11 @@
<?php
namespace Rector\PHPUnit\Tests\Rector\SpecificMethod\AssertPropertyExistsRector\Fixture;
final class SkipStaticCall extends \PHPUnit\Framework\TestCase
{
public function test()
{
self::assertFalse(SomeClass::someMethod());
}
}

2
rules/phpunit/tests/Rector/SpecificMethod/AssertTrueFalseToSpecificMethodRector/Fixture/fixture3.php.inc → rules/phpunit/tests/Rector/SpecificMethod/AssertTrueFalseToSpecificMethodRector/Fixture/skip_static_call.php.inc
View File

@ -2,7 +2,7 @@
namespace Rector\PHPUnit\Tests\Rector\SpecificMethod\AssertTrueFalseToSpecificMethodRector\Fixture;
final class Fixture3Test extends \PHPUnit\Framework\TestCase
final class SkipStaticCall extends \PHPUnit\Framework\TestCase
{
public function test()
{