mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 03:35:01 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2872 from rectorphp/array-spread

Browse Source 
Skip unpackaged args in ArraySpreadInsteadOfArrayMergeRector
This commit is contained in:
Tomas Votruba 2020-02-17 15:22:58 +01:00 committed by GitHub
commit efe1de4fe7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rules/php-74/src/Rector/FuncCall/ArraySpreadInsteadOfArrayMergeRector.php
View File

@ -100,8 +100,12 @@ PHP
$array = new Array_();
foreach ($funcCall->args as $arg) {
$value = $arg->value;
// cannot handle unpacked arguments
if ($arg->unpack) {
return null;
}
$value = $arg->value;
if ($this->shouldSkipArrayForInvalidTypeOrKeys($value)) {
return null;
}

20
rules/php-74/tests/Rector/FuncCall/ArraySpreadInsteadOfArrayMergeRector/Fixture/skip_spread_array_merge.php.inc Normal file
View File

@ -0,0 +1,20 @@
<?php
namespace Rector\Php74\Tests\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector\Fixture;
use stdClass;
class SkipSpreadyArrayMerge
{
public function run()
{
$values = [
[new stdClass()],
[new stdClass]
];
$items = array_merge(...$values);
return array_merge($items, ...$values);
}
}