From f0f2f091f37acafa8112b375fc23d819b14b1e43 Mon Sep 17 00:00:00 2001 From: TomasVotruba Date: Tue, 17 Oct 2017 00:02:42 +0200 Subject: [PATCH] simplify NodeFactory --- src/Node/NodeFactory.php | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/Node/NodeFactory.php b/src/Node/NodeFactory.php index a5f3aff3bb2..4f1fe037592 100644 --- a/src/Node/NodeFactory.php +++ b/src/Node/NodeFactory.php @@ -58,7 +58,7 @@ final class NodeFactory */ public function createNullConstant(): ConstFetch { - return $this->createInternalConstant('null'); + return BuilderHelpers::normalizeValue(null); } /** @@ -66,7 +66,7 @@ final class NodeFactory */ public function createFalseConstant(): ConstFetch { - return $this->createInternalConstant('false'); + return BuilderHelpers::normalizeValue(false); } /** @@ -74,7 +74,7 @@ final class NodeFactory */ public function createTrueConstant(): ConstFetch { - return $this->createInternalConstant('true'); + return BuilderHelpers::normalizeValue(true); } /** @@ -251,12 +251,6 @@ final class NodeFactory */ public function createNamespace(string $namespace): Namespace_ { - return new Namespace_(new Name($namespace)); - } - - private function createInternalConstant(string $value): ConstFetch - { - // return BuilderHelpers::normalizeValue($value); - return new ConstFetch(new Name($value)); + return new Namespace_(BuilderHelpers::normalizeName($namespace)); } }