mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 11:44:14 +01:00
Code Issues Projects Releases Wiki Activity

[PHPUnit] fix arguments moving up for array_key_exists()

Browse Source
This commit is contained in:
TomasVotruba 2017-12-19 22:16:06 +01:00
parent 3612d139f7
commit f2014a2641
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/Rector/Contrib/PHPUnit/SpecificMethodRector.php
View File

@ -3,7 +3,6 @@
namespace Rector\Rector\Contrib\PHPUnit;
use PhpParser\Node;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\Empty_;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
@ -53,8 +52,6 @@ final class SpecificMethodRector extends AbstractRector
public function isCandidate(Node $node): bool
{
$this->activeFuncCallName = null;
if (! $this->methodCallAnalyzer->isTypesAndMethods(
$node,
['PHPUnit\Framework\TestCase', 'PHPUnit_Framework_TestCase'],
@ -90,7 +87,7 @@ final class SpecificMethodRector extends AbstractRector
public function refactor(Node $methodCallNode): ?Node
{
$this->renameMethod($methodCallNode);
$this->moveArgumentUp($methodCallNode);
$this->moveFunctionArgumentsUp($methodCallNode);
return $methodCallNode;
}
@ -112,22 +109,27 @@ final class SpecificMethodRector extends AbstractRector
}
}
private function moveArgumentUp(MethodCall $methodCallNode): void
/**
* Before:
* - $this->assertTrue(array_key_exists('...', ['...']), 'second argument');
*
* After:
* - $this->assertArrayHasKey('...', ['...'], 'second argument');
*/
private function moveFunctionArgumentsUp(MethodCall $methodCallNode): void
{
$funcCallOrEmptyNode = $methodCallNode->args[0]->value;
if ($funcCallOrEmptyNode instanceof FuncCall) {
$methodCallNode->args[0] = $funcCallOrEmptyNode->args[0];
$oldArguments = $methodCallNode->args;
unset($oldArguments[0]);
$newArguments = array_merge($funcCallOrEmptyNode->args, $oldArguments);
$methodCallNode->args = $newArguments;
}
if ($funcCallOrEmptyNode instanceof Empty_) {
$methodCallNode->args[0] = $funcCallOrEmptyNode->expr;
}
$arrayNode = $funcCallOrEmptyNode->args[1]->value ?? null;
if ($arrayNode instanceof Array_) {
$methodCallNode->args[1] = $arrayNode;
}
}
private function resolveFunctionName(Node $node): ?string