917 Commits

Author SHA1 Message Date
Tomas Votruba
0513315056
Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node (#4522)
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node

* update DecoupleClassMethodToOwnClassRector

* [ci] add rebase jobp

* disable fail fast for unit tests

* misc
2020-10-31 12:59:40 +00:00
Tommy Quissens
3bf107594e
[Downgrade PHP 7.3] Flexible Heredoc syntax (#4272) 2020-10-31 12:39:51 +01:00
Tomas Votruba
18d2ea2d31
[Nette] Add MoveFinalGetUserToCheckRequirementsClassMethodRector (#4520)
* [Nette] Add MoveFinalGetUserToCheckRequirementsClassMethodRector

* [Nette] Add MoveFinalGetUserToCheckRequirementsClassMethodRector

* patch final presenter to allow tests
2020-10-31 00:43:54 +00:00
Tomas Votruba
3ed76c6559
[Nette] Add RemoveParentAndNameFromComponentConstructorRector (#4515)
* [Nette] Add RemoveParentAndNameFromComponentConstructorRector

* add refactorClassMethod()

* add refactorStaticCall()

* add refactorNew() method

* [Nette] Rename AddDatePickerToDateControlRector to AddNextrasDatePickerToDateControlRector

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-30 17:10:17 +00:00
Tomas Votruba
b302e493dd
[SOLID] Add MoveVariableDeclarationNearReferenceRector (#4410)
* Create test cases

* Create rector

* Add closure to possible parent scopes

* Register in SOLID set

* Document the feature

* fix adding variable in closure

* move MoveVariableDeclarationNearReferenceRector to Assign category, based on getNodeTypes()

* ci: drop phpunit matcher, not much helpful

* ignore for now, many cases to cover

* prepare release

Co-authored-by: Anna Filina <afilina@gmail.com>
2020-10-30 13:25:24 +00:00
Tomas Votruba
dc2047f70a
[TypeDeclaration] Switch from stringy types to PHPStan types (#4510)
* nette-30 config cleanup

* [TypeDeclaratoin] Move AddReturnTypeDeclarationRector from generic

* add Type support to AddReturnTypeDeclaration

* make AddParamTypeDeclarationRector use PHPStan type objects over strings

* [SymfonyPhpConfig] Add support for nested types

* drop StringTypeToPhpParserNodeMapper

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-30 11:58:35 +00:00
Abdul Malik Ikhsan
9e0b632e4e
[CodeQualityStrict] Add CountArrayToEmptyArrayComparisonRector to CodeQualityStrict (#4496)
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-10-29 09:59:39 +01:00
Tomas Votruba
44b27f779e
[EarlyReturn] Decouple new set (#4490)
* [set] decouple new code-quality-strict

* decopule early-return set [closes #4464]

* [docker] drop prestissimo, as composer v2 does not need it

* [ci] move coding standard to ci_review

* [ci] try to run rector-ci on contributors
2020-10-27 13:47:37 +00:00
Tomas Votruba
a6e85fe69a
[PHPUnit] Fix AddSeeTestAnnotationRector for same short name, but different namespace (#4488)
* [PHPUnit] Fix AddSeeTestAnnotationRector for same short name, but different namespace

* correct namespaces
2020-10-27 00:42:04 +00:00
Abdul Malik Ikhsan
7a1ea1328b
[CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set (#4477)
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set

* rename use string parameter

* phpstan

* fix false positive string param to be var === variable name

* fix false positive

* phpstan

* ensure not same variable

* phpstan

* add ucfirst after var

* add fixture failing test for variable exists to be skipped

* add fixture failing test for variable exists in previuos statement

* phpstan space

* add handling variable exists in previous statement and in ClassMethod/Functions args

* handle exists but inside if

* reduce complexity

* clean up

* clean up

* cs fix

* phpstan

* remove - in variable

* use fallback when first character is numeric

* using regex to check string start alpha for variable

* cs fix

* use ClassConstFetch name to set variable name

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* clean up

* fix

* [ci-review] Rector Rectify

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-10-26 14:03:26 +00:00
Tomas Votruba
10ae0d687a
[CodeQuality] Add NewStaticToNewSelfRector (#4468)
* [CodeQuality] Add NewStaticToNewSelfRector

* regenerated docs

* drop patches
2020-10-20 22:01:47 +00:00
Tomas Votruba
4f37d2ec3f
decouple ProjectType from Option (#4451) 2020-10-19 15:11:40 +00:00
Abdul Malik Ikhsan
26ab509d7a
[CodeQuality] Register IssetOnPropertyObjectToPropertyExistsRector to code-quality config set (#4441)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 20:42:49 +02:00
Tomas Votruba
e845d7cea8
[DoctrineCodeQuality] Add ImproveDoctrineCollectionDocTypeInEntityRector (#4442)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 18:29:35 +02:00
Raffael Comi
055040f8e8
Downgrade PHP7.4 array_merge without arguments (#4377) (#4440) 2020-10-18 16:37:02 +02:00
Abdul Malik Ikhsan
ba4ec9de09
[DeadCode] Fixes #4425 Remove empty method call (#4428)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-17 17:29:10 +02:00
Tomas Votruba
8af70b5ac0
[Defluent] Refactoring to multiple rules (#4400)
* [Defluent] Refactoring to multiple rules

* [Defluent] Decouple defluent-only set, it deserved to have own domain

* cleanup

* [rector] cleanup

* [cs] cleanup

* fixup! cleanup

* static fixes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-14 04:24:29 +00:00
Tomas Votruba
4a76cdaa82
[SymfonyPHPConfig] Add monorepo split for value objects function (#4153)
* add monorepo split for symfony-php-config

* [SOLID] Prevent replacing referenced parametes with inlined constnat value

* make Symfon 5.0- compatible

* add support for reference skip in constructor

* [rector] add support for reference skip in constructor

* [cs] add support for reference skip in constructor

* improve misisng rule feedback

* underscore

* Fix ChangeReadOnlyVariableWithDefaultValueToConstantRector for new

* add clear-cache to all commands

* colors

* [rector] colors

* [cs] colors

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-10 17:42:43 +00:00
Igor
35537dba84
[SOLID] Change if && to early return (#4344)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-10 18:27:13 +02:00
TomasVotruba
7a7b3badb7 cs 2020-10-09 22:05:23 +02:00
Tomas Votruba
3808d1b941
[Nette 3.0] Set update (#4381) 2020-10-09 22:01:37 +02:00
Tomas Votruba
e47a806300
Remove AbstractFileSystemRector and move to AbstractRector (#4378) 2020-10-09 21:51:09 +02:00
Leonardo Losoviz
e4a9d2bdcf
[Downgrade PHP 7.4] Added downgrade array spread rule to set (#4379) 2020-10-09 12:49:16 +02:00
Tomas Votruba
5cb49a2d5a
[PSR-4] Move from FileSystemRector to FileWithoutNamespace node (#4372) 2020-10-08 23:28:24 +02:00
Leonardo Losoviz
effa4d34d8
[Downgrade PHP 7.3] List reference assignment (#4371)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-08 16:04:18 +02:00
Leonardo Losoviz
84c03bcbdc
[Downgrade PHP 7.4] Numeric Literal Separator Rector (#4361) 2020-10-06 11:55:43 +02:00
Leonardo Losoviz
bac865b437
Downgrade PHP7.4 strip_tags array arg (#4357)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-06 08:56:41 +02:00
Tomas Votruba
1c8fac5242
Add meta node FileWithoutNamespace (#4355)
* [CakePHP] Promote AppUsesStaticCallToUseStatementRector to File

* [CakePHP] Change ImplicitShortClassNameUseStatementRector to FileWithoutNamespace approach

* [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace

* [rector] [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace

* [cs] [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-05 08:39:02 +00:00
Tomas Votruba
7e124dffc0
[static] replace string attirbutes with contants + fix require rule (#4354)
* replace string attirbutes with contants

* static fixes

* composer: bump sypmlify

* composer: drop branch alias, not usedp
2020-10-04 22:19:25 +00:00
Abdul Malik Ikhsan
3ff3e37ecb
[symfony] add AutoWireWithClassNameSuffixForMethodWithRequiredAnnotationRector (#4341)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-02 12:29:18 +02:00
Abdul Malik Ikhsan
ae816c2c3d
Fixes #4337 : Make Option::SKIP works again with ParameterProvider (#4339) 2020-10-01 18:55:10 +02:00
Igor
6350692b98
[Naming] Move UnderscoreToCamelCaseVariableNameRector to Naming set (#4312) 2020-09-28 22:35:45 +02:00
Igor
ccb086aab7
[Naming] Make UnderscoreToCamelCasePropertyNameRector work with PropertyRenamer (#4283)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-28 20:29:37 +02:00
Igor
7d5ab130fb
[Renaming] Move RenamePropertyRector to appropriate set (#4303) 2020-09-27 23:33:32 +02:00
Tomas Votruba
7aad4bbf2f
[PHPStan] Enable regex constant rule (#4279) 2020-09-23 11:16:40 +02:00
Igor
52f02d8c91
[Naming] Make bool property respect is/has/was naming (#4215) 2020-09-22 20:22:10 +00:00
Igor
19f700ba4e
[Naming] Factory to create PropertyRename (#4255)
* [Naming] Use factory to create PropertyRename

* Ignore new phpstan issues

* Move fixture to FixtureBasic to solve CI issue

* fix setUp vs dataProvider race condition

* fix autoload

Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-21 20:45:43 +00:00
dobryy
28a55c973e
[DX] Add Rule that checks that Rule + value object have same starts (#4202)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-12 23:19:08 +02:00
Leonardo Losoviz
abb9a3ef90
Downgrade PHP7.1 features: nullable types and void return type (#4192) 2020-09-12 11:50:13 +02:00
dobryy
a6444fb801
[DX] Configurable rule must have configure code sample, and vice versa (#4174)
* [DX] Configurable rule must have configure code sample, and vice versa

* Add ConfiguredCodeSample

* heredocs

* code sample

* fix class

* drop AbstractConfigurableMatchTypeRector

Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-11 11:21:48 +02:00
dobryy
f69ea0e023
[Naming] Rename foreach value variable to match method return type (#4130)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-09 10:52:43 +02:00
Leonardo Losoviz
7a498e328e
Split downgrade sets (#4175)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-09 10:32:28 +02:00
Leonardo Losoviz
27fa9556d8
Added downgrade rules (#4172)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-08 17:18:49 +02:00
Leonardo Losoviz
4197899608
Downgrade union type (#4150)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-08 15:25:38 +02:00
Leonardo Losoviz
4eacc84b22
Organize downgrades by PHP version (#4147)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-08 13:12:38 +02:00
Tomas Votruba
6508aedd13
[Downgrade PHP 8.0] Add union types to doc types (#4082) 2020-09-08 12:00:38 +02:00
Leonardo Losoviz
a0f99c2c7f
Downgrade arrow functions (#4137)
* Extracted rule into abstract class for reuse

* Implemented rule

* Added rule to downgrade set

* Fixed rector-ci errors

* Fixed cs

* Preserve return type

* Direct assignment of parameters

* Use interface instead of abstract methods

* Moved abstract class under Php72

* Added test for params with type
2020-09-07 15:38:03 +02:00
Leonardo Losoviz
c6203e96d2
Downgrade null coalescing operator (#4135)
* Return `null` to signify no change to the node

* Implemented rector

* Added new rule to downgrade set

* Test requires PHP 7.4

* Wrapped code inside class
2020-09-07 14:50:42 +02:00
Leonardo Losoviz
71682d2b52
Abstract downgrade type + Implementation for object type (#4118) 2020-09-04 11:57:12 +02:00
jjthiessen
ff5b60826f
Correct various mysql_* to mysqli_* conversion bugs (#4119)
Co-authored-by: Jonathan Thiessen <jonathan.thiessen@terago.ca>
2020-09-03 20:49:31 +02:00