53 Commits

Author SHA1 Message Date
TomasVotruba
0800c7cdc3 fix cs 2021-05-06 20:51:25 +02:00
Tomas Votruba
38248d08f4
Return array of nodes directly from refactor() if possible (#6366)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-05-06 10:23:37 +02:00
Tomas Votruba
f925b62d9b
Report add array doc nodes (#6274) 2021-05-01 10:59:25 +00:00
Tomas Votruba
5cda5de4ac
Decouple Rector PHPStan rules to own package (#6242) 2021-04-25 23:12:14 +00:00
Abdul Malik Ikhsan
c51c1da262
[DeadCode] Use dependency injection for ConditionSearcher in RemoveUnusedVariableAssignRector (#6226) 2021-04-24 00:59:36 +00:00
Tomas Votruba
f9dc93cb1a
Fix WrapEncapsedVariableInCurlyBracesRector reporting (#6220)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-23 19:32:59 +00:00
Tomas Votruba
eda5bf1ea3
[DeadCode] Add RemoveUnusedPrivateMethodParameterRector (#6168)
* [DeadCode] Add RemoveUnusedPrivateMethodParameterRector

This reverts commit c815334bed781c555f08dff82ce7861d758e9e7a.

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-19 15:19:14 +02:00
Tomas Votruba
e8a76e8f2b
Do not prefix "parent", "self", "static" and native constants (#6159)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-17 12:09:58 +00:00
Abdul Malik Ikhsan
2b22e73efd
[DeadCode] Skip Variable Variable $$var on RemoveUnusedVariableAssignRector (#6156) 2021-04-16 12:14:05 +02:00
Abdul Malik Ikhsan
d4bb85bdc7
[DeadCode] Skip RemoveUnusedVariableAssignRector on next expr Include_ (#6153)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-16 11:18:07 +02:00
TomasVotruba
ca4e684491 fix cs 2021-04-16 00:43:26 +02:00
Tomas Votruba
e7e1b091d2
Simplify PropertyFetchByMethodAnalyzer (#6147)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-15 22:30:36 +00:00
SWalther
7bf3eeb61d
[DEAD-CODE] Added failing ShadowedLocalVariable test and implementation (#5996)
Co-authored-by: clxswalther <swalther@complex.it.de>
Co-authored-by: fbecker-complex <71324952+fbecker-complex@users.noreply.github.com>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2021-04-15 22:27:56 +00:00
TomasVotruba
aba310f89d remove unused CallDefaultParamValuesResolver 2021-04-16 00:15:30 +02:00
Tomas Votruba
101041d6ae
[DeadCode] Remove RemoveDefaultArgumentValueRector (#6148) 2021-04-16 00:11:58 +02:00
TomasVotruba
cb22e6386d fixes 2021-04-15 23:39:54 +02:00
Tomas Votruba
268b32ff7e
[DeadCode] Remove duplicated RemoveUnusedPrivateConstantRector (#6151)
* [DeadCode] Remove duplicated RemoveUnusedPrivateConstantRector

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-15 23:38:44 +02:00
Tomas Votruba
b8071fb7bc
Make use of inline parser over extreme node construction (#6145)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-15 17:34:49 +00:00
Tomas Votruba
8f256fa281
[DeadCode] Fix RemoveUnusedVariableAssignRector for variable removal (#6133) 2021-04-14 13:02:16 +00:00
Tomas Votruba
8b402bfe02
Make use of File object instead of passing around provider of file info, tokens, stmts etc. (#6110)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-13 00:12:48 +00:00
Tomas Votruba
ad7af917e2
Improve assert added and moved nodes (#6106) 2021-04-12 13:24:37 +00:00
Abdul Malik Ikhsan
faca7e2763
[DeadCode] Skip RemoveUnusedVariableAssignRector on used in next compact function (#6103)
Co-authored-by: repat <repat@repat.de>
2021-04-12 11:44:33 +02:00
Tomas Votruba
b121d8e10a
Remove mapToDocString() and use describe() instead (#6095) 2021-04-10 23:28:08 +00:00
Tomas Votruba
79621dbb99
Flip @see to @changelog links (#6092) 2021-04-10 18:47:17 +00:00
TomasVotruba
7aecf8138d remove unused class 2021-04-10 19:58:11 +02:00
Abdul Malik Ikhsan
723bd2b1b6
[CodeQualityStrict] Skip MoveVariableDeclarationNearReferenceRector on pass impure function (#6090) 2021-04-10 19:45:46 +02:00
Abdul Malik Ikhsan
ec32714ad9
[DeadCode] Skip RemoveUnusedVariableAssignRector on native variable (#6081) 2021-04-10 16:16:24 +02:00
Tomas Votruba
8e8446a909
remove METHOD_NAME attribute to promote single source of node (#6063) 2021-04-09 12:45:07 +02:00
Abdul Malik Ikhsan
a60748dc41
[DeadCode] Skip RemoveUnusedVariableAssignRector on used in Method call and PropertyFetch name (#6053)
* Add failing test fixture for RemoveUnusedVariableAssignRector

* Closes #6051

* cs

Co-authored-by: zingimmick <zingimmick@outlook.com>
2021-04-07 18:56:29 +02:00
Abdul Malik Ikhsan
0a9c6a8400
[CodeQuality] Register SimplifyIfNullableReturnRector to code-quality config set (#6047)
* [CodeQuality] Register SimplifyIfNullableReturnRector to code-quality config set

* handle next expression

* handle next expression

* handle next expression

* naming

* phpstan

* fixture fix

* fix

* check next early

* mirror comment not @var

* phpstan

* phpstan

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* phpstan

* more fixture for mirror comment without @var

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-07 00:00:14 +02:00
Tomas Votruba
b2412ad62a
Refactor doctrine/annotation from dynamic to own static-reflection parser (#5974)
* remove doctrine/annotations

* Refactor doctrine/annotation parser to static reflection with phpdoc-parser

* remove doctirne-annotation-parser-syncer

* remove annotation stubs

* use nodes

* almost there

* [ci-review] Rector Rectify

* skip temporary

* phpstan: remove fixed messages

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-04-04 11:01:11 +02:00
Tomas Votruba
5fa858b072
[DoctrineAnnotationSyncer] Remove to move to static reflection (#6006) 2021-03-29 13:01:35 +00:00
Abdul Malik Ikhsan
ce1bad3c3a
[DeadCode] Apply RemoveUnusedVariableAssignRector on unused local variable (#6003)
Co-authored-by: slomanto <s.lomanto@complex-it.de>
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-03-29 10:30:42 +02:00
Abdul Malik Ikhsan
8d1244f4bb
[DeadCode] Handle RemoveDefaultArgumentValueRector on removal default argument on not last argument (#5982) 2021-03-25 22:14:01 +01:00
Tomas Votruba
aae346b64f
[DeadCode] Skip RemoveDeadInstanceOfRector for traits (#5970) 2021-03-23 23:33:15 +00:00
Tomas Votruba
27e9ad030a
Remove buggy rules that depend on false condition of all class and calls analysis, to improve static reflection (#5958)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-03-23 23:13:35 +01:00
Tomas Votruba
4f27f39e70
Remove dynamic type checks #3 (#5942) 2021-03-21 23:07:40 +00:00
Tomas Votruba
ae1c6b90f7
Remove dynamic type checks #2 (#5941) 2021-03-21 21:31:18 +00:00
Tomas Votruba
a781b3bd12
Remove dynamic type checks (#5939) 2021-03-21 19:41:17 +01:00
Tomas Votruba
89a7afb5a4
Merge DeadDocBlock to DeadCode (#5936) 2021-03-21 12:57:56 +00:00
Abdul Malik Ikhsan
7e16399ddb
[DeadCode] Skip RemoveUnusedPrivateMethodRector when class has magic __call (#5932) 2021-03-21 10:52:15 +01:00
TomasVotruba
94fd5af4f8 make use of external symfony doc nodes 2021-03-21 01:38:09 +01:00
Tomas Votruba
44375f6637
Post Nette tags split cleanup (#5925)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-03-20 21:47:40 +00:00
Tomas Votruba
b28b8742fc
use rector-nette with tags (#5924)
* use rector-nette with tags

* redirect Kdyby sets

* use local ParamAnalyzer
2021-03-20 22:16:54 +01:00
TomasVotruba
b3536831fa move nette tags to own package 2021-03-20 21:16:07 +01:00
TomasVotruba
e13c2ecfd5 update decoupled tags 2021-03-20 21:10:34 +01:00
Tomas Votruba
cfa61bc2dd
remove PhpDocNodeTransformerInterface overly abstraction; merge AttributeAwarePhpDoc to BetterPhpDocParser (#5920)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-03-20 16:27:18 +01:00
Tomas Votruba
0f3d07f1f8
[DeadCode] Removing method/property entity Doctrine remover, too vague (#5892) 2021-03-18 02:44:36 +01:00
Tomas Votruba
c815334bed
[DeadCode] Remove RemoveUnusedParameterRector (#5888) 2021-03-18 01:10:37 +01:00
TomasVotruba
de02a85e3f remove parent class 2021-03-18 00:00:16 +01:00