* skip rename
* add method call and variable name for MoveOutMethodCallInsideIfConditionRector
* decouple MethodCallToVariableNameResolver
* use trick with Scope if variable is already defined
* fixup! use trick with Scope if variable is already defined
* cover case with variable name and method call
* add decopule note future
* [ci-review] Rector Rectify
* [ci] try re-trigger ci-review after push automatically
Co-authored-by: rector-bot <tomas@getrector.org>
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set
* rename use string parameter
* phpstan
* fix false positive string param to be var === variable name
* fix false positive
* phpstan
* ensure not same variable
* phpstan
* add ucfirst after var
* add fixture failing test for variable exists to be skipped
* add fixture failing test for variable exists in previuos statement
* phpstan space
* add handling variable exists in previous statement and in ClassMethod/Functions args
* handle exists but inside if
* reduce complexity
* clean up
* clean up
* cs fix
* phpstan
* remove - in variable
* use fallback when first character is numeric
* using regex to check string start alpha for variable
* cs fix
* use ClassConstFetch name to set variable name
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* clean up
* fix
* [ci-review] Rector Rectify
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
* Add MoveOutMethodCallInsideIfConditionRector
* cs fix
* implemented handling pass constant to arg 0
* phpstan
* final touch: no need strtolower() before ucfirst on fallback var name
* [CakePHP] Promote AppUsesStaticCallToUseStatementRector to File
* [CakePHP] Change ImplicitShortClassNameUseStatementRector to FileWithoutNamespace approach
* [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace
* [rector] [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace
* [cs] [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace
Co-authored-by: rector-bot <tomas@getrector.org>
* [CI] Add type-declaration set
* [rector] [CI] Add type-declaration set
* [cs] [CI] Add type-declaration set
* skip nullable void
* add anonymous parent/interface support
* refactor MultiExceptionCatchRector to use Catch_ over integers
* type fixes
* fix unoin array type override
* remove unused test cases
* drop overcomplicated InlineValidationRulesToArrayDefinitionRector
* skip assign on var
* [rector] skip assign on var
* [cs] skip assign on var
* [rector] [cs] skip assign on var
* skip assign on var
* fixes
* [rector] fixes
* [cs] fixes
Co-authored-by: rector-bot <tomas@getrector.org>
* [MagicDisclosure] Add MethodCallOnSetterMethodCallToStandaloneAssignRector
* merge ChainMethodCallManipulator to ChainMethodCallNodeAnalyzer for better DX
* [MagicDisclosure] Add in arg defluent
* rebase
- added RunnableTestCase::assertOriginalAndFixedFileYieldSameResult($file)
that takes a fixture file and expects fixture classes that implement the
new RunnableInterface which exposes a run() method
- the fixture class is dynamically renamed to avoid naming conflicts
and loaded via eval()
- fixtures that don't implement the RunnableInterface are ignored
otherwise the run() method is called on the original class as well
as on the fixed one and the output is expected to be equal
(via assertSame)
- fixed typo in RectorDefinition code sample
- fixed argument order of array_key_exists
- renamed test folder from ArrayKeysAndInArrayToIssetRector
to ArrayKeysAndInArrayToArrayKeyExistsRector
