112 Commits

Author SHA1 Message Date
Tomas Votruba
2ea430b0ec
[PHP 8.0] Fix used variable rename in propperty promotion (#4841)
* [PHP 8.0] Add test case for used variable

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-09 23:40:38 +00:00
Tomas Votruba
d131d804d9
Bump min PHP version to 7.3 (#4838)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-09 23:25:53 +01:00
Leonardo Losoviz
ec4096134a
Added test cases to validate bug #4397 (#4815) 2020-12-07 12:11:38 +01:00
Tomas Votruba
db63a96397
[PHP 8.0] CI test fixes (#4805)
* [Downgrade PHP 8.0] Fix Union type

* run variable rename

* allow test

* fix regex

* allow run

* remove test dependency on DateTime changing api

* normalize
2020-12-06 10:19:17 +00:00
Tomas Votruba
bfd1953f97
move string downgrade types to object classes (#4801)
* move string downgrade types to object classes

* fix nullable type unwrap

* remove uneeded open tags from samples

* remove uneeded union type check
2020-12-06 00:27:00 +00:00
Abdul Malik Ikhsan
1e667b454f
[CI] Add PHP 8.0 to Github actions tests (#4779) 2020-12-05 12:10:44 +01:00
Tomas Votruba
132062acf3
[DeadCode] Fix dead method in property promotion (#4749)
* [DeadCode] Fix dead method in property promotion

* bump workflows PHP version to 7.2, to respect symplify bump

* allow non-existing attributes in tests
2020-12-02 10:15:39 +00:00
Tomas Votruba
f38dc68649
[Naming] Skip union type to resolve param name (#4742) 2020-12-01 15:57:41 +01:00
Abdul Malik Ikhsan
a38debb672
[DX] Fixes #4205 Change phpversion from string to php constant int type (#4679)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-24 16:32:49 +01:00
Tomas Votruba
a7705ed0a5
[Symplify 9] First update + switch to RuleDocGenerator (#4616)
* [composer] bump to Symplify 9

* [Symplify 9] Update phpstan rules

* bump to Symplify 9 BETA2

* update AbstractKernel from Tests to Testing namespace

* decoupling removing node trait

* remove fluent calls

* removing variadic

* [CodingStyle] Improve AnnotateThrowablesRector

* bump deps

* Make use of RuleDocGenerator

* first short

* [DocumentationGenerator] Drop deprecated package, RuleSetGenerator now handles it

* import namespace

* update docs
2020-11-16 17:50:38 +00:00
Abdul Malik Ikhsan
4c243e1c9c
[Naming] Fixes #4621 : Skip rename when after rename has numeric in first char (#4623) 2020-11-16 13:04:32 +01:00
Tomas Votruba
0513315056
Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node (#4522)
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node

* update DecoupleClassMethodToOwnClassRector

* [ci] add rebase jobp

* disable fail fast for unit tests

* misc
2020-10-31 12:59:40 +00:00
Tomas Votruba
91a354c080
[NetteCodeQuality] Fix ChangeFormArrayAccessToAnnotatedControlVariableRector for in-closure (#4506)
* [NetteCodeQuality] Fix ChangeFormArrayAccessToAnnotatedControlVariableRector for in-closure

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* fix name

* fix unknown mixed type on fluent

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-29 21:25:35 +00:00
Abdul Malik Ikhsan
449801e1f3
Add regex uri to regex constant (#4504)
Co-authored-by: Jan Lohage <j2L4e@users.noreply.github.com>
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-29 19:04:33 +01:00
Abdul Malik Ikhsan
9e0b632e4e
[CodeQualityStrict] Add CountArrayToEmptyArrayComparisonRector to CodeQualityStrict (#4496)
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-10-29 09:59:39 +01:00
Abdul Malik Ikhsan
7a1ea1328b
[CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set (#4477)
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set

* rename use string parameter

* phpstan

* fix false positive string param to be var === variable name

* fix false positive

* phpstan

* ensure not same variable

* phpstan

* add ucfirst after var

* add fixture failing test for variable exists to be skipped

* add fixture failing test for variable exists in previuos statement

* phpstan space

* add handling variable exists in previous statement and in ClassMethod/Functions args

* handle exists but inside if

* reduce complexity

* clean up

* clean up

* cs fix

* phpstan

* remove - in variable

* use fallback when first character is numeric

* using regex to check string start alpha for variable

* cs fix

* use ClassConstFetch name to set variable name

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* clean up

* fix

* [ci-review] Rector Rectify

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-10-26 14:03:26 +00:00
Tomas Votruba
5f3b4bde1f
[Naming] Allow does in MakeIsserClassMethodNameStartWithIsRector (#4486) 2020-10-26 10:22:20 +00:00
Tomas Votruba
b2c9e3b127
[DeadCode] Make RemoveUnusedPrivateConstantRector skip enum (#4419) 2020-10-15 13:04:58 +00:00
Tomas Votruba
c84690baa6
[DeadCode] Various improvements (#4417) 2020-10-15 14:15:01 +02:00
Tomas Votruba
01514ab9a8
[SimplePhpDocParser] Add README + getParam*() helper methods (#4393) 2020-10-11 16:17:43 +02:00
Igor
635e0292c2
Add missing abstract keyword (#4347)
* Remove CheckRequiredAbstractKeywordForClassNameStartWithAbstractRule related error from ignore

* Ignore new PHPStan errors
2020-10-04 22:41:31 +02:00
Abdul Malik Ikhsan
0680e70035
[naming] move UnderscoreToCamelCaseLocalVariableNameRector to Naming Set (#4346) 2020-10-04 12:48:43 +02:00
Igor
24f499c9d8
[Naming] Apply ParamRenamer without conflict resolution for Naming set (#4335) 2020-10-03 21:18:12 +02:00
Abdul Malik Ikhsan
3ff3e37ecb
[symfony] add AutoWireWithClassNameSuffixForMethodWithRequiredAnnotationRector (#4341)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-02 12:29:18 +02:00
Tomas Votruba
8ae3868a57
[Restoration] Add RestoreFullyQualifiedNameRector (#4336)
* [Restoration] Add RestoreFullyQualifiedNameRector

* update docs

* use service aware test case for PHPStan rules

* improve FullyQualifiedNameMatcher

* cs fixes

* add return doc resolution

* composer: bump to symfony 4.4/5.1
2020-10-01 19:45:29 +00:00
Abdul Malik Ikhsan
ae816c2c3d
Fixes #4337 : Make Option::SKIP works again with ParameterProvider (#4339) 2020-10-01 18:55:10 +02:00
Igor
6350692b98
[Naming] Move UnderscoreToCamelCaseVariableNameRector to Naming set (#4312) 2020-09-28 22:35:45 +02:00
Igor
ccb086aab7
[Naming] Make UnderscoreToCamelCasePropertyNameRector work with PropertyRenamer (#4283)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-28 20:29:37 +02:00
Tomas Votruba
7aad4bbf2f
[PHPStan] Enable regex constant rule (#4279) 2020-09-23 11:16:40 +02:00
Igor
52f02d8c91
[Naming] Make bool property respect is/has/was naming (#4215) 2020-09-22 20:22:10 +00:00
Igor
19f700ba4e
[Naming] Factory to create PropertyRename (#4255)
* [Naming] Use factory to create PropertyRename

* Ignore new phpstan issues

* Move fixture to FixtureBasic to solve CI issue

* fix setUp vs dataProvider race condition

* fix autoload

Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-21 20:45:43 +00:00
Igor
52f560a570
[Naming] Decouple conflict resolution (#4253)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-19 10:29:39 +02:00
Igor
1582dc46f4
[Naming] Decouple property renaming into PropertyRenamer (#4242) 2020-09-17 23:18:18 +02:00
Igor
f2ecdeb0b1
[Naming] Foreach over "data", renames to "datum" (#4221)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-15 10:23:13 +02:00
dobryy
4fee8c6773
[DX] PHPStan rule to check, that value objects do not have value object suffix (#4206)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-13 01:08:21 +02:00
Tomas Votruba
59c5a5e5ba
[NodeRepository] Merge function like finder to NodeRepository (#4186)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-11 00:09:05 +02:00
Tomas Votruba
7cab529bf8
Introduce NodeRepository, single place to get all nodes (#4183)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-10 12:24:43 +02:00
dobryy
f69ea0e023
[Naming] Rename foreach value variable to match method return type (#4130)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-09 10:52:43 +02:00
Tomas Votruba
7ac228c638
[CI] Add type-declaration set (#4089)
* [CI] Add type-declaration set

* [rector] [CI] Add type-declaration set

* [cs] [CI] Add type-declaration set

* skip nullable void

* add anonymous parent/interface support

* refactor MultiExceptionCatchRector to use Catch_ over integers

* type fixes

* fix unoin array type override

* remove unused test cases

* drop overcomplicated InlineValidationRulesToArrayDefinitionRector

* skip assign on var

* [rector] skip assign on var

* [cs] skip assign on var

* [rector] [cs] skip assign on var

* skip assign on var

* fixes

* [rector] fixes

* [cs] fixes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-01 17:56:30 +00:00
dobryy
4e91b78c7b
[Naming] Rename the rule to make it correspond with what rule does (#4076)
* [Naming] Rename the rule to make it correspond with what rule does

* [Naming] Update doc
2020-08-30 21:01:33 +02:00
Tomas Votruba
989c3f4168
[Transform] Move HelperFunctionToConstructorInjectionRector to Transform package (#4074)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-30 18:55:16 +02:00
Tom Pavelec
36b24b2bfc
fix: swapped naming of camel and pascal cases (#4047) 2020-08-28 18:07:15 +02:00
Tomas Votruba
c1653070f5
[phpstan] Add rule for complex config (#4015)
* [phpstan] Add ForbiddenComplexArrayConfigInSetRule

* add MethodCallRename value object

* [SymfonyPhpConfig] Add array to value object configuration rule

* apply first MethodCallRename value object
2020-08-24 22:26:14 +00:00
TomasVotruba
6f53f55798 fix cs 2020-08-22 19:13:22 +02:00
Tomas Votruba
766853315e
[Naming] Add MakeIsserClassMethodNameStartWithIsRector (#4005) 2020-08-22 19:04:25 +02:00
Tomas Votruba
9164d46a3b
[Naming] Add MakeGetterClassMethodNameStartWithGetRector (#4003)
* [Naming] Add MakeGetterClassMethodNameStartWithGetRector

* [rector] [Naming] Add MakeGetterClassMethodNameStartWithGetRector

* [cs] [Naming] Add MakeGetterClassMethodNameStartWithGetRector

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-22 15:46:09 +00:00
dobryy
857fd25168
RenameParamToMatchTypeRector doesn't skip variable that is used in callback function use statement (#3970)
* Include use in rename

* [rector] Include use in rename

* [rector] [rector] Include use in rename

* [cs] [rector] Include use in rename

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-21 17:13:56 +00:00
Tomas Votruba
1c4b510513
PHPStan: require iterable types (#3936)
* phpstan: require iterable types

* add link on relative path and line

* fix missing class type

* typed array in Rector code + add data provide support resolver

* remove duplicated set

* drop unused yaml ecs config

* add out-of-the-box directory for 3rd party packages

* static fixes

* [rector] static fixes

* [cs] static fixes

* [rector] [cs] static fixes

* generic types

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-11 10:59:04 +00:00
dobryy
411d76f9a9
[Order] Make OrderPrivateMethodsByUseRector process file in one run u… (#3889)
* [Order] Make OrderPrivateMethodsByUseRector process file in one run using while loop

* [Order] Enable rule in CI

* [rector] [Order] Enable rule in CI

* [cs] [Order] Enable rule in CI

* [Order] Use constant for number of max attempts and throw exception when exceeded.

* [rector] [Order] Use constant for number of max attempts and throw exception when exceeded.

* [cs] [Order] Use constant for number of max attempts and throw exception when exceeded.

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-05 22:45:36 +02:00
Tomas Votruba
7212366606
[Naming] Decouple RenameParamToMatchTypeRector (#3906)
* [Naming] Decouple RenameParamToMatchTypeRector

* remove overrlaping useless test fixtures

* [rector] remove overrlaping useless test fixtures

* [cs] remove overrlaping useless test fixtures

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-04 18:30:31 +00:00