1157 Commits

Author SHA1 Message Date
Tomas Votruba
5f3b4bde1f
[Naming] Allow does in MakeIsserClassMethodNameStartWithIsRector (#4486) 2020-10-26 10:22:20 +00:00
Tomas Votruba
0f2e6d407e
[DoctrineAnnotaitonGenerated] Update to doctrine/annotations 1.11 + fix static (#4479) 2020-10-25 14:43:05 +01:00
Abdul Malik Ikhsan
11c76808be
[CodeQuality] Add MoveOutMethodCallInsideIfConditionRector (#4457)
* Add MoveOutMethodCallInsideIfConditionRector

* cs fix

* implemented handling pass constant to arg 0

* phpstan

* final touch: no need strtolower() before ucfirst on fallback var name
2020-10-23 15:15:54 +02:00
Abdul Malik Ikhsan
be06b60eac
Typo Fix: Strings::endWith() should be Strings::endsWith() (#4475)
* Typo Fix: Strings::endWith() should be Strings::endsWith()

* [rector] Typo Fix: Strings::endWith() should be Strings::endsWith()

* [cs] Typo Fix: Strings::endWith() should be Strings::endsWith()

* phpstan

* [rector] phpstan

* [cs] phpstan

* cs fix

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-23 11:23:12 +02:00
Tomas Votruba
6c51f3fb4f
[Restoration] Add InferParamFromClassMethodReturnRector (#4471)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-21 23:06:24 +02:00
Tomas Votruba
10ae0d687a
[CodeQuality] Add NewStaticToNewSelfRector (#4468)
* [CodeQuality] Add NewStaticToNewSelfRector

* regenerated docs

* drop patches
2020-10-20 22:01:47 +00:00
Tomas Votruba
aa98eb5d9e
[CodeQuality] Skip dynamic properties for bindTo() (#4467)
* [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [rector] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [cs] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-20 22:43:05 +02:00
Tomas Votruba
75d25a1dcb
[CodeQuality] Decouple complete dynamic properties rector, add skip of Closure::bind() (#4466)
* [ci] temporarily hide split monorepo

* [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [rector] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [cs] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-20 20:27:12 +00:00
Tomas Votruba
5988584736
[CodeQuality] Improve missing property type resolution for array dim fetch (#4462)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-20 20:35:35 +02:00
Tomas Votruba
b9f45eab00
[CodeQuality] Skip nested foreach (#4461) 2020-10-20 17:07:01 +02:00
Tomas Votruba
8bdb879a55
[CodeQuality] Add nested foreach foreach that is required for assign (#4459) 2020-10-20 14:24:32 +00:00
TomasVotruba
7c303021c4 [PHP 7.1] Skip variable arguments count for RemoveExtraParametersRector 2020-10-20 15:05:37 +02:00
Tomas Votruba
9d2757f80d
[CodeQuality] Support multi boolean and in isset on property (#4455)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-20 12:50:21 +02:00
Tomas Votruba
4f37d2ec3f
decouple ProjectType from Option (#4451) 2020-10-19 15:11:40 +00:00
Tomas Votruba
9869678e4a
[DeadCode] Fix removal of if->cond (#4450) 2020-10-19 16:38:02 +02:00
Tomas Votruba
5b37363b60
[DeadCode] Add expr-names support to RemoveEmptyMethodCallRector (#4448)
* [DeadCode] Add expr-names support to RemoveEmptyMethodCallRector

* skip abstract method
2020-10-19 13:35:37 +00:00
Tomas Votruba
c18b06b474
[DeadCode] Cover array dim fetch assign (#4446) 2020-10-19 01:46:38 +02:00
Tomas Votruba
29594b63f4
[DeadCode] Count arg value as used (#4445) 2020-10-18 23:18:04 +00:00
Raffael Comi
073a2a3eee
Infer var type annotation only if none exists (#4443) 2020-10-19 00:05:36 +02:00
Tomas Votruba
f96372e1c0
make use of Types of doc types (#4444) 2020-10-18 21:49:54 +02:00
Abdul Malik Ikhsan
26ab509d7a
[CodeQuality] Register IssetOnPropertyObjectToPropertyExistsRector to code-quality config set (#4441)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 20:42:49 +02:00
Tomas Votruba
e845d7cea8
[DoctrineCodeQuality] Add ImproveDoctrineCollectionDocTypeInEntityRector (#4442)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 18:29:35 +02:00
Raffael Comi
055040f8e8
Downgrade PHP7.4 array_merge without arguments (#4377) (#4440) 2020-10-18 16:37:02 +02:00
TomasVotruba
8e7c521c41 typo 2020-10-18 11:03:19 +02:00
TomasVotruba
009e73886c typo 2020-10-18 11:02:40 +02:00
Tomas Votruba
fd9bd00713
[DoctrineCodeQuality] Fix oveCurrentDateTimeDefaultInEntityToConstructorRector for default value (#4436)
* [DoctrineCodeQuality] Fix oveCurrentDateTimeDefaultInEntityToConstructorRector for default value

* re-use local property method

* improve new_ nesting

* [rector] improve new_ nesting

* static fixes

* bump deps

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 08:45:56 +00:00
Abdul Malik Ikhsan
67bdc35fe5
[core] Add ClassReflectionToAstResolver service (#4438) 2020-10-18 10:31:37 +02:00
Abdul Malik Ikhsan
c6eb33ab2f
[DeadCode] Improve RemoveEmptyMethodCallRector: Using PHPStan\Reflection\ClassReflection->isBuiltIn() to check internal class (#4435) 2020-10-17 18:40:40 +02:00
Abdul Malik Ikhsan
ba4ec9de09
[DeadCode] Fixes #4425 Remove empty method call (#4428)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-17 17:29:10 +02:00
Tomas Votruba
9f7073ada3
[NodeAnalyzer] Check property fetch for read (#4431)
* [NodeAnalyzer] Check property fetch for read

* [ReadWrite] Decopule new package for read/write/only analysis

* add property fetch
2020-10-16 20:16:36 +00:00
Tomas Votruba
245000a0ce
[DeadCode] Improve unused private property detection (#4430)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-16 21:29:29 +02:00
Leonardo Losoviz
8ba46c51e4
[Downgrade PHP7.3] Remove unneeded params from list(), and even remove list() (#4392)
* Remove unneeded params from `list` and even `list`

* Fixed cs

* Re-ordered private methods

* Fixed rector-ci

* Fixed cs

* Fixed phpstan error

* Use typehint, not docblock

* Fixed phpstan cognitive complexity error

* Fixed rector-ci

* Improved code sample

* Fixed code sample

* Extracted code into function

* Reduced complexity

* Reduced complexity

* Reduced  complexity

* Added comment

* Renamed function

* Documented code

* Moved code into function

* Fixed cs

* Fixed rector-ci
2020-10-16 00:44:29 +02:00
Leonardo Losoviz
139823a3a2
[Downgrade PHP 7.4] Support iterable pseudo-type when downgrading the array spread (#4404)
* Support iterable pseudo-type

* Renamed function

* Fixed cs
2020-10-16 00:25:34 +02:00
Tomas Votruba
16031da4b7
[DeadCode] Fix binary different nesting in RemoveOverriddenValuesRector (#4422)
* decopule NodeByTypeAndPositionCollector

* decouple VariableUseFinder
2020-10-15 20:23:25 +00:00
Pol Dellaiera
09dc6cef9a
Issue #4413: Do not refactor iterator_to_array. (#4415)
* Issue #4413: Do not refactor iterator_to_array.

Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>

* Issue #4413: Update tests based on review feedback.

* Issue #4413: Fix CS.
2020-10-15 17:55:38 +02:00
Tomas Votruba
b2c9e3b127
[DeadCode] Make RemoveUnusedPrivateConstantRector skip enum (#4419) 2020-10-15 13:04:58 +00:00
Tomas Votruba
c84690baa6
[DeadCode] Various improvements (#4417) 2020-10-15 14:15:01 +02:00
Leonardo Losoviz
6f1590efcd
Downgrade Rector to PHP 7.1 - Use same signature for prettyPrintFile as in PrettyPrinterAbstract (#4408)
* Use same signature as in PrettyPrinterAbstract

* Pass array of $nodes to `printNodesToFilePath`

* Use array for $nodes in `printToFile`

* Removed stale logic, fixed phpstan
2020-10-15 09:35:50 +00:00
Tomas Votruba
151a83a733
[DeadCode] Remove php-doc from remove params (#4411)
* [DeadCode] Remove unused param doc too

* [DeadCode] Remove php-doc from remove parmas

* [rector] [DeadCode] Remove php-doc from remove parmas

* [cs] [DeadCode] Remove php-doc from remove parmas

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-14 23:20:02 +00:00
Tomas Votruba
e085f52f86
[DeadCode] Improve parent and current type comparison on RemoveDelegatingParentCallRector (#4409)
* decouple CurrentAndParentClassMethodComparator

* fix param reflections

* [rector] fix param reflections

* [cs] fix param reflections

* composer: bump assert

* [rector] composer: bump assert

* [cs] composer: bump assert

* static fixes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-14 17:14:55 +00:00
Tomas Votruba
8af70b5ac0
[Defluent] Refactoring to multiple rules (#4400)
* [Defluent] Refactoring to multiple rules

* [Defluent] Decouple defluent-only set, it deserved to have own domain

* cleanup

* [rector] cleanup

* [cs] cleanup

* fixup! cleanup

* static fixes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-14 04:24:29 +00:00
Igor
d017e5417e
[SOLID] Change if && to early return (process nested ifs) (#4395)
* [SOLID] Change if && to early return (process nested ifs)

* Skip if with void return

* Skip if parent if has void return

* [rector] Skip if parent if has void return

* [cs] Skip if parent if has void return

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-13 20:30:14 +02:00
Tomas Votruba
cb991af9c6
hotfix mysql connection resolving (#4399) 2020-10-12 21:06:24 +02:00
Tomas Votruba
a31837679d
[PHP 7.4] Add null on conditional type of property type (#4394)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-12 16:34:28 +02:00
Tomas Votruba
01514ab9a8
[SimplePhpDocParser] Add README + getParam*() helper methods (#4393) 2020-10-11 16:17:43 +02:00
Igor
874baec836
[SOLID] Change if && to early return (more than two conditions) (#4390)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-11 11:43:51 +02:00
Tomas Votruba
4a76cdaa82
[SymfonyPHPConfig] Add monorepo split for value objects function (#4153)
* add monorepo split for symfony-php-config

* [SOLID] Prevent replacing referenced parametes with inlined constnat value

* make Symfon 5.0- compatible

* add support for reference skip in constructor

* [rector] add support for reference skip in constructor

* [cs] add support for reference skip in constructor

* improve misisng rule feedback

* underscore

* Fix ChangeReadOnlyVariableWithDefaultValueToConstantRector for new

* add clear-cache to all commands

* colors

* [rector] colors

* [cs] colors

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-10 17:42:43 +00:00
Igor
35537dba84
[SOLID] Change if && to early return (#4344)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-10 18:27:13 +02:00
Leonardo Losoviz
0b54ff3d97
[Downgrade PHP 7.4] Array spread - don't use ternary for arrays, or PHPStan complains (#4380) 2020-10-10 09:18:57 +02:00
Tomas Votruba
3808d1b941
[Nette 3.0] Set update (#4381) 2020-10-09 22:01:37 +02:00